From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: tglx@linutronix.de, daniel.lezcano@linaro.org
Cc: linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, khilman@baylibre.com,
carlo@caione.org
Subject: Re: [PATCH 0/2] clocksource/meson6_timer: implement ARM delay timer
Date: Wed, 14 Nov 2018 23:33:52 +0100 [thread overview]
Message-ID: <CAFBinCDUYwDn8e4wOKzRCeKMgE0Ey8e_RhmPKim60sbrHBq_Xw@mail.gmail.com> (raw)
In-Reply-To: <20181028125501.17336-1-martin.blumenstingl@googlemail.com>
Hi Daniel, Hi Thomas,
On Sun, Oct 28, 2018 at 1:55 PM Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> While trying to add support for the ARM TWD Timer and the ARM Global
> Timer on Meson8, Meson8b and Meson8m2 (ARM Cortex-A5 and Cortex-A9 SoCs)
> I did a review of the existing driver.
> Unfortunately I found it hard to review because the pre-processor
> #defines did not match the names from the public S805 datasheet. Thus
> patch #1 adjusts these. No functional changes here, this is just
> preparation work for patch #2.
>
> Using the ARM Global Timer (drivers/clocksource/arm_global_timer.c)
> would have given us a timer-based delay implementation (so udelay() and
> friends would use the timer instead of using a loop-based delay
> implementation). Unfortunately we can't use the ARM Global Timer yet
> because it's input clock is derived from the CPU clock (which can change
> once we enable CPU frequency scaling on these SoCs, for which I will be
> sending patches in the near future).
> Amlogic's 3.10 kernel uses Timer E as delay timer which (with the
> current configuration) has a resolution of 1us. So patch #2 uses
> register_current_timer_delay() to register Timer E as ARM delay timer
> (which will be especially useful as we have to use udelay() when
> changing the CPU clocks during DVFS).
>
>
> Martin Blumenstingl (2):
> clocksource: meson6_timer: use register names from the datasheet
> clocksource: meson6_timer: implement ARM delay timer
(gentle ping) can you please queue these two patches for v4.21?
if not: please let me know what I can improve, then I'll fix that and send a v2
thank you!
Regards
Martin
prev parent reply other threads:[~2018-11-14 22:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-28 12:54 [PATCH 0/2] clocksource/meson6_timer: implement ARM delay timer Martin Blumenstingl
2018-10-28 12:55 ` [PATCH 1/2] clocksource: meson6_timer: use register names from the datasheet Martin Blumenstingl
2018-11-15 1:35 ` Daniel Lezcano
2018-11-15 6:23 ` Martin Blumenstingl
2018-11-15 12:15 ` Daniel Lezcano
2018-10-28 12:55 ` [PATCH 2/2] clocksource: meson6_timer: implement ARM delay timer Martin Blumenstingl
2018-11-14 22:33 ` Martin Blumenstingl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCDUYwDn8e4wOKzRCeKMgE0Ey8e_RhmPKim60sbrHBq_Xw@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=carlo@caione.org \
--cc=daniel.lezcano@linaro.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).