From: Oded Gabbay <oded.gabbay@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Kuehling, Felix" <Felix.Kuehling@amd.com>,
"Yong Zhao" <yong.zhao@amd.com>,
"Kent Russell" <kent.russell@amd.com>,
"Philip Yang" <Philip.Yang@amd.com>,
"Harish Kasiviswanathan" <Harish.Kasiviswanathan@amd.com>,
"Andres Rodriguez" <andres.rodriguez@amd.com>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [RESEND] amdgpu: kfd: use modern ktime accessors
Date: Thu, 26 Jul 2018 16:59:06 +0300 [thread overview]
Message-ID: <CAFCwf114SALuHsHmhbNxG+OMh+Zg+wnfJ6mirMuu2zmXiq6fqQ@mail.gmail.com> (raw)
In-Reply-To: <20180711124112.893478-1-arnd@arndb.de>
On Wed, Jul 11, 2018 at 3:41 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> getrawmonotonic64() and get_monotonic_boottime64() are deprecated
> because of the nonstandard naming.
>
> The replacement functions ktime_get_raw_ns() and ktime_get_boot_ns()
> also simplify the callers.
>
> Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>.
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Patch was originall sent on Jun 18 but not applied yet, resending
> With Felix' Reviewed-by tag
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> index f64c5551cdba..7e717716b90e 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> @@ -754,7 +754,6 @@ static int kfd_ioctl_get_clock_counters(struct file *filep,
> {
> struct kfd_ioctl_get_clock_counters_args *args = data;
> struct kfd_dev *dev;
> - struct timespec64 time;
>
> dev = kfd_device_by_id(args->gpu_id);
> if (dev)
> @@ -766,11 +765,8 @@ static int kfd_ioctl_get_clock_counters(struct file *filep,
> args->gpu_clock_counter = 0;
>
> /* No access to rdtsc. Using raw monotonic time */
> - getrawmonotonic64(&time);
> - args->cpu_clock_counter = (uint64_t)timespec64_to_ns(&time);
> -
> - get_monotonic_boottime64(&time);
> - args->system_clock_counter = (uint64_t)timespec64_to_ns(&time);
> + args->cpu_clock_counter = ktime_get_raw_ns();
> + args->system_clock_counter = ktime_get_boot_ns();
>
> /* Since the counter is in nano-seconds we use 1GHz frequency */
> args->system_clock_freq = 1000000000;
> --
> 2.9.0
>
Applied to -next
Thanks,
Oded
prev parent reply other threads:[~2018-07-26 13:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 12:41 [PATCH] [RESEND] amdgpu: kfd: use modern ktime accessors Arnd Bergmann
2018-07-26 13:59 ` Oded Gabbay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFCwf114SALuHsHmhbNxG+OMh+Zg+wnfJ6mirMuu2zmXiq6fqQ@mail.gmail.com \
--to=oded.gabbay@gmail.com \
--cc=David1.Zhou@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=Harish.Kasiviswanathan@amd.com \
--cc=Philip.Yang@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andres.rodriguez@amd.com \
--cc=arnd@arndb.de \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kent.russell@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yong.zhao@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).