* [PATCH] [RESEND] amdgpu: kfd: use modern ktime accessors
@ 2018-07-11 12:41 Arnd Bergmann
2018-07-26 13:59 ` Oded Gabbay
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-07-11 12:41 UTC (permalink / raw)
To: Oded Gabbay, Alex Deucher, Christian König,
David (ChunMing) Zhou, David Airlie
Cc: Arnd Bergmann, Felix Kuehling, Yong Zhao, Kent Russell,
Philip Yang, Harish Kasiviswanathan, Andres Rodriguez, dri-devel,
amd-gfx, linux-kernel
getrawmonotonic64() and get_monotonic_boottime64() are deprecated
because of the nonstandard naming.
The replacement functions ktime_get_raw_ns() and ktime_get_boot_ns()
also simplify the callers.
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Patch was originall sent on Jun 18 but not applied yet, resending
With Felix' Reviewed-by tag
---
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
index f64c5551cdba..7e717716b90e 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
@@ -754,7 +754,6 @@ static int kfd_ioctl_get_clock_counters(struct file *filep,
{
struct kfd_ioctl_get_clock_counters_args *args = data;
struct kfd_dev *dev;
- struct timespec64 time;
dev = kfd_device_by_id(args->gpu_id);
if (dev)
@@ -766,11 +765,8 @@ static int kfd_ioctl_get_clock_counters(struct file *filep,
args->gpu_clock_counter = 0;
/* No access to rdtsc. Using raw monotonic time */
- getrawmonotonic64(&time);
- args->cpu_clock_counter = (uint64_t)timespec64_to_ns(&time);
-
- get_monotonic_boottime64(&time);
- args->system_clock_counter = (uint64_t)timespec64_to_ns(&time);
+ args->cpu_clock_counter = ktime_get_raw_ns();
+ args->system_clock_counter = ktime_get_boot_ns();
/* Since the counter is in nano-seconds we use 1GHz frequency */
args->system_clock_freq = 1000000000;
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [RESEND] amdgpu: kfd: use modern ktime accessors
2018-07-11 12:41 [PATCH] [RESEND] amdgpu: kfd: use modern ktime accessors Arnd Bergmann
@ 2018-07-26 13:59 ` Oded Gabbay
0 siblings, 0 replies; 2+ messages in thread
From: Oded Gabbay @ 2018-07-26 13:59 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Alex Deucher, Christian König, David (ChunMing) Zhou,
David Airlie, Kuehling, Felix, Yong Zhao, Kent Russell,
Philip Yang, Harish Kasiviswanathan, Andres Rodriguez,
Maling list - DRI developers, amd-gfx list,
Linux-Kernel@Vger. Kernel. Org
On Wed, Jul 11, 2018 at 3:41 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> getrawmonotonic64() and get_monotonic_boottime64() are deprecated
> because of the nonstandard naming.
>
> The replacement functions ktime_get_raw_ns() and ktime_get_boot_ns()
> also simplify the callers.
>
> Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>.
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Patch was originall sent on Jun 18 but not applied yet, resending
> With Felix' Reviewed-by tag
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> index f64c5551cdba..7e717716b90e 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> @@ -754,7 +754,6 @@ static int kfd_ioctl_get_clock_counters(struct file *filep,
> {
> struct kfd_ioctl_get_clock_counters_args *args = data;
> struct kfd_dev *dev;
> - struct timespec64 time;
>
> dev = kfd_device_by_id(args->gpu_id);
> if (dev)
> @@ -766,11 +765,8 @@ static int kfd_ioctl_get_clock_counters(struct file *filep,
> args->gpu_clock_counter = 0;
>
> /* No access to rdtsc. Using raw monotonic time */
> - getrawmonotonic64(&time);
> - args->cpu_clock_counter = (uint64_t)timespec64_to_ns(&time);
> -
> - get_monotonic_boottime64(&time);
> - args->system_clock_counter = (uint64_t)timespec64_to_ns(&time);
> + args->cpu_clock_counter = ktime_get_raw_ns();
> + args->system_clock_counter = ktime_get_boot_ns();
>
> /* Since the counter is in nano-seconds we use 1GHz frequency */
> args->system_clock_freq = 1000000000;
> --
> 2.9.0
>
Applied to -next
Thanks,
Oded
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-26 13:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-11 12:41 [PATCH] [RESEND] amdgpu: kfd: use modern ktime accessors Arnd Bergmann
2018-07-26 13:59 ` Oded Gabbay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).