From: Oded Gabbay <oded.gabbay@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Yair Shachar <yair.shachar@amd.com>,
David Airlie <airlied@linux.ie>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] drm/amdkfd: uninitialized variable in dbgdev_wave_control_set_registers()
Date: Mon, 14 Mar 2016 15:57:16 +0200 [thread overview]
Message-ID: <CAFCwf11Ea1saj1wfJN5bzU5b_qLnDZAkf5-d2HMNwQXi+diV-A@mail.gmail.com> (raw)
In-Reply-To: <20160311075151.GA7902@mwanda>
On Fri, Mar 11, 2016 at 9:51 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> At the end of the function we expect "status" to be zero, but it's
> either -EINVAL or unitialized.
>
> Fixes: 788bf83db301 ('drm/amdkfd: Add wave control operation to debugger')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
> index c34c393..d5e19b5 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
> @@ -513,7 +513,7 @@ static int dbgdev_wave_control_set_registers(
> union SQ_CMD_BITS *in_reg_sq_cmd,
> union GRBM_GFX_INDEX_BITS *in_reg_gfx_index)
> {
> - int status;
> + int status = 0;
> union SQ_CMD_BITS reg_sq_cmd;
> union GRBM_GFX_INDEX_BITS reg_gfx_index;
> struct HsaDbgWaveMsgAMDGen2 *pMsg;
Thanks,
applied to my fixes tree.
Oded
prev parent reply other threads:[~2016-03-14 13:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 7:51 [patch] drm/amdkfd: uninitialized variable in dbgdev_wave_control_set_registers() Dan Carpenter
2016-03-14 13:57 ` Oded Gabbay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFCwf11Ea1saj1wfJN5bzU5b_qLnDZAkf5-d2HMNwQXi+diV-A@mail.gmail.com \
--to=oded.gabbay@gmail.com \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yair.shachar@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).