From: Oded Gabbay <ogabbay@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Greg KH <gregkh@linuxfoundation.org>,
Jiho Chu <jiho.chu@samsung.com>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
Yelin Jeong <yelini.jeong@samsung.com>,
ALIM AKHTAR <alim.akhtar@samsung.com>
Subject: Re: [PATCH 0/9] Samsung Trinity NPU device driver
Date: Tue, 26 Jul 2022 14:24:03 +0300 [thread overview]
Message-ID: <CAFCwf13uLM3kr20dBZV3u3xLwwMXdt=7p7y9HhR+ocknsz=cLA@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a3xhAcokq1p0_PzK2JzR9BGNcaohA_nan9nS9NioW4_rQ@mail.gmail.com>
On Tue, Jul 26, 2022 at 10:51 AM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Tue, Jul 26, 2022 at 8:59 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> > On 26/07/2022 04:09, MyungJoo Ham wrote:
> > >> Hi,
> > >> Why isn't this submitted to soc/ subsystem ?
> > >> Don't you think that would be more appropriate, given that this IP is
> > >> integrated into application processors ?
> > >>
> > >> Thanks,
> > >> Oded
> > >
> > > This series (Trinity-V2.3, V2.4, A1, ..) is being integrated to multiple SoCs,
> > > not limited to Samsung-designed chips (e.g., Exynos).
> > > It's a bit weird to have them in /drivers/soc/samsung.
> > >
> > > CC: Krzysztof and Alim (Samsung-SoC maintainers)
> >
> > If it is not related to Samsung SoCs (or other designs by Samsung
> > Foundry), then it should not go to drivers/soc. Based on cover letter,
> > it looks this is the case.
>
> Agreed, and I also don't want to add any drivers with a user interface
> to drivers/soc/. The things we have in there mainly fall into two categories:
>
> - soc_device drivers for identifying the SoC itself from userspace or
> another driver
>
> - drivers that provide exported symbols to other kernel drivers for things
> that do not have a proper subsystem abstraction (yet).
>
> This driver clearly does not fall into those categories. As long as there
> is no subsystem for NPUs, the only sensible options are drivers/gpu
> and drivers/misc/.
>
> Arnd
Thanks for the explanation, I wasn't sure what the criteria for
getting into drivers/soc is,
but now it is clear.
Oded
next prev parent reply other threads:[~2022-07-26 11:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220725065308epcas1p2f6de3d74792854bb312cca4b310badac@epcas1p2.samsung.com>
2022-07-25 6:52 ` [PATCH 0/9] Samsung Trinity NPU device driver Jiho Chu
[not found] ` <CGME20220725065309epcas1p4565e7bb0fea1aaf3e5e300de00774c2a@epcas1p4.samsung.com>
2022-07-25 6:53 ` [PATCH 1/9] trinity: Add base driver Jiho Chu
2022-07-27 11:54 ` Krzysztof Kozlowski
2022-07-27 13:22 ` Greg KH
2022-09-01 19:04 ` Dafna Hirschfeld
2022-09-02 5:39 ` Greg KH
[not found] ` <CGME20220725065309epcas1p4565e7bb0fea1aaf3e5e300de00774c2a@epcms1p2>
2022-07-28 2:05 ` MyungJoo Ham
2022-09-01 18:36 ` Mark Brown
2022-09-02 8:23 ` Jiho Chu
[not found] ` <CGME20220725065309epcas1p3c691bbc54c84775524b97c4b717c7ce7@epcas1p3.samsung.com>
2022-07-25 6:53 ` [PATCH 2/9] tirnity: Add dma memory module Jiho Chu
2022-07-27 13:15 ` Greg KH
[not found] ` <CGME20220725065309epcas1p20c847655e7332c818fc0fd2c50fb0e27@epcas1p2.samsung.com>
2022-07-25 6:53 ` [PATCH 3/9] trinity: Add load/unload IDU files Jiho Chu
2022-07-27 13:14 ` Greg KH
2022-09-17 7:39 ` Jiho Chu
[not found] ` <CGME20220725065309epcas1p42ba84c5241d69192ea73904ed6af17d7@epcas1p4.samsung.com>
2022-07-25 6:53 ` [PATCH 4/9] trinity: Add schduler module Jiho Chu
2022-07-27 13:09 ` Greg KH
[not found] ` <CGME20220725065309epcas1p413498a418cbf58570f8009ae7fd91015@epcas1p4.samsung.com>
2022-07-25 6:53 ` [PATCH 5/9] trinity: Add sysfs debugfs module Jiho Chu
2022-07-27 13:25 ` Greg KH
[not found] ` <CGME20220725065310epcas1p3688f336bfd5c732145575524f3365a0f@epcas1p3.samsung.com>
2022-07-25 6:53 ` [PATCH 6/9] trinity: Add pm and ioctl feature Jiho Chu
[not found] ` <CGME20220725065310epcas1p2ae58294d9cf44e622ed8cc7e5a8b988c@epcas1p2.samsung.com>
2022-07-25 6:53 ` [PATCH 7/9] trinity: Add profile module Jiho Chu
[not found] ` <CGME20220725065310epcas1p1841fde6ae768a98543418c81790c0832@epcas1p1.samsung.com>
2022-07-25 6:53 ` [PATCH 8/9] trinity: Add trace module Jiho Chu
[not found] ` <CGME20220725065310epcas1p2735e463512b0db489f2af532f15dae6e@epcas1p2.samsung.com>
2022-07-25 6:53 ` [PATCH 9/9] MAINTAINERS: add TRINITY driver Jiho Chu
2022-07-25 9:02 ` [PATCH 0/9] Samsung Trinity NPU device driver Greg KH
2022-07-25 9:10 ` Oded Gabbay
[not found] ` <CGME20220725065308epcas1p2f6de3d74792854bb312cca4b310badac@epcms1p5>
2022-07-26 2:09 ` MyungJoo Ham
2022-07-26 6:59 ` Krzysztof Kozlowski
2022-07-26 7:51 ` Arnd Bergmann
2022-07-26 11:24 ` Oded Gabbay [this message]
2022-07-29 17:50 ` Pavel Machek
[not found] ` <20220726050305epcms1p5ef19a54322263c768ea71d59da7e2616@epcms1p5>
2022-07-26 14:35 ` 추지호/Robot Intelligence팀(SR)/Staff Engineer/삼성전자
2022-07-26 6:57 ` Krzysztof Kozlowski
2022-07-27 11:51 ` Jiho Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFCwf13uLM3kr20dBZV3u3xLwwMXdt=7p7y9HhR+ocknsz=cLA@mail.gmail.com' \
--to=ogabbay@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jiho.chu@samsung.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=yelini.jeong@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).