From: Greg KH <gregkh@linuxfoundation.org>
To: Jiho Chu <jiho.chu@samsung.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
yelini.jeong@samsung.com, myungjoo.ham@samsung.com
Subject: Re: [PATCH 3/9] trinity: Add load/unload IDU files
Date: Wed, 27 Jul 2022 15:14:10 +0200 [thread overview]
Message-ID: <YuE6IrM/8slDjsdL@kroah.com> (raw)
In-Reply-To: <20220725065308.2457024-4-jiho.chu@samsung.com>
On Mon, Jul 25, 2022 at 03:53:02PM +0900, Jiho Chu wrote:
> +static int triv2_idu_load_file(struct trinity_driver *drv, const char *dirpath,
> + const char *file_name,
> + struct trinity_resv_mem *sector)
> +{
> + struct device *dev = drv_to_dev_ptr(drv);
> + struct trinity_resv_mem mem;
> + char filepath[NAME_MAX];
> + struct kstat *stat;
> + struct file *filp;
> + loff_t pos = 0;
> + size_t size;
> + int ret;
> +
> + dev = drv_to_dev_ptr(drv);
> + stat = vmalloc(sizeof(*stat));
> + if (stat == NULL)
> + return -ENOMEM;
> +
> + /* if dirpath is null, use the default path */
> + if (dirpath)
> + snprintf(filepath, NAME_MAX, "%s/%s", dirpath, file_name);
> + else
> + snprintf(filepath, NAME_MAX, TRIV2_IDU_DIRPATH_FMT "/%s",
> + utsname()->release, file_name);
> +
> + filp = filp_open(filepath, O_RDONLY, 0400);
That is cute. And totally not ok.
Please never do this, that is not how to properly load a firmware blob
in the kernel. This is racy and broken and probably a huge security
hole.
Heck, I wrote an article about this very topic, way back in 2005, with
the title of, "Things you should never do in the kernel" and can be seen
here:
https://www.linuxjournal.com/article/8110
This should not be news to anyone, again, never do this.
thanks,
greg k-h
next prev parent reply other threads:[~2022-07-27 13:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220725065308epcas1p2f6de3d74792854bb312cca4b310badac@epcas1p2.samsung.com>
2022-07-25 6:52 ` [PATCH 0/9] Samsung Trinity NPU device driver Jiho Chu
[not found] ` <CGME20220725065309epcas1p4565e7bb0fea1aaf3e5e300de00774c2a@epcas1p4.samsung.com>
2022-07-25 6:53 ` [PATCH 1/9] trinity: Add base driver Jiho Chu
2022-07-27 11:54 ` Krzysztof Kozlowski
2022-07-27 13:22 ` Greg KH
2022-09-01 19:04 ` Dafna Hirschfeld
2022-09-02 5:39 ` Greg KH
[not found] ` <CGME20220725065309epcas1p4565e7bb0fea1aaf3e5e300de00774c2a@epcms1p2>
2022-07-28 2:05 ` MyungJoo Ham
2022-09-01 18:36 ` Mark Brown
2022-09-02 8:23 ` Jiho Chu
[not found] ` <CGME20220725065309epcas1p3c691bbc54c84775524b97c4b717c7ce7@epcas1p3.samsung.com>
2022-07-25 6:53 ` [PATCH 2/9] tirnity: Add dma memory module Jiho Chu
2022-07-27 13:15 ` Greg KH
[not found] ` <CGME20220725065309epcas1p20c847655e7332c818fc0fd2c50fb0e27@epcas1p2.samsung.com>
2022-07-25 6:53 ` [PATCH 3/9] trinity: Add load/unload IDU files Jiho Chu
2022-07-27 13:14 ` Greg KH [this message]
2022-09-17 7:39 ` Jiho Chu
[not found] ` <CGME20220725065309epcas1p42ba84c5241d69192ea73904ed6af17d7@epcas1p4.samsung.com>
2022-07-25 6:53 ` [PATCH 4/9] trinity: Add schduler module Jiho Chu
2022-07-27 13:09 ` Greg KH
[not found] ` <CGME20220725065309epcas1p413498a418cbf58570f8009ae7fd91015@epcas1p4.samsung.com>
2022-07-25 6:53 ` [PATCH 5/9] trinity: Add sysfs debugfs module Jiho Chu
2022-07-27 13:25 ` Greg KH
[not found] ` <CGME20220725065310epcas1p3688f336bfd5c732145575524f3365a0f@epcas1p3.samsung.com>
2022-07-25 6:53 ` [PATCH 6/9] trinity: Add pm and ioctl feature Jiho Chu
[not found] ` <CGME20220725065310epcas1p2ae58294d9cf44e622ed8cc7e5a8b988c@epcas1p2.samsung.com>
2022-07-25 6:53 ` [PATCH 7/9] trinity: Add profile module Jiho Chu
[not found] ` <CGME20220725065310epcas1p1841fde6ae768a98543418c81790c0832@epcas1p1.samsung.com>
2022-07-25 6:53 ` [PATCH 8/9] trinity: Add trace module Jiho Chu
[not found] ` <CGME20220725065310epcas1p2735e463512b0db489f2af532f15dae6e@epcas1p2.samsung.com>
2022-07-25 6:53 ` [PATCH 9/9] MAINTAINERS: add TRINITY driver Jiho Chu
2022-07-25 9:02 ` [PATCH 0/9] Samsung Trinity NPU device driver Greg KH
2022-07-25 9:10 ` Oded Gabbay
[not found] ` <CGME20220725065308epcas1p2f6de3d74792854bb312cca4b310badac@epcms1p5>
2022-07-26 2:09 ` MyungJoo Ham
2022-07-26 6:59 ` Krzysztof Kozlowski
2022-07-26 7:51 ` Arnd Bergmann
2022-07-26 11:24 ` Oded Gabbay
2022-07-29 17:50 ` Pavel Machek
[not found] ` <20220726050305epcms1p5ef19a54322263c768ea71d59da7e2616@epcms1p5>
2022-07-26 14:35 ` 추지호/Robot Intelligence팀(SR)/Staff Engineer/삼성전자
2022-07-26 6:57 ` Krzysztof Kozlowski
2022-07-27 11:51 ` Jiho Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuE6IrM/8slDjsdL@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=jiho.chu@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=yelini.jeong@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).