* [PATCH] arm64: dts: hikey: extend default cma size to 128MB
@ 2016-08-24 13:35 Guodong Xu
2016-08-24 15:10 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Guodong Xu @ 2016-08-24 13:35 UTC (permalink / raw)
To: xuwei5, robh+dt, rob.herring, fathi.boudra, john.stultz,
xinliang.liu, mark.rutland, catalin.marinas, will.deacon
Cc: devicetree, linux-arm-kernel, linux-kernel, treding, Guodong Xu
To support display in Debian on HiKey, cma heap is used to allocate
graphic buffers. The default size of CMA is 16 MB which is not enought.
Increase the default CMA size to 128 MB.
cc: Rob Herring <rob.herring@linaro.org>
cc: Fathi Boudra <fathi.boudra@linaro.org>
cc: John Stultz <john.stultz@linaro.org>
cc: Xinliang Liu <xinliang.liu@linaro.org>
Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
---
arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
index 4a51058..abb3434 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
@@ -45,6 +45,20 @@
<0x00000000 0x22000000 0x00000000 0x1c000000>;
};
+ reserved-memory {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ /* global autoconfigured region for contiguous allocations */
+ linux,cma {
+ compatible = "shared-dma-pool";
+ reusable;
+ size = <0x00000000 0x08000000>;
+ linux,cma-default;
+ };
+ };
+
pstore: pstore@0x21f00000 {
no-map;
reg = <0x0 0x21f00000 0x0 0x00100000>; /* pstore/ramoops buffer */
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: hikey: extend default cma size to 128MB
2016-08-24 13:35 [PATCH] arm64: dts: hikey: extend default cma size to 128MB Guodong Xu
@ 2016-08-24 15:10 ` Rob Herring
2016-08-25 2:02 ` Guodong Xu
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2016-08-24 15:10 UTC (permalink / raw)
To: Guodong Xu
Cc: Wei Xu, Rob Herring, fathi.boudra, John Stultz, Xinliang Liu,
Mark Rutland, Catalin Marinas, Will Deacon, devicetree,
linux-arm-kernel, linux-kernel, Thierry Reding
On Wed, Aug 24, 2016 at 8:35 AM, Guodong Xu <guodong.xu@linaro.org> wrote:
> To support display in Debian on HiKey, cma heap is used to allocate
> graphic buffers. The default size of CMA is 16 MB which is not enought.
s/enought/enough/
>
> Increase the default CMA size to 128 MB.
>
> cc: Rob Herring <rob.herring@linaro.org>
> cc: Fathi Boudra <fathi.boudra@linaro.org>
> cc: John Stultz <john.stultz@linaro.org>
> cc: Xinliang Liu <xinliang.liu@linaro.org>
> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
> ---
> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> index 4a51058..abb3434 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> @@ -45,6 +45,20 @@
> <0x00000000 0x22000000 0x00000000 0x1c000000>;
> };
>
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + /* global autoconfigured region for contiguous allocations */
> + linux,cma {
> + compatible = "shared-dma-pool";
> + reusable;
> + size = <0x00000000 0x08000000>;
> + linux,cma-default;
> + };
> + };
> +
> pstore: pstore@0x21f00000 {
So what is upstream (as of 4.8) for ramoops also uses reserved-memory,
so you should separately fix this.
Acked-by: Rob Herring <robh@kernel.org>
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: hikey: extend default cma size to 128MB
2016-08-24 15:10 ` Rob Herring
@ 2016-08-25 2:02 ` Guodong Xu
0 siblings, 0 replies; 3+ messages in thread
From: Guodong Xu @ 2016-08-25 2:02 UTC (permalink / raw)
To: Rob Herring
Cc: Wei Xu, Rob Herring, Fathi Boudra, John Stultz, Xinliang Liu,
Mark Rutland, Catalin Marinas, Will Deacon, devicetree,
linux-arm-kernel, linux-kernel, Thierry Reding
On 24 August 2016 at 23:10, Rob Herring <robh+dt@kernel.org> wrote:
> On Wed, Aug 24, 2016 at 8:35 AM, Guodong Xu <guodong.xu@linaro.org> wrote:
>> To support display in Debian on HiKey, cma heap is used to allocate
>> graphic buffers. The default size of CMA is 16 MB which is not enought.
>
> s/enought/enough/
>
>>
>> Increase the default CMA size to 128 MB.
>>
>> cc: Rob Herring <rob.herring@linaro.org>
>> cc: Fathi Boudra <fathi.boudra@linaro.org>
>> cc: John Stultz <john.stultz@linaro.org>
>> cc: Xinliang Liu <xinliang.liu@linaro.org>
>> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
>> ---
>> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> index 4a51058..abb3434 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> @@ -45,6 +45,20 @@
>> <0x00000000 0x22000000 0x00000000 0x1c000000>;
>> };
>>
>> + reserved-memory {
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> + ranges;
>> +
>> + /* global autoconfigured region for contiguous allocations */
>> + linux,cma {
>> + compatible = "shared-dma-pool";
>> + reusable;
>> + size = <0x00000000 0x08000000>;
>> + linux,cma-default;
>> + };
>> + };
>> +
>> pstore: pstore@0x21f00000 {
>
> So what is upstream (as of 4.8) for ramoops also uses reserved-memory,
> so you should separately fix this.
>
Got it. I will fix and resend.
> Acked-by: Rob Herring <robh@kernel.org>
>
Thanks.
-Guodong
> Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-25 5:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-24 13:35 [PATCH] arm64: dts: hikey: extend default cma size to 128MB Guodong Xu
2016-08-24 15:10 ` Rob Herring
2016-08-25 2:02 ` Guodong Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).