* [PATCH] ACPI: CPPC: Support PCC with interrupt flag
@ 2016-07-21 21:07 Hoan Tran
2016-08-30 18:20 ` Hoan Tran
0 siblings, 1 reply; 6+ messages in thread
From: Hoan Tran @ 2016-07-21 21:07 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, pprakash, Ashwin Chaugule
Cc: linux-acpi, linux-kernel, lho, Duc Dang, Hoan Tran
For PCC mailbox with interrupt flag, CPPC should call mbox_chan_txdone()
function to notify the mailbox framework about TX completion.
Signed-off-by: Hoan Tran <hotran@apm.com>
---
This patch is tested on top and depends on patch[1]:
[1] http://www.spinics.net/lists/linux-acpi/msg66041.html
- [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2
drivers/acpi/cppc_acpi.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
index 2e98173..19606aa 100644
--- a/drivers/acpi/cppc_acpi.c
+++ b/drivers/acpi/cppc_acpi.c
@@ -191,7 +191,11 @@ static int send_pcc_cmd(u16 cmd)
last_cmd_cmpl_time = ktime_get();
}
- mbox_client_txdone(pcc_channel, ret);
+ if (pcc_channel->mbox->txdone_irq)
+ mbox_chan_txdone(pcc_channel, ret);
+ else
+ mbox_client_txdone(pcc_channel, ret);
+
return ret;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI: CPPC: Support PCC with interrupt flag
2016-07-21 21:07 [PATCH] ACPI: CPPC: Support PCC with interrupt flag Hoan Tran
@ 2016-08-30 18:20 ` Hoan Tran
2016-09-14 15:45 ` Hoan Tran
2016-09-14 15:45 ` Prakash, Prashanth
0 siblings, 2 replies; 6+ messages in thread
From: Hoan Tran @ 2016-08-30 18:20 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Prashanth Prakash, Ashwin Chaugule
Cc: linux acpi, lkml, Loc Ho, Duc Dang, Hoan Tran, ashwinch
On Thu, Jul 21, 2016 at 2:07 PM, Hoan Tran <hotran@apm.com> wrote:
> For PCC mailbox with interrupt flag, CPPC should call mbox_chan_txdone()
> function to notify the mailbox framework about TX completion.
>
> Signed-off-by: Hoan Tran <hotran@apm.com>
> ---
> This patch is tested on top and depends on patch[1]:
> [1] http://www.spinics.net/lists/linux-acpi/msg66041.html
> - [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2
>
> drivers/acpi/cppc_acpi.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> index 2e98173..19606aa 100644
> --- a/drivers/acpi/cppc_acpi.c
> +++ b/drivers/acpi/cppc_acpi.c
> @@ -191,7 +191,11 @@ static int send_pcc_cmd(u16 cmd)
> last_cmd_cmpl_time = ktime_get();
> }
>
> - mbox_client_txdone(pcc_channel, ret);
> + if (pcc_channel->mbox->txdone_irq)
> + mbox_chan_txdone(pcc_channel, ret);
> + else
> + mbox_client_txdone(pcc_channel, ret);
> +
> return ret;
> }
>
> --
> 1.9.1
>
Any feedbacks.
Thanks
Hoan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI: CPPC: Support PCC with interrupt flag
2016-08-30 18:20 ` Hoan Tran
@ 2016-09-14 15:45 ` Hoan Tran
2016-09-14 16:49 ` Rafael J. Wysocki
2016-09-14 15:45 ` Prakash, Prashanth
1 sibling, 1 reply; 6+ messages in thread
From: Hoan Tran @ 2016-09-14 15:45 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Prashanth Prakash, Ashwin Chaugule
Cc: linux acpi, lkml, Loc Ho, Duc Dang, Hoan Tran, Ashwin Chaugule
On Tue, Aug 30, 2016 at 11:20 AM, Hoan Tran <hotran@apm.com> wrote:
> On Thu, Jul 21, 2016 at 2:07 PM, Hoan Tran <hotran@apm.com> wrote:
>> For PCC mailbox with interrupt flag, CPPC should call mbox_chan_txdone()
>> function to notify the mailbox framework about TX completion.
>>
>> Signed-off-by: Hoan Tran <hotran@apm.com>
>> ---
>> This patch is tested on top and depends on patch[1]:
>> [1] http://www.spinics.net/lists/linux-acpi/msg66041.html
>> - [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2
>>
>> drivers/acpi/cppc_acpi.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
>> index 2e98173..19606aa 100644
>> --- a/drivers/acpi/cppc_acpi.c
>> +++ b/drivers/acpi/cppc_acpi.c
>> @@ -191,7 +191,11 @@ static int send_pcc_cmd(u16 cmd)
>> last_cmd_cmpl_time = ktime_get();
>> }
>>
>> - mbox_client_txdone(pcc_channel, ret);
>> + if (pcc_channel->mbox->txdone_irq)
>> + mbox_chan_txdone(pcc_channel, ret);
>> + else
>> + mbox_client_txdone(pcc_channel, ret);
>> +
>> return ret;
>> }
>>
>> --
>> 1.9.1
>>
>
> Any feedbacks.
>
> Thanks
> Hoan
Hi Rafael,
Do you have any comments on this patch ?
Thanks
Hoan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI: CPPC: Support PCC with interrupt flag
2016-08-30 18:20 ` Hoan Tran
2016-09-14 15:45 ` Hoan Tran
@ 2016-09-14 15:45 ` Prakash, Prashanth
1 sibling, 0 replies; 6+ messages in thread
From: Prakash, Prashanth @ 2016-09-14 15:45 UTC (permalink / raw)
To: Hoan Tran, Rafael J. Wysocki, Len Brown, Ashwin Chaugule
Cc: linux acpi, lkml, Loc Ho, Duc Dang, ashwinch
Hi Hoan,
On 8/30/2016 12:20 PM, Hoan Tran wrote:
> On Thu, Jul 21, 2016 at 2:07 PM, Hoan Tran <hotran@apm.com> wrote:
>> For PCC mailbox with interrupt flag, CPPC should call mbox_chan_txdone()
>> function to notify the mailbox framework about TX completion.
>>
>> Signed-off-by: Hoan Tran <hotran@apm.com>
>> ---
>> This patch is tested on top and depends on patch[1]:
>> [1] http://www.spinics.net/lists/linux-acpi/msg66041.html
>> - [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2
>>
>> drivers/acpi/cppc_acpi.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
>> index 2e98173..19606aa 100644
>> --- a/drivers/acpi/cppc_acpi.c
>> +++ b/drivers/acpi/cppc_acpi.c
>> @@ -191,7 +191,11 @@ static int send_pcc_cmd(u16 cmd)
>> last_cmd_cmpl_time = ktime_get();
>> }
>>
>> - mbox_client_txdone(pcc_channel, ret);
>> + if (pcc_channel->mbox->txdone_irq)
>> + mbox_chan_txdone(pcc_channel, ret);
>> + else
>> + mbox_client_txdone(pcc_channel, ret);
>> +
Firstly, sorry for the delay.
I was wondering if we should call txdone in PCC interrupt routine as done in
some of the mailbox drivers. But then, since we need to support both polling
and interrupt, I suppose this makes sense.
Reviewed-by: Prashanth Prakash <pprakash@codeaurora.org>
Thanks,
Prashanth
>> return ret;
>> }
>>
>> --
>> 1.9.1
>>
> Any feedbacks.
>
> Thanks
> Hoan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI: CPPC: Support PCC with interrupt flag
2016-09-14 15:45 ` Hoan Tran
@ 2016-09-14 16:49 ` Rafael J. Wysocki
2016-09-14 17:55 ` Hoan Tran
0 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2016-09-14 16:49 UTC (permalink / raw)
To: Hoan Tran
Cc: Len Brown, Prashanth Prakash, Ashwin Chaugule, linux acpi, lkml,
Loc Ho, Duc Dang, Ashwin Chaugule
On Wednesday, September 14, 2016 08:45:14 AM Hoan Tran wrote:
> On Tue, Aug 30, 2016 at 11:20 AM, Hoan Tran <hotran@apm.com> wrote:
> > On Thu, Jul 21, 2016 at 2:07 PM, Hoan Tran <hotran@apm.com> wrote:
> >> For PCC mailbox with interrupt flag, CPPC should call mbox_chan_txdone()
> >> function to notify the mailbox framework about TX completion.
> >>
> >> Signed-off-by: Hoan Tran <hotran@apm.com>
> >> ---
> >> This patch is tested on top and depends on patch[1]:
> >> [1] http://www.spinics.net/lists/linux-acpi/msg66041.html
> >> - [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2
> >>
> >> drivers/acpi/cppc_acpi.c | 6 +++++-
> >> 1 file changed, 5 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> >> index 2e98173..19606aa 100644
> >> --- a/drivers/acpi/cppc_acpi.c
> >> +++ b/drivers/acpi/cppc_acpi.c
> >> @@ -191,7 +191,11 @@ static int send_pcc_cmd(u16 cmd)
> >> last_cmd_cmpl_time = ktime_get();
> >> }
> >>
> >> - mbox_client_txdone(pcc_channel, ret);
> >> + if (pcc_channel->mbox->txdone_irq)
> >> + mbox_chan_txdone(pcc_channel, ret);
> >> + else
> >> + mbox_client_txdone(pcc_channel, ret);
> >> +
> >> return ret;
> >> }
> >>
> >> --
> >> 1.9.1
> >>
> >
> > Any feedbacks.
> >
> > Thanks
> > Hoan
>
> Hi Rafael,
>
> Do you have any comments on this patch ?
No, but can you please resend it (with the Reviewed-by tag from Prashanth,
preferably)? And please make sure it applies on my linux-next branch.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI: CPPC: Support PCC with interrupt flag
2016-09-14 16:49 ` Rafael J. Wysocki
@ 2016-09-14 17:55 ` Hoan Tran
0 siblings, 0 replies; 6+ messages in thread
From: Hoan Tran @ 2016-09-14 17:55 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Len Brown, Prashanth Prakash, Ashwin Chaugule, linux acpi, lkml,
Loc Ho, Duc Dang, Ashwin Chaugule
On Wed, Sep 14, 2016 at 9:49 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> On Wednesday, September 14, 2016 08:45:14 AM Hoan Tran wrote:
>> On Tue, Aug 30, 2016 at 11:20 AM, Hoan Tran <hotran@apm.com> wrote:
>> > On Thu, Jul 21, 2016 at 2:07 PM, Hoan Tran <hotran@apm.com> wrote:
>> >> For PCC mailbox with interrupt flag, CPPC should call mbox_chan_txdone()
>> >> function to notify the mailbox framework about TX completion.
>> >>
>> >> Signed-off-by: Hoan Tran <hotran@apm.com>
>> >> ---
>> >> This patch is tested on top and depends on patch[1]:
>> >> [1] http://www.spinics.net/lists/linux-acpi/msg66041.html
>> >> - [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2
>> >>
>> >> drivers/acpi/cppc_acpi.c | 6 +++++-
>> >> 1 file changed, 5 insertions(+), 1 deletion(-)
>> >>
>> >> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
>> >> index 2e98173..19606aa 100644
>> >> --- a/drivers/acpi/cppc_acpi.c
>> >> +++ b/drivers/acpi/cppc_acpi.c
>> >> @@ -191,7 +191,11 @@ static int send_pcc_cmd(u16 cmd)
>> >> last_cmd_cmpl_time = ktime_get();
>> >> }
>> >>
>> >> - mbox_client_txdone(pcc_channel, ret);
>> >> + if (pcc_channel->mbox->txdone_irq)
>> >> + mbox_chan_txdone(pcc_channel, ret);
>> >> + else
>> >> + mbox_client_txdone(pcc_channel, ret);
>> >> +
>> >> return ret;
>> >> }
>> >>
>> >> --
>> >> 1.9.1
>> >>
>> >
>> > Any feedbacks.
>> >
>> > Thanks
>> > Hoan
>>
>> Hi Rafael,
>>
>> Do you have any comments on this patch ?
>
> No, but can you please resend it (with the Reviewed-by tag from Prashanth,
> preferably)? And please make sure it applies on my linux-next branch.
Hi Rafael,
I just resent the patch with Reviewed-by tag
Thanks
Hoan
>
> Thanks,
> Rafael
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-14 17:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-21 21:07 [PATCH] ACPI: CPPC: Support PCC with interrupt flag Hoan Tran
2016-08-30 18:20 ` Hoan Tran
2016-09-14 15:45 ` Hoan Tran
2016-09-14 16:49 ` Rafael J. Wysocki
2016-09-14 17:55 ` Hoan Tran
2016-09-14 15:45 ` Prakash, Prashanth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).