* [PATCH] mtd: spi-nor: Compile files in controllers/ directory
@ 2020-04-04 15:36 Guenter Roeck
2020-04-04 15:40 ` Boris Brezillon
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Guenter Roeck @ 2020-04-04 15:36 UTC (permalink / raw)
To: Tudor Ambarus
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
linux-mtd, linux-kernel, Guenter Roeck, Boris Brezillon
Commit a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code
split") moved various files into a new directory, but did not add the new
directory to its parent directory Makefile. The moved files no longer
build, and affected flash chips no longer instantiate.
Adding the new directory to the parent directory Makefile fixes the
problem.
Fixes: a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code split")
Cc: Boris Brezillon <bbrezillon@kernel.org>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/mtd/spi-nor/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/spi-nor/Makefile b/drivers/mtd/spi-nor/Makefile
index 7ddb742de1fe..653923896205 100644
--- a/drivers/mtd/spi-nor/Makefile
+++ b/drivers/mtd/spi-nor/Makefile
@@ -18,3 +18,5 @@ spi-nor-objs += winbond.o
spi-nor-objs += xilinx.o
spi-nor-objs += xmc.o
obj-$(CONFIG_MTD_SPI_NOR) += spi-nor.o
+
+obj-$(CONFIG_MTD_SPI_NOR) += controllers/
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] mtd: spi-nor: Compile files in controllers/ directory
2020-04-04 15:36 [PATCH] mtd: spi-nor: Compile files in controllers/ directory Guenter Roeck
@ 2020-04-04 15:40 ` Boris Brezillon
2020-04-06 1:20 ` Joel Stanley
2020-04-06 5:31 ` Tudor.Ambarus
2 siblings, 0 replies; 5+ messages in thread
From: Boris Brezillon @ 2020-04-04 15:40 UTC (permalink / raw)
To: Guenter Roeck
Cc: Tudor Ambarus, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-mtd, linux-kernel, Boris Brezillon
On Sat, 4 Apr 2020 08:36:31 -0700
Guenter Roeck <linux@roeck-us.net> wrote:
> Commit a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code
> split") moved various files into a new directory, but did not add the new
> directory to its parent directory Makefile. The moved files no longer
> build, and affected flash chips no longer instantiate.
>
> Adding the new directory to the parent directory Makefile fixes the
> problem.
>
> Fixes: a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code split")
> Cc: Boris Brezillon <bbrezillon@kernel.org>
> Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Thanks for the fix, and my apologies for the regression.
> ---
> drivers/mtd/spi-nor/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/Makefile b/drivers/mtd/spi-nor/Makefile
> index 7ddb742de1fe..653923896205 100644
> --- a/drivers/mtd/spi-nor/Makefile
> +++ b/drivers/mtd/spi-nor/Makefile
> @@ -18,3 +18,5 @@ spi-nor-objs += winbond.o
> spi-nor-objs += xilinx.o
> spi-nor-objs += xmc.o
> obj-$(CONFIG_MTD_SPI_NOR) += spi-nor.o
> +
> +obj-$(CONFIG_MTD_SPI_NOR) += controllers/
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mtd: spi-nor: Compile files in controllers/ directory
2020-04-04 15:36 [PATCH] mtd: spi-nor: Compile files in controllers/ directory Guenter Roeck
2020-04-04 15:40 ` Boris Brezillon
@ 2020-04-06 1:20 ` Joel Stanley
2020-04-06 5:31 ` Tudor.Ambarus
2 siblings, 0 replies; 5+ messages in thread
From: Joel Stanley @ 2020-04-06 1:20 UTC (permalink / raw)
To: Guenter Roeck, Tudor Ambarus
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
linux-mtd, Linux Kernel Mailing List, Boris Brezillon,
linux-aspeed, Cédric Le Goater, Andrew Jeffery
On Sat, 4 Apr 2020 at 15:37, Guenter Roeck <linux@roeck-us.net> wrote:
>
> Commit a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code
> split") moved various files into a new directory, but did not add the new
> directory to its parent directory Makefile. The moved files no longer
> build, and affected flash chips no longer instantiate.
>
> Adding the new directory to the parent directory Makefile fixes the
> problem.
>
> Fixes: a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code split")
> Cc: Boris Brezillon <bbrezillon@kernel.org>
> Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Thanks Guenter. I just discovered this too.
Acked-by: Joel Stanley <joel@jms.id.au>
> ---
> drivers/mtd/spi-nor/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/Makefile b/drivers/mtd/spi-nor/Makefile
> index 7ddb742de1fe..653923896205 100644
> --- a/drivers/mtd/spi-nor/Makefile
> +++ b/drivers/mtd/spi-nor/Makefile
> @@ -18,3 +18,5 @@ spi-nor-objs += winbond.o
> spi-nor-objs += xilinx.o
> spi-nor-objs += xmc.o
> obj-$(CONFIG_MTD_SPI_NOR) += spi-nor.o
> +
> +obj-$(CONFIG_MTD_SPI_NOR) += controllers/
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mtd: spi-nor: Compile files in controllers/ directory
2020-04-04 15:36 [PATCH] mtd: spi-nor: Compile files in controllers/ directory Guenter Roeck
2020-04-04 15:40 ` Boris Brezillon
2020-04-06 1:20 ` Joel Stanley
@ 2020-04-06 5:31 ` Tudor.Ambarus
2020-04-09 20:01 ` Richard Weinberger
2 siblings, 1 reply; 5+ messages in thread
From: Tudor.Ambarus @ 2020-04-06 5:31 UTC (permalink / raw)
To: linux-mtd, linux
Cc: vigneshr, bbrezillon, richard, linux-kernel, miquel.raynal
On Saturday, April 4, 2020 6:36:31 PM EEST Guenter Roeck wrote:
> Commit a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code
> split") moved various files into a new directory, but did not add the new
> directory to its parent directory Makefile. The moved files no longer
> build, and affected flash chips no longer instantiate.
>
> Adding the new directory to the parent directory Makefile fixes the
> problem.
>
> Fixes: a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code split")
> Cc: Boris Brezillon <bbrezillon@kernel.org>
> Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/mtd/spi-nor/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
I missed that somehow, sorry. Thank you for the fix, Guenter!
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mtd: spi-nor: Compile files in controllers/ directory
2020-04-06 5:31 ` Tudor.Ambarus
@ 2020-04-09 20:01 ` Richard Weinberger
0 siblings, 0 replies; 5+ messages in thread
From: Richard Weinberger @ 2020-04-09 20:01 UTC (permalink / raw)
To: Tudor Ambarus
Cc: linux-mtd, Guenter Roeck, Richard Weinberger, Miquel Raynal,
Vignesh Raghavendra, LKML, Boris Brezillon
On Mon, Apr 6, 2020 at 7:31 AM <Tudor.Ambarus@microchip.com> wrote:
>
> On Saturday, April 4, 2020 6:36:31 PM EEST Guenter Roeck wrote:
> > Commit a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code
> > split") moved various files into a new directory, but did not add the new
> > directory to its parent directory Makefile. The moved files no longer
> > build, and affected flash chips no longer instantiate.
> >
> > Adding the new directory to the parent directory Makefile fixes the
> > problem.
> >
> > Fixes: a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code split")
> > Cc: Boris Brezillon <bbrezillon@kernel.org>
> > Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> > drivers/mtd/spi-nor/Makefile | 2 ++
> > 1 file changed, 2 insertions(+)
>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>
> I missed that somehow, sorry. Thank you for the fix, Guenter!
Applied to mtd/fixes, thanks to everyone for addressing this.
--
Thanks,
//richard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-09 20:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-04 15:36 [PATCH] mtd: spi-nor: Compile files in controllers/ directory Guenter Roeck
2020-04-04 15:40 ` Boris Brezillon
2020-04-06 1:20 ` Joel Stanley
2020-04-06 5:31 ` Tudor.Ambarus
2020-04-09 20:01 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).