linux-next: Fixes tag needs some work in the ubifs tree

linux-next: Fixes tag needs some work in the ubifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

Hi all,

In commit

  f5de5b83303e ("ubifs: Fix deadlock in concurrent bulk-read and writepage")

Fixes tag

  Fixes: 4793e7c5e1c ("UBIFS: add bulk-read facility")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the ubifs tree

[Richard Weinberger]

On Fri, Jan 17, 2020 at 8:09 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   f5de5b83303e ("ubifs: Fix deadlock in concurrent bulk-read and writepage")
>
> Fixes tag
>
>   Fixes: 4793e7c5e1c ("UBIFS: add bulk-read facility")
>
> has these problem(s):
>
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Fixed. Thanks for reporting!

-- 
Thanks,
//richard

Re: linux-next: Fixes tag needs some work in the ubifs tree

[Richard Weinberger]

----- Ursprüngliche Mail -----
> Von: "Stephen Rothwell" <sfr@canb.auug.org.au>
> An: "Artem Bityutskiy" <dedekind1@gmail.com>
> CC: "Linux Next Mailing List" <linux-next@vger.kernel.org>, "linux-kernel" <linux-kernel@vger.kernel.org>, "Quanyang
> Wang" <quanyang.wang@windriver.com>, "richard" <richard@nod.at>
> Gesendet: Sonntag, 19. Januar 2020 23:12:39
> Betreff: linux-next: Fixes tag needs some work in the ubifs tree

> Hi all,
> 
> In commit
> 
>  31f36312d2ca ("ubifs: fix memory leak from c->sup_node")
> 
> Fixes tag
> 
>  Fixes: 4793e7c5e1c8 ("ubifs: Store read superblock node")
> 
> has these problem(s):
> 
>  - Subject does not match target commit subject
>    Just use
>	git log -1 --format='Fixes: %h ("%s")'
> 
> Did you meean
> 
> Fixes: 4793e7c5e1c8 ("UBIFS: add bulk-read facility")
> 
> or
> 
> Fixes: fd6150051bec ("ubifs: Store read superblock node")

That should be fd6150051bec ("ubifs: Store read superblock node").

/me fixes. No idea how that happened.

Thanks,
//richard

linux-next: Fixes tag needs some work in the ubifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

Hi all,

In commit

  31f36312d2ca ("ubifs: fix memory leak from c->sup_node")

Fixes tag

  Fixes: 4793e7c5e1c8 ("ubifs: Store read superblock node")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Did you meean

Fixes: 4793e7c5e1c8 ("UBIFS: add bulk-read facility")

or

Fixes: fd6150051bec ("ubifs: Store read superblock node")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]