* [PATCH -next] mtd: ubi: wl: remove set but not used variable 'prev_e'
@ 2019-11-27 6:20 YueHaibing
2020-01-16 23:36 ` Richard Weinberger
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-11-27 6:20 UTC (permalink / raw)
To: Richard Weinberger, Miquel Raynal, Sascha Hauer, Vignesh Raghavendra
Cc: YueHaibing, linux-mtd, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/mtd/ubi/wl.c: In function 'find_wl_entry':
drivers/mtd/ubi/wl.c:322:27: warning:
variable 'prev_e' set but not used [-Wunused-but-set-variable]
It's not used any more now, so remove it.
Fixes: f9c34bb52997 ("ubi: Fix producing anchor PEBs")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/mtd/ubi/wl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c
index 5d77a38dba54..837d690a8c60 100644
--- a/drivers/mtd/ubi/wl.c
+++ b/drivers/mtd/ubi/wl.c
@@ -319,7 +319,7 @@ static struct ubi_wl_entry *find_wl_entry(struct ubi_device *ubi,
struct rb_root *root, int diff)
{
struct rb_node *p;
- struct ubi_wl_entry *e, *prev_e = NULL;
+ struct ubi_wl_entry *e;
int max;
e = rb_entry(rb_first(root), struct ubi_wl_entry, u.rb);
@@ -334,7 +334,6 @@ static struct ubi_wl_entry *find_wl_entry(struct ubi_device *ubi,
p = p->rb_left;
else {
p = p->rb_right;
- prev_e = e;
e = e1;
}
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] mtd: ubi: wl: remove set but not used variable 'prev_e'
2019-11-27 6:20 [PATCH -next] mtd: ubi: wl: remove set but not used variable 'prev_e' YueHaibing
@ 2020-01-16 23:36 ` Richard Weinberger
0 siblings, 0 replies; 2+ messages in thread
From: Richard Weinberger @ 2020-01-16 23:36 UTC (permalink / raw)
To: YueHaibing
Cc: Richard Weinberger, Miquel Raynal, Sascha Hauer,
Vignesh Raghavendra, linux-mtd, kernel-janitors, LKML
On Wed, Nov 27, 2019 at 7:22 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/mtd/ubi/wl.c: In function 'find_wl_entry':
> drivers/mtd/ubi/wl.c:322:27: warning:
> variable 'prev_e' set but not used [-Wunused-but-set-variable]
>
> It's not used any more now, so remove it.
>
> Fixes: f9c34bb52997 ("ubi: Fix producing anchor PEBs")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/mtd/ubi/wl.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied. Thanks!
--
Thanks,
//richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-16 23:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-27 6:20 [PATCH -next] mtd: ubi: wl: remove set but not used variable 'prev_e' YueHaibing
2020-01-16 23:36 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).