* [PATCH] mtd: abi: do not use C++ style comments in uapi header
@ 2019-06-27 7:07 Masahiro Yamada
2019-06-27 7:39 ` Richard Weinberger
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2019-06-27 7:07 UTC (permalink / raw)
To: David Woodhouse, Brian Norris, Marek Vasut, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, linux-mtd
Cc: Masahiro Yamada, linux-kernel
Linux kernel tolerates C++ style comments these days. Actually, the
SPDX License tags for .c files start with //.
On the other hand, uapi headers are written in more strict C, where
the C++ comment style is forbidden.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
include/uapi/mtd/mtd-abi.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/uapi/mtd/mtd-abi.h b/include/uapi/mtd/mtd-abi.h
index aff5b5e59845..47ffe3208c27 100644
--- a/include/uapi/mtd/mtd-abi.h
+++ b/include/uapi/mtd/mtd-abi.h
@@ -113,11 +113,11 @@ struct mtd_write_req {
#define MTD_CAP_NVRAM (MTD_WRITEABLE | MTD_BIT_WRITEABLE | MTD_NO_ERASE)
/* Obsolete ECC byte placement modes (used with obsolete MEMGETOOBSEL) */
-#define MTD_NANDECC_OFF 0 // Switch off ECC (Not recommended)
-#define MTD_NANDECC_PLACE 1 // Use the given placement in the structure (YAFFS1 legacy mode)
-#define MTD_NANDECC_AUTOPLACE 2 // Use the default placement scheme
-#define MTD_NANDECC_PLACEONLY 3 // Use the given placement in the structure (Do not store ecc result on read)
-#define MTD_NANDECC_AUTOPL_USR 4 // Use the given autoplacement scheme rather than using the default
+#define MTD_NANDECC_OFF 0 /* Switch off ECC (Not recommended) */
+#define MTD_NANDECC_PLACE 1 /* Use the given placement in the structure (YAFFS1 legacy mode) */
+#define MTD_NANDECC_AUTOPLACE 2 /* Use the default placement scheme */
+#define MTD_NANDECC_PLACEONLY 3 /* Use the given placement in the structure (Do not store ecc result on read) */
+#define MTD_NANDECC_AUTOPL_USR 4 /* Use the given autoplacement scheme rather than using the default */
/* OTP mode selection */
#define MTD_OTP_OFF 0
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: abi: do not use C++ style comments in uapi header
2019-06-27 7:07 [PATCH] mtd: abi: do not use C++ style comments in uapi header Masahiro Yamada
@ 2019-06-27 7:39 ` Richard Weinberger
2019-07-07 18:45 ` Richard Weinberger
0 siblings, 1 reply; 3+ messages in thread
From: Richard Weinberger @ 2019-06-27 7:39 UTC (permalink / raw)
To: Masahiro Yamada
Cc: David Woodhouse, Brian Norris, Marek Vasut, Miquel Raynal,
Vignesh Raghavendra, linux-mtd, linux-kernel
----- Ursprüngliche Mail -----
> Von: "Masahiro Yamada" <yamada.masahiro@socionext.com>
> An: "David Woodhouse" <dwmw2@infradead.org>, "Brian Norris" <computersforpeace@gmail.com>, "Marek Vasut"
> <marek.vasut@gmail.com>, "Miquel Raynal" <miquel.raynal@bootlin.com>, "richard" <richard@nod.at>, "Vignesh Raghavendra"
> <vigneshr@ti.com>, "linux-mtd" <linux-mtd@lists.infradead.org>
> CC: "Masahiro Yamada" <yamada.masahiro@socionext.com>, "linux-kernel" <linux-kernel@vger.kernel.org>
> Gesendet: Donnerstag, 27. Juni 2019 09:07:45
> Betreff: [PATCH] mtd: abi: do not use C++ style comments in uapi header
> Linux kernel tolerates C++ style comments these days. Actually, the
> SPDX License tags for .c files start with //.
>
> On the other hand, uapi headers are written in more strict C, where
> the C++ comment style is forbidden.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Richard Weinberger <richard@nod.at>
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: abi: do not use C++ style comments in uapi header
2019-06-27 7:39 ` Richard Weinberger
@ 2019-07-07 18:45 ` Richard Weinberger
0 siblings, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2019-07-07 18:45 UTC (permalink / raw)
To: Richard Weinberger
Cc: Masahiro Yamada, Vignesh Raghavendra, linux-kernel, Marek Vasut,
linux-mtd, Miquel Raynal, Brian Norris, David Woodhouse
On Thu, Jun 27, 2019 at 9:40 AM Richard Weinberger <richard@nod.at> wrote:
>
> ----- Ursprüngliche Mail -----
> > Von: "Masahiro Yamada" <yamada.masahiro@socionext.com>
> > An: "David Woodhouse" <dwmw2@infradead.org>, "Brian Norris" <computersforpeace@gmail.com>, "Marek Vasut"
> > <marek.vasut@gmail.com>, "Miquel Raynal" <miquel.raynal@bootlin.com>, "richard" <richard@nod.at>, "Vignesh Raghavendra"
> > <vigneshr@ti.com>, "linux-mtd" <linux-mtd@lists.infradead.org>
> > CC: "Masahiro Yamada" <yamada.masahiro@socionext.com>, "linux-kernel" <linux-kernel@vger.kernel.org>
> > Gesendet: Donnerstag, 27. Juni 2019 09:07:45
> > Betreff: [PATCH] mtd: abi: do not use C++ style comments in uapi header
>
> > Linux kernel tolerates C++ style comments these days. Actually, the
> > SPDX License tags for .c files start with //.
> >
> > On the other hand, uapi headers are written in more strict C, where
> > the C++ comment style is forbidden.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Acked-by: Richard Weinberger <richard@nod.at>
Applied. :-)
--
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-07 18:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-27 7:07 [PATCH] mtd: abi: do not use C++ style comments in uapi header Masahiro Yamada
2019-06-27 7:39 ` Richard Weinberger
2019-07-07 18:45 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).