* [PATCH 2/2] mm: Fixup abandoned PG_buddy for private in struct page
@ 2012-09-06 9:11 Li Haifeng
2012-09-28 16:34 ` Johannes Weiner
0 siblings, 1 reply; 2+ messages in thread
From: Li Haifeng @ 2012-09-06 9:11 UTC (permalink / raw)
To: Andrew Morton, Christoph Lameter, David Rientjes, Minchan Kim,
Johannes Weiner, linux-kernel
PG_buddy, an abandoned flag, indicates page(s) is/are free
and in buddy allocator. And when page(s) in buddy allocator,
the _mapcount will equal PAGE_BUDDY_MAPCOUNT_VALUE. So,
here, "_mapcount equals PAGE_BUDDY_MAPCOUNT_VALUE" instead
of "PG_buddy is set".
Signed-off-by: Haifeng Li <omycle@gmail.com>
---
include/linux/mm_types.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
index 704a626..49d9247 100644
--- a/include/linux/mm_types.h
+++ b/include/linux/mm_types.h
@@ -126,7 +126,8 @@ struct page {
* if PagePrivate set; used for
* swp_entry_t if PageSwapCache;
* indicates order in the buddy
- * system if PG_buddy is set.
+ * system if _mapcount equals
+ * PAGE_BUDDY_MAPCOUNT_VALUE.
*/
#if USE_SPLIT_PTLOCKS
spinlock_t ptl;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] mm: Fixup abandoned PG_buddy for private in struct page
2012-09-06 9:11 [PATCH 2/2] mm: Fixup abandoned PG_buddy for private in struct page Li Haifeng
@ 2012-09-28 16:34 ` Johannes Weiner
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Weiner @ 2012-09-28 16:34 UTC (permalink / raw)
To: Li Haifeng
Cc: Andrew Morton, Christoph Lameter, David Rientjes, Minchan Kim,
linux-kernel
On Thu, Sep 06, 2012 at 05:11:18PM +0800, Li Haifeng wrote:
> PG_buddy, an abandoned flag, indicates page(s) is/are free
> and in buddy allocator. And when page(s) in buddy allocator,
> the _mapcount will equal PAGE_BUDDY_MAPCOUNT_VALUE. So,
> here, "_mapcount equals PAGE_BUDDY_MAPCOUNT_VALUE" instead
> of "PG_buddy is set".
>
> Signed-off-by: Haifeng Li <omycle@gmail.com>
> ---
> include/linux/mm_types.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
> index 704a626..49d9247 100644
> --- a/include/linux/mm_types.h
> +++ b/include/linux/mm_types.h
> @@ -126,7 +126,8 @@ struct page {
> * if PagePrivate set; used for
> * swp_entry_t if PageSwapCache;
> * indicates order in the buddy
> - * system if PG_buddy is set.
> + * system if _mapcount equals
> + * PAGE_BUDDY_MAPCOUNT_VALUE.
How about simply "if PageBuddy", just like the previous sentence about
swap cache does? No reason to expose the implementation of PageBuddy
at this point, I guess...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-28 16:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-06 9:11 [PATCH 2/2] mm: Fixup abandoned PG_buddy for private in struct page Li Haifeng
2012-09-28 16:34 ` Johannes Weiner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).