* [PATCH 1/1] irq_work.h: fix warning when CONFIG_IRQ_WORK=n
@ 2013-03-08 11:36 James Hogan
2013-03-08 11:42 ` James Hogan
2013-03-08 12:38 ` Frederic Weisbecker
0 siblings, 2 replies; 4+ messages in thread
From: James Hogan @ 2013-03-08 11:36 UTC (permalink / raw)
To: Steven Rostedt, Frederic Weisbecker
Cc: linux-kernel, James Hogan, Peter Zijlstra, Thomas Gleixner,
Ingo Molnar, Andrew Morton, Paul Gortmaker
A randconfig caught repeated compiler warnings when CONFIG_IRQ_WORK=n
due to the definition of a non-inline static function in
<linux/irq_work.h>:
include/linux/irq_work.h +40 : warning: 'irq_work_needs_cpu' defined but not used
Make it inline to supress the warning. This is caused by the following
commit:
Commit 00b42959106a9ca1c2899e591ae4e9a83ad6af05 ("irq_work: Don't stop
the tick with pending works") merged in v3.9-rc1.
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
---
include/linux/irq_work.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/irq_work.h b/include/linux/irq_work.h
index f5dbce5..6601702 100644
--- a/include/linux/irq_work.h
+++ b/include/linux/irq_work.h
@@ -37,7 +37,7 @@ void irq_work_sync(struct irq_work *work);
#ifdef CONFIG_IRQ_WORK
bool irq_work_needs_cpu(void);
#else
-static bool irq_work_needs_cpu(void) { return false; }
+static inline bool irq_work_needs_cpu(void) { return false; }
#endif
#endif /* _LINUX_IRQ_WORK_H */
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] irq_work.h: fix warning when CONFIG_IRQ_WORK=n
2013-03-08 11:36 [PATCH 1/1] irq_work.h: fix warning when CONFIG_IRQ_WORK=n James Hogan
@ 2013-03-08 11:42 ` James Hogan
2013-03-08 12:38 ` Frederic Weisbecker
2013-03-08 12:38 ` Frederic Weisbecker
1 sibling, 1 reply; 4+ messages in thread
From: James Hogan @ 2013-03-08 11:42 UTC (permalink / raw)
To: Steven Rostedt, Frederic Weisbecker
Cc: James Hogan, linux-kernel, Peter Zijlstra, Thomas Gleixner,
Ingo Molnar, Andrew Morton, Paul Gortmaker
On 08/03/13 11:36, James Hogan wrote:
> A randconfig caught repeated compiler warnings when CONFIG_IRQ_WORK=n
> due to the definition of a non-inline static function in
> <linux/irq_work.h>:
>
> include/linux/irq_work.h +40 : warning: 'irq_work_needs_cpu' defined but not used
In addition to this warning I also got the following linker error when
CONFIG_IRQ_WORK=n:
kernel/built-in.o In function `wake_up_klogd':
(.text.wake_up_klogd+0xb4): undefined reference to `irq_work_queue'
which appears to be because of the following commit:
commit 74876a98a87a115254b3a66a14b27320b7f0acaa ("printk: Wake up klogd
using irq_work") also merged in v3.9-rc1.
Can somebody more familiar with that code please fix it.
Cheers
James
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] irq_work.h: fix warning when CONFIG_IRQ_WORK=n
2013-03-08 11:42 ` James Hogan
@ 2013-03-08 12:38 ` Frederic Weisbecker
0 siblings, 0 replies; 4+ messages in thread
From: Frederic Weisbecker @ 2013-03-08 12:38 UTC (permalink / raw)
To: James Hogan
Cc: Steven Rostedt, linux-kernel, Peter Zijlstra, Thomas Gleixner,
Ingo Molnar, Andrew Morton, Paul Gortmaker
2013/3/8 James Hogan <james.hogan@imgtec.com>:
> In addition to this warning I also got the following linker error when
> CONFIG_IRQ_WORK=n:
>
> kernel/built-in.o In function `wake_up_klogd':
> (.text.wake_up_klogd+0xb4): undefined reference to `irq_work_queue'
>
> which appears to be because of the following commit:
>
> commit 74876a98a87a115254b3a66a14b27320b7f0acaa ("printk: Wake up klogd
> using irq_work") also merged in v3.9-rc1.
>
> Can somebody more familiar with that code please fix it.
I see. We need to make a wake_up_klogd() off case when CONFIG_PRINTK=n
I'm working on this.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] irq_work.h: fix warning when CONFIG_IRQ_WORK=n
2013-03-08 11:36 [PATCH 1/1] irq_work.h: fix warning when CONFIG_IRQ_WORK=n James Hogan
2013-03-08 11:42 ` James Hogan
@ 2013-03-08 12:38 ` Frederic Weisbecker
1 sibling, 0 replies; 4+ messages in thread
From: Frederic Weisbecker @ 2013-03-08 12:38 UTC (permalink / raw)
To: James Hogan
Cc: Steven Rostedt, linux-kernel, Peter Zijlstra, Thomas Gleixner,
Ingo Molnar, Andrew Morton, Paul Gortmaker
2013/3/8 James Hogan <james.hogan@imgtec.com>:
> A randconfig caught repeated compiler warnings when CONFIG_IRQ_WORK=n
> due to the definition of a non-inline static function in
> <linux/irq_work.h>:
>
> include/linux/irq_work.h +40 : warning: 'irq_work_needs_cpu' defined but not used
>
> Make it inline to supress the warning. This is caused by the following
> commit:
>
> Commit 00b42959106a9ca1c2899e591ae4e9a83ad6af05 ("irq_work: Don't stop
> the tick with pending works") merged in v3.9-rc1.
>
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-08 12:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-08 11:36 [PATCH 1/1] irq_work.h: fix warning when CONFIG_IRQ_WORK=n James Hogan
2013-03-08 11:42 ` James Hogan
2013-03-08 12:38 ` Frederic Weisbecker
2013-03-08 12:38 ` Frederic Weisbecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).