From: Noah Goldstein <goldstein.w.n@gmail.com>
To: David Laight <David.Laight@aculab.com>
Cc: kernel test robot <lkp@intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"oe-kbuild-all@lists.linux.dev" <oe-kbuild-all@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"hpa@zytor.com" <hpa@zytor.com>
Subject: Re: x86/csum: Remove unnecessary odd handling
Date: Thu, 4 Jan 2024 15:28:01 -0800 [thread overview]
Message-ID: <CAFUsyfLuo0_Sm91mqbM8Sbo-ncwnM4RaRq=GxQXDmkAN-nQ3uw@mail.gmail.com> (raw)
In-Reply-To: <CAFUsyfJduB29c6=BNmTtgoWcHAWA1AZ-sdbhyp02JVhvA6Gp0w@mail.gmail.com>
On Sat, Dec 23, 2023 at 2:18 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> On Sun, Sep 24, 2023 at 7:35 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > On Sat, Sep 23, 2023 at 4:13 PM David Laight <David.Laight@aculab.com> wrote:
> > >
> > > From: Noah Goldstein
> > > > Sent: 23 September 2023 15:05
> > > >
> > > > On Fri, Sep 22, 2023 at 10:25 PM kernel test robot <lkp@intel.com> wrote:
> > > > >
> > > > > Hi Noah,
> > > > >
> > > > > kernel test robot noticed the following build warnings:
> > > > >
> > > > > [auto build test WARNING on tip/x86/core]
> > > > > [also build test WARNING on tip/master tip/auto-latest linus/master v6.6-rc2 next-20230921]
> > > > > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > > > > And when submitting patch, we suggest to use '--base' as documented in
> > > > > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> > > > >
> > > > > url: https://github.com/intel-lab-lkp/linux/commits/Noah-Goldstein/x86-csum-Remove-unnecessary-
> > > > odd-handling/20230921-032450
> > > > > base: tip/x86/core
> > > > > patch link: https://lore.kernel.org/r/20230920192300.3772199-1-goldstein.w.n%40gmail.com
> > > > > patch subject: x86/csum: Remove unnecessary odd handling
> > > > > config: x86_64-randconfig-121-20230921 (https://download.01.org/0day-
> > > > ci/archive/20230923/202309231130.ZI5MdlDc-lkp@intel.com/config)
> > > > > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> > > > > reproduce (this is a W=1 build): (https://download.01.org/0day-
> > > > ci/archive/20230923/202309231130.ZI5MdlDc-lkp@intel.com/reproduce)
> > > > >
> > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > > > the same patch/commit), kindly add following tags
> > > > > | Reported-by: kernel test robot <lkp@intel.com>
> > > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202309231130.ZI5MdlDc-lkp@intel.com/
> > > > >
> > > > > sparse warnings: (new ones prefixed by >>)
> > > > > >> arch/x86/lib/csum-partial_64.c:16:45: sparse: sparse: incorrect type in return expression
> > > > (different base types) @@ expected restricted __wsum @@ got unsigned long long @@
> > > > > arch/x86/lib/csum-partial_64.c:16:45: sparse: expected restricted __wsum
> > > > > arch/x86/lib/csum-partial_64.c:16:45: sparse: got unsigned long long
> > > > > >> arch/x86/lib/csum-partial_64.c:16:45: sparse: sparse: incorrect type in return expression
> > > > (different base types) @@ expected restricted __wsum @@ got unsigned long long @@
> > > > > arch/x86/lib/csum-partial_64.c:16:45: sparse: expected restricted __wsum
> > > > > arch/x86/lib/csum-partial_64.c:16:45: sparse: got unsigned long long
> > > > >
> > > > > vim +16 arch/x86/lib/csum-partial_64.c
> > > > >
> > > > > 13
> > > > > 14 static inline __wsum csum_finalize_sum(u64 temp64)
> > > > > 15 {
> > > > > > 16 return (temp64 + ror64(temp64, 32)) >> 32;
> > > > > 17 }
> > > > > 18
> > > >
> > > > Just needs a `(__wsum)` cast. Should I post a new patch?
> > >
> > > It'll need to be a (__force __wsum) cast.
> > >
> > > I think new patches are expected...
> > >
> > Thank you, posted V4 that should fix the warning.
> > > David
> > >
> > > -
> > > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> > > Registration No: 1397386 (Wales)
>
> ping.
ping
next prev parent reply other threads:[~2024-01-04 23:28 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230628020657.957880-1-goldstein.w.n@gmail.com>
2023-06-28 9:12 ` x86/csum: Remove unnecessary odd handling Borislav Petkov
2023-06-28 15:32 ` Noah Goldstein
2023-06-28 17:44 ` Linus Torvalds
2023-06-28 18:34 ` Noah Goldstein
2023-06-28 20:02 ` Linus Torvalds
2023-06-29 14:04 ` David Laight
2023-06-29 14:27 ` David Laight
2023-09-01 22:21 ` Noah Goldstein
2023-09-06 13:49 ` David Laight
2023-09-06 14:38 ` David Laight
2023-09-20 19:20 ` Noah Goldstein
2023-09-20 19:23 ` Noah Goldstein
2023-09-23 3:24 ` kernel test robot
2023-09-23 14:05 ` Noah Goldstein
2023-09-23 21:13 ` David Laight
2023-09-24 14:35 ` Noah Goldstein
2023-12-23 22:18 ` Noah Goldstein
2024-01-04 23:28 ` Noah Goldstein [this message]
2024-01-04 23:34 ` Dave Hansen
2024-01-04 23:36 ` Linus Torvalds
2024-01-05 0:33 ` Linus Torvalds
2024-01-05 10:41 ` David Laight
2024-01-05 16:12 ` David Laight
2024-01-05 18:05 ` Linus Torvalds
2024-01-05 23:52 ` David Laight
2024-01-06 0:18 ` Linus Torvalds
2024-01-06 10:26 ` Eric Dumazet
2024-01-06 19:32 ` Linus Torvalds
2024-01-07 12:11 ` David Laight
2024-01-06 22:08 ` David Laight
2024-01-07 1:09 ` H. Peter Anvin
2024-01-07 11:44 ` David Laight
2023-09-24 14:35 ` Noah Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFUsyfLuo0_Sm91mqbM8Sbo-ncwnM4RaRq=GxQXDmkAN-nQ3uw@mail.gmail.com' \
--to=goldstein.w.n@gmail.com \
--cc=David.Laight@aculab.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=edumazet@google.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@redhat.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).