* [PATCH] ARM: dts: vf610-zii-dev-rev-c.dts: Configure fibre port to 1000BaseX
@ 2020-07-06 0:51 Chris Healy
2020-07-08 18:40 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Chris Healy @ 2020-07-06 0:51 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Stefan Agner, Rob Herring, linux ARM,
Fabio Estevam, devicetree, linux-kernel
The SFF soldered onto the board expects the port to use 1000BaseX. It
makes no sense to have the port set to SGMII, since it doesn't even
support that mode.
Signed-off-by: Chris Healy <cphealy@gmail.com>
---
arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
index 778e02c000d1..de79dcfd32e6 100644
--- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
+++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
@@ -164,7 +164,7 @@
port@9 {
reg = <9>;
label = "sff2";
- phy-mode = "sgmii";
+ phy-mode = "1000base-x";
managed = "in-band-status";
sfp = <&sff2>;
};
--
2.21.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: vf610-zii-dev-rev-c.dts: Configure fibre port to 1000BaseX
2020-07-06 0:51 [PATCH] ARM: dts: vf610-zii-dev-rev-c.dts: Configure fibre port to 1000BaseX Chris Healy
@ 2020-07-08 18:40 ` Fabio Estevam
2020-07-08 18:52 ` Chris Healy
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2020-07-08 18:40 UTC (permalink / raw)
To: Chris Healy
Cc: Shawn Guo, Sascha Hauer, Stefan Agner, Rob Herring, linux ARM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel
Hi Chris,
In the Subject you could remove the .dts from the dts name:
ARM: dts: vf610-zii-dev-rev-c: Configure fibre port to 1000BaseX
On Sun, Jul 5, 2020 at 9:51 PM Chris Healy <cphealy@gmail.com> wrote:
>
> The SFF soldered onto the board expects the port to use 1000BaseX. It
> makes no sense to have the port set to SGMII, since it doesn't even
> support that mode.
>
> Signed-off-by: Chris Healy <cphealy@gmail.com>
> ---
> arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> index 778e02c000d1..de79dcfd32e6 100644
> --- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> @@ -164,7 +164,7 @@
> port@9 {
> reg = <9>;
> label = "sff2";
> - phy-mode = "sgmii";
> + phy-mode = "1000base-x";
Looks like tabs were converted to spaces.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: vf610-zii-dev-rev-c.dts: Configure fibre port to 1000BaseX
2020-07-08 18:40 ` Fabio Estevam
@ 2020-07-08 18:52 ` Chris Healy
0 siblings, 0 replies; 3+ messages in thread
From: Chris Healy @ 2020-07-08 18:52 UTC (permalink / raw)
To: Fabio Estevam
Cc: Shawn Guo, Sascha Hauer, Stefan Agner, Rob Herring, linux ARM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel
On Wed, Jul 8, 2020 at 11:41 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Chris,
>
> In the Subject you could remove the .dts from the dts name:
>
> ARM: dts: vf610-zii-dev-rev-c: Configure fibre port to 1000BaseX
>
> On Sun, Jul 5, 2020 at 9:51 PM Chris Healy <cphealy@gmail.com> wrote:
> >
> > The SFF soldered onto the board expects the port to use 1000BaseX. It
> > makes no sense to have the port set to SGMII, since it doesn't even
> > support that mode.
> >
> > Signed-off-by: Chris Healy <cphealy@gmail.com>
> > ---
> > arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> > b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> > index 778e02c000d1..de79dcfd32e6 100644
> > --- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> > +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> > @@ -164,7 +164,7 @@
> > port@9 {
> > reg = <9>;
> > label = "sff2";
> > - phy-mode = "sgmii";
> > + phy-mode = "1000base-x";
>
> Looks like tabs were converted to spaces.
I'll make both changes and submit a v2, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-08 18:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-06 0:51 [PATCH] ARM: dts: vf610-zii-dev-rev-c.dts: Configure fibre port to 1000BaseX Chris Healy
2020-07-08 18:40 ` Fabio Estevam
2020-07-08 18:52 ` Chris Healy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).