LKML Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ARM64: dts: update MDIO speed and preamble for zii-ultra device
@ 2020-07-05  1:26 Chris Healy
  2020-07-07 21:54 ` Fabio Estevam
  2020-07-07 21:59 ` Florian Fainelli
  0 siblings, 2 replies; 5+ messages in thread
From: Chris Healy @ 2020-07-05  1:26 UTC (permalink / raw)
  To: Shawn Guo, Fabio Estevam, Andrew Lunn, Rob Herring, devicetree,
	linux-kernel, linux ARM

Update MDIO configuration with zii-ultra device to fully utilize
MDIO endpoint capabilities.  Device supports 12.5MHz clock and
doesn't require MDIO preamble.

Signed-off-by: Chris Healy <cphealy@gmail.com>
---
 arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
index 6a55165bd76a..98aa67a4c040 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
@@ -132,6 +132,8 @@
         #address-cells = <1>;
         #size-cells = <0>;
         status = "okay";
+        suppress-preamble = <1>;
+        clock-frequency = <12500000>;

         switch: switch@0 {
             compatible = "marvell,mv88e6085";
-- 
2.21.3

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM64: dts: update MDIO speed and preamble for zii-ultra device
  2020-07-05  1:26 [PATCH] ARM64: dts: update MDIO speed and preamble for zii-ultra device Chris Healy
@ 2020-07-07 21:54 ` Fabio Estevam
  2020-07-07 22:13   ` Chris Healy
  2020-07-07 21:59 ` Florian Fainelli
  1 sibling, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2020-07-07 21:54 UTC (permalink / raw)
  To: Chris Healy
  Cc: Shawn Guo, Andrew Lunn, Rob Herring,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel, linux ARM

Hi Chris,

The subject pattern used for ARM64 i.MX patches is like:

arm64: dts: zii-ultra: update MDIO speed and preamble

On Sat, Jul 4, 2020 at 10:26 PM Chris Healy <cphealy@gmail.com> wrote:
>
> Update MDIO configuration with zii-ultra device to fully utilize
> MDIO endpoint capabilities.  Device supports 12.5MHz clock and
> doesn't require MDIO preamble.
>
> Signed-off-by: Chris Healy <cphealy@gmail.com>

Other than that:

Reviewed-by: Fabio Estevam <festevam@gmail.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM64: dts: update MDIO speed and preamble for zii-ultra device
  2020-07-05  1:26 [PATCH] ARM64: dts: update MDIO speed and preamble for zii-ultra device Chris Healy
  2020-07-07 21:54 ` Fabio Estevam
@ 2020-07-07 21:59 ` Florian Fainelli
  2020-07-07 22:12   ` Chris Healy
  1 sibling, 1 reply; 5+ messages in thread
From: Florian Fainelli @ 2020-07-07 21:59 UTC (permalink / raw)
  To: Chris Healy, Shawn Guo, Fabio Estevam, Andrew Lunn, Rob Herring,
	devicetree, linux-kernel, linux ARM

Hi Chris,

On 7/4/2020 6:26 PM, Chris Healy wrote:
> Update MDIO configuration with zii-ultra device to fully utilize
> MDIO endpoint capabilities.  Device supports 12.5MHz clock and
> doesn't require MDIO preamble.
> 
> Signed-off-by: Chris Healy <cphealy@gmail.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> index 6a55165bd76a..98aa67a4c040 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> @@ -132,6 +132,8 @@
>          #address-cells = <1>;
>          #size-cells = <0>;
>          status = "okay";
> +        suppress-preamble = <1>;

suppress-preamble is defined as a boolean, so you can remove the "= <1>"
part entirely.
-- 
Florian

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM64: dts: update MDIO speed and preamble for zii-ultra device
  2020-07-07 21:59 ` Florian Fainelli
@ 2020-07-07 22:12   ` Chris Healy
  0 siblings, 0 replies; 5+ messages in thread
From: Chris Healy @ 2020-07-07 22:12 UTC (permalink / raw)
  To: Florian Fainelli
  Cc: Shawn Guo, Fabio Estevam, Andrew Lunn, Rob Herring, devicetree,
	linux-kernel, linux ARM

On Tue, Jul 7, 2020 at 2:59 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> Hi Chris,
>
> On 7/4/2020 6:26 PM, Chris Healy wrote:
> > Update MDIO configuration with zii-ultra device to fully utilize
> > MDIO endpoint capabilities.  Device supports 12.5MHz clock and
> > doesn't require MDIO preamble.
> >
> > Signed-off-by: Chris Healy <cphealy@gmail.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > index 6a55165bd76a..98aa67a4c040 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > @@ -132,6 +132,8 @@
> >          #address-cells = <1>;
> >          #size-cells = <0>;
> >          status = "okay";
> > +        suppress-preamble = <1>;
>
> suppress-preamble is defined as a boolean, so you can remove the "= <1>"
> part entirely.

Good point, I'll make the necessary change.

> --
> Florian

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM64: dts: update MDIO speed and preamble for zii-ultra device
  2020-07-07 21:54 ` Fabio Estevam
@ 2020-07-07 22:13   ` Chris Healy
  0 siblings, 0 replies; 5+ messages in thread
From: Chris Healy @ 2020-07-07 22:13 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: Shawn Guo, Andrew Lunn, Rob Herring,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel, linux ARM

On Tue, Jul 7, 2020 at 2:54 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Chris,
>
> The subject pattern used for ARM64 i.MX patches is like:
>
> arm64: dts: zii-ultra: update MDIO speed and preamble

Thanks for pointing this out.  I have to make a change to this patch
anyway so I will resubmit with the correct subject pattern.

>
> On Sat, Jul 4, 2020 at 10:26 PM Chris Healy <cphealy@gmail.com> wrote:
> >
> > Update MDIO configuration with zii-ultra device to fully utilize
> > MDIO endpoint capabilities.  Device supports 12.5MHz clock and
> > doesn't require MDIO preamble.
> >
> > Signed-off-by: Chris Healy <cphealy@gmail.com>
>
> Other than that:
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-05  1:26 [PATCH] ARM64: dts: update MDIO speed and preamble for zii-ultra device Chris Healy
2020-07-07 21:54 ` Fabio Estevam
2020-07-07 22:13   ` Chris Healy
2020-07-07 21:59 ` Florian Fainelli
2020-07-07 22:12   ` Chris Healy

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git