From: Brendan Higgins <brendanhiggins@google.com>
To: Alan Maguire <alan.maguire@oracle.com>
Cc: Frank Rowand <frowand.list@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>, shuah <shuah@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
KUnit Development <kunit-dev@googlegroups.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v7 kunit-next 0/4] kunit: add debugfs representation to show results
Date: Fri, 13 Mar 2020 17:03:07 -0700 [thread overview]
Message-ID: <CAFd5g44FvKCjj-qHCpkZhQEtWxgR7fA5qiNb_GN_YANuzsJM1w@mail.gmail.com> (raw)
In-Reply-To: <1584110682-3837-1-git-send-email-alan.maguire@oracle.com>
On Fri, Mar 13, 2020 at 7:44 AM Alan Maguire <alan.maguire@oracle.com> wrote:
>
> When kunit tests are run on native (i.e. non-UML) environments, the results
> of test execution are often intermixed with dmesg output. This patch
> series attempts to solve this by providing a debugfs representation
> of the results of the last test run, available as
>
> /sys/kernel/debug/kunit/<testsuite>/results
>
> Changes since v6:
>
> - fixed regexp parsing in kunit_parser.py to ensure test results are read
> successfully with 4-space indentation (Brendan, patch 3)
>
> Changes since v5:
>
> - replaced undefined behaviour use of snprintf(buf, ..., buf) in
> kunit_log() with a function to append string to existing log
> (Frank, patch 1)
> - added clarification on log size limitations to documentation
> (Frank, patch 4)
>
> Changes since v4:
>
> - added suite-level log expectations to kunit log test (Brendan, patch 2)
> - added log expectations (of it being NULL) for case where
> CONFIG_KUNIT_DEBUGFS=n to kunit log test (patch 2)
> - added patch 3 which replaces subtest tab indentation with 4 space
> indentation as per TAP 14 spec (Frank, patch 3)
>
> Changes since v3:
>
> - added CONFIG_KUNIT_DEBUGFS to support conditional compilation of debugfs
> representation, including string logging (Frank, patch 1)
> - removed unneeded NULL check for test_case in
> kunit_suite_for_each_test_case() (Frank, patch 1)
> - added kunit log test to verify logging multiple strings works
> (Frank, patch 2)
> - rephrased description of results file (Frank, patch 3)
>
> Changes since v2:
>
> - updated kunit_status2str() to kunit_status_to_string() and made it
> static inline in include/kunit/test.h (Brendan)
> - added log string to struct kunit_suite and kunit_case, with log
> pointer in struct kunit pointing at the case log. This allows us
> to collect kunit_[err|info|warning]() messages at the same time
> as we printk() them. This solves for the most part the sharing
> of log messages between test execution and debugfs since we
> just print the suite log (which contains the test suite preamble)
> and the individual test logs. The only exception is the suite-level
> status, which we cannot store in the suite log as it would mean
> we'd print the suite and its status prior to the suite's results.
> (Brendan, patch 1)
> - dropped debugfs-based kunit run patch for now so as not to cause
> problems with tests currently under development (Brendan)
> - fixed doc issues with code block (Brendan, patch 3)
>
> Changes since v1:
> - trimmed unneeded include files in lib/kunit/debugfs.c (Greg)
> - renamed global debugfs functions to be prefixed with kunit_ (Greg)
> - removed error checking for debugfs operations (Greg)
Everything looks good to me. I tried running kunit_tool and everything
looked good there well.
prev parent reply other threads:[~2020-03-14 0:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 14:44 [PATCH v7 kunit-next 0/4] kunit: add debugfs representation to show results Alan Maguire
2020-03-13 14:44 ` [PATCH v7 kunit-next 1/4] kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display Alan Maguire
2020-03-13 14:44 ` [PATCH v7 kunit-next 2/4] kunit: add log test Alan Maguire
2020-03-13 14:44 ` [PATCH v7 kunit-next 3/4] kunit: subtests should be indented 4 spaces according to TAP Alan Maguire
2020-03-14 0:00 ` Brendan Higgins
2020-03-25 20:05 ` shuah
2020-03-25 22:03 ` Alan Maguire
2020-03-25 22:11 ` shuah
2020-03-13 14:44 ` [PATCH v7 kunit-next 4/4] kunit: update documentation to describe debugfs representation Alan Maguire
2020-03-14 0:03 ` Brendan Higgins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFd5g44FvKCjj-qHCpkZhQEtWxgR7fA5qiNb_GN_YANuzsJM1w@mail.gmail.com \
--to=brendanhiggins@google.com \
--cc=alan.maguire@oracle.com \
--cc=corbet@lwn.net \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).