* [PATCH] lib/test_string.c: allow mode removal
@ 2021-06-16 23:45 Matteo Croce
2021-06-17 0:35 ` Matteo Croce
0 siblings, 1 reply; 2+ messages in thread
From: Matteo Croce @ 2021-06-16 23:45 UTC (permalink / raw)
To: linux-kernel; +Cc: Geert Uytterhoeven, Andrew Morton
From: Matteo Croce <mcroce@microsoft.com>
The test_string can't be removed because it lacks an exit hook.
Since there is no reason for it to be permanent, add an empty one to
allow module removal.
Signed-off-by: Matteo Croce <mcroce@microsoft.com>
---
lib/test_string.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lib/test_string.c b/lib/test_string.c
index 7b31f4a505bf..9dfd6f52de92 100644
--- a/lib/test_string.c
+++ b/lib/test_string.c
@@ -179,6 +179,10 @@ static __init int strnchr_selftest(void)
return 0;
}
+static __exit void string_selftest_remove(void)
+{
+}
+
static __init int string_selftest_init(void)
{
int test, subtest;
@@ -216,4 +220,5 @@ static __init int string_selftest_init(void)
}
module_init(string_selftest_init);
+module_exit(string_selftest_remove);
MODULE_LICENSE("GPL v2");
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] lib/test_string.c: allow mode removal
2021-06-16 23:45 [PATCH] lib/test_string.c: allow mode removal Matteo Croce
@ 2021-06-17 0:35 ` Matteo Croce
0 siblings, 0 replies; 2+ messages in thread
From: Matteo Croce @ 2021-06-17 0:35 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: Geert Uytterhoeven, Andrew Morton
On Thu, Jun 17, 2021 at 1:45 AM Matteo Croce <mcroce@linux.microsoft.com> wrote:
>
> From: Matteo Croce <mcroce@microsoft.com>
>
> The test_string can't be removed because it lacks an exit hook.
> Since there is no reason for it to be permanent, add an empty one to
> allow module removal.
>
> Signed-off-by: Matteo Croce <mcroce@microsoft.com>
> ---
Small typo, s/mode/module/
Regards,
--
per aspera ad upstream
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-17 0:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 23:45 [PATCH] lib/test_string.c: allow mode removal Matteo Croce
2021-06-17 0:35 ` Matteo Croce
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).