From: Vivek Gautam <vivek.gautam@codeaurora.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Felipe Balbi <balbi@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] reset: Add API to count number of reset available with device
Date: Thu, 16 Mar 2017 09:18:40 +0530 [thread overview]
Message-ID: <CAFp+6iFekTwuaznQq9bkFVrDxz25xD-2SmLV5BBB9akDD8HP6A@mail.gmail.com> (raw)
In-Reply-To: <1489574410.2528.8.camel@pengutronix.de>
Hi Philipp,
On Wed, Mar 15, 2017 at 4:10 PM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Hi Vivek,
>
> On Fri, 2017-03-10 at 20:10 +0530, Vivek Gautam wrote:
>> Hi Philipp,
>>
>>
>> On Wed, Feb 22, 2017 at 10:54 AM, Vivek Gautam
>> <vivek.gautam@codeaurora.org> wrote:
>> > Count number of reset phandles available with the device node
>> > to know the resets a given device has.
>> >
>> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
>> > Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
>> > ---
>>
>> Any thoughts on this change?
>> A small addition that seems useful.
>
> Sorry I missed this one earlier.
>
>> >
>> > Based on torvald's master branch.
>> >
>> > include/linux/reset.h | 16 ++++++++++++++++
>> > 1 file changed, 16 insertions(+)
>> >
>> > diff --git a/include/linux/reset.h b/include/linux/reset.h
>> > index 5daff15722d3..88f63a640153 100644
>> > --- a/include/linux/reset.h
>> > +++ b/include/linux/reset.h
>> > @@ -2,6 +2,7 @@
>> > #define _LINUX_RESET_H_
>> >
>> > #include <linux/device.h>
>> > +#include <linux/of.h>
>> >
>> > struct reset_control;
>> >
>> > @@ -234,6 +235,21 @@ static inline struct reset_control *of_reset_control_get_shared_by_index(
>> > }
>> >
>> > /**
>> > + * of_reset_control_get_count - Count number of resets available with a device
>> > + * @node: device to be reset by the controller
>> > + */
>> > +static inline unsigned int of_reset_control_get_count(struct device_node *node)
>> > +{
>> > + int count;
>> > +
>> > + count = of_count_phandle_with_args(node, "resets", "#reset-cells");
>> > + if (count < 0)
>> > + return 0;
>
> Please don't silently ignore errors. gpiod_count doesn't ignore errors
> either. tegra_powergate_of_resets in drivers/soc/tegra/pmc.c open codes
> this, too. This should be changed so it can be used there, too.
Sure, will change this. I can prepare a patch for tegra/pmc.c as well
using this.
Best regards
Vivek
>
> regards
> Philipp
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2017-03-16 3:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 5:24 [PATCH 1/2] reset: Add API to count number of reset available with device Vivek Gautam
2017-02-22 5:24 ` [PATCH 2/2] usb; dwc3: of-simple: Add support to get resets for the device Vivek Gautam
2017-03-10 11:24 ` Felipe Balbi
2017-03-10 12:18 ` Vivek Gautam
2017-03-10 14:06 ` Felipe Balbi
2017-03-15 10:45 ` Philipp Zabel
2017-03-16 5:34 ` Vivek Gautam
2017-03-10 14:40 ` [PATCH 1/2] reset: Add API to count number of reset available with device Vivek Gautam
2017-03-15 10:40 ` Philipp Zabel
2017-03-16 3:48 ` Vivek Gautam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFp+6iFekTwuaznQq9bkFVrDxz25xD-2SmLV5BBB9akDD8HP6A@mail.gmail.com \
--to=vivek.gautam@codeaurora.org \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).