From: Vivek Gautam <gautam.vivek@samsung.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Linux USB Mailing List <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>, kishon <kishon@ti.com>,
Kukjin Kim <kgene.kim@samsung.com>
Subject: Re: [PATCH 3/5] phy: exynos5-usbdrd: Add facility for VBUS-BOOST-5V supply
Date: Mon, 1 Sep 2014 13:27:38 +0530 [thread overview]
Message-ID: <CAFp+6iFrx6RJJjkuLpy+2RGsscpf2PXUATABJq8oPL+XhE_+vQ@mail.gmail.com> (raw)
In-Reply-To: <20140828191625.GQ16689@saruman.home>
Hi Felipe,
On Fri, Aug 29, 2014 at 12:46 AM, Felipe Balbi <balbi@ti.com> wrote:
> hi,
>
> On Thu, Aug 28, 2014 at 01:31:58PM +0530, Vivek Gautam wrote:
>> @@ -457,11 +458,19 @@ static int exynos5_usbdrd_phy_power_on(struct phy *phy)
>> clk_prepare_enable(phy_drd->ref_clk);
>>
>> /* Enable VBUS supply */
>> + if (phy_drd->vbus_boost) {
>> + ret = regulator_enable(phy_drd->vbus_boost);
>> + if (ret) {
>> + dev_err(phy_drd->dev,
>> + "Failed to enable VBUS boost supply\n");
>> + goto fail_vbus;
>> + }
>> + }
>
> really this is nitpicking, but can you add a blank line here just make
> my inner child happy ? :-)
Sure will add an extra line here and similar instances of this change.
>
>> @@ -470,6 +479,9 @@ static int exynos5_usbdrd_phy_power_on(struct phy *phy)
>>
>> return 0;
>>
>> +fail_vbus_boost:
>> + if (phy_drd->vbus_boost)
>> + regulator_disable(phy_drd->vbus_boost);
>
> same here
>
> --
> balbi
--
Best Regards
Vivek Gautam
Samsung R&D Institute, Bangalore
India
next prev parent reply other threads:[~2014-09-01 7:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 8:01 [PATCH 0/5] usb: dwc3/phy-exynos5-usbdrd: Extend support to Exynos7 Vivek Gautam
2014-08-28 8:01 ` [PATCH 1/5] usb: dwc3: exynos: Add support for SCLK present on Exynos7 Vivek Gautam
2014-08-28 18:48 ` Mark Rutland
2014-09-02 10:39 ` Vivek Gautam
2014-09-02 11:01 ` Mark Rutland
2014-09-02 14:35 ` Felipe Balbi
2014-08-28 8:01 ` [PATCH 2/5] phy: exynos5-usbdrd: Add pipe-clk and utmi-clk support Vivek Gautam
2014-08-28 18:50 ` Mark Rutland
2014-08-28 8:01 ` [PATCH 3/5] phy: exynos5-usbdrd: Add facility for VBUS-BOOST-5V supply Vivek Gautam
2014-08-28 19:16 ` Felipe Balbi
2014-09-01 7:57 ` Vivek Gautam [this message]
2014-08-28 8:01 ` [PATCH 4/5] usb: dwc3: Adding Kconfig dependency for Exynos7 Vivek Gautam
2014-08-28 19:28 ` Felipe Balbi
2014-09-03 3:53 ` Vivek Gautam
2014-08-28 8:02 ` [PATCH 5/5] phy: exynos5-usbdrd: " Vivek Gautam
2014-08-28 15:06 ` Daniele Forsi
2014-09-01 8:00 ` Vivek Gautam
2014-09-02 14:37 ` Felipe Balbi
2014-09-03 4:02 ` Vivek Gautam
2014-09-03 14:46 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFp+6iFrx6RJJjkuLpy+2RGsscpf2PXUATABJq8oPL+XhE_+vQ@mail.gmail.com \
--to=gautam.vivek@samsung.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kgene.kim@samsung.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).