* [PATCH 1/3] phy: fix semicolon.cocci warnings
@ 2016-10-20 6:53 Vivek Gautam
2016-10-20 6:53 ` [PATCH 2/3] phy: Fix ptr_ret.cocci warnings Vivek Gautam
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Vivek Gautam @ 2016-10-20 6:53 UTC (permalink / raw)
To: kishon
Cc: linux-kernel, linux-samsung-soc, linux-rockchip, linux-tegra,
Vivek Gautam
Remove unneeded semicolon.
Generated by: coccinellery/semicolon/semicolon.cocci
Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/phy/phy-brcm-sata.c | 6 +++---
drivers/phy/phy-exynos4210-usb2.c | 4 ++--
drivers/phy/phy-exynos4x12-usb2.c | 4 ++--
drivers/phy/phy-exynos5250-usb2.c | 2 +-
drivers/phy/phy-rockchip-emmc.c | 2 +-
drivers/phy/phy-s5pv210-usb2.c | 4 ++--
6 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/phy/phy-brcm-sata.c b/drivers/phy/phy-brcm-sata.c
index 8ffc44a..ccbc3d9 100644
--- a/drivers/phy/phy-brcm-sata.c
+++ b/drivers/phy/phy-brcm-sata.c
@@ -140,7 +140,7 @@ static inline void __iomem *brcm_sata_pcb_base(struct brcm_sata_port *port)
default:
dev_err(priv->dev, "invalid phy version\n");
break;
- };
+ }
return priv->phy_base + (port->portnum * size);
}
@@ -157,7 +157,7 @@ static inline void __iomem *brcm_sata_ctrl_base(struct brcm_sata_port *port)
default:
dev_err(priv->dev, "invalid phy version\n");
break;
- };
+ }
return priv->ctrl_base + (port->portnum * size);
}
@@ -365,7 +365,7 @@ static int brcm_sata_phy_init(struct phy *phy)
break;
default:
rc = -ENODEV;
- };
+ }
return rc;
}
diff --git a/drivers/phy/phy-exynos4210-usb2.c b/drivers/phy/phy-exynos4210-usb2.c
index f30bbb0..1f50e10 100644
--- a/drivers/phy/phy-exynos4210-usb2.c
+++ b/drivers/phy/phy-exynos4210-usb2.c
@@ -141,7 +141,7 @@ static void exynos4210_isol(struct samsung_usb2_phy_instance *inst, bool on)
break;
default:
return;
- };
+ }
regmap_update_bits(drv->reg_pmu, offset, mask, on ? 0 : mask);
}
@@ -179,7 +179,7 @@ static void exynos4210_phy_pwr(struct samsung_usb2_phy_instance *inst, bool on)
rstbits = EXYNOS_4210_URSTCON_PHY1_P1P2 |
EXYNOS_4210_URSTCON_HOST_LINK_P2;
break;
- };
+ }
if (on) {
clk = readl(drv->reg_phy + EXYNOS_4210_UPHYCLK);
diff --git a/drivers/phy/phy-exynos4x12-usb2.c b/drivers/phy/phy-exynos4x12-usb2.c
index 765da90..7f27a91 100644
--- a/drivers/phy/phy-exynos4x12-usb2.c
+++ b/drivers/phy/phy-exynos4x12-usb2.c
@@ -187,7 +187,7 @@ static void exynos4x12_isol(struct samsung_usb2_phy_instance *inst, bool on)
break;
default:
return;
- };
+ }
regmap_update_bits(drv->reg_pmu, offset, mask, on ? 0 : mask);
}
@@ -237,7 +237,7 @@ static void exynos4x12_phy_pwr(struct samsung_usb2_phy_instance *inst, bool on)
rstbits = EXYNOS_4x12_URSTCON_HSIC1 |
EXYNOS_4x12_URSTCON_HOST_LINK_P1;
break;
- };
+ }
if (on) {
pwr = readl(drv->reg_phy + EXYNOS_4x12_UPHYPWR);
diff --git a/drivers/phy/phy-exynos5250-usb2.c b/drivers/phy/phy-exynos5250-usb2.c
index 2ed1735..aad8062 100644
--- a/drivers/phy/phy-exynos5250-usb2.c
+++ b/drivers/phy/phy-exynos5250-usb2.c
@@ -192,7 +192,7 @@ static void exynos5250_isol(struct samsung_usb2_phy_instance *inst, bool on)
break;
default:
return;
- };
+ }
regmap_update_bits(drv->reg_pmu, offset, mask, on ? 0 : mask);
}
diff --git a/drivers/phy/phy-rockchip-emmc.c b/drivers/phy/phy-rockchip-emmc.c
index fd57345..f1b24f1 100644
--- a/drivers/phy/phy-rockchip-emmc.c
+++ b/drivers/phy/phy-rockchip-emmc.c
@@ -132,7 +132,7 @@ static int rockchip_emmc_phy_power(struct phy *phy, bool on_off)
default:
ideal_rate = 200000000;
break;
- };
+ }
diff = (rate > ideal_rate) ?
rate - ideal_rate : ideal_rate - rate;
diff --git a/drivers/phy/phy-s5pv210-usb2.c b/drivers/phy/phy-s5pv210-usb2.c
index 004d320..f6f7233 100644
--- a/drivers/phy/phy-s5pv210-usb2.c
+++ b/drivers/phy/phy-s5pv210-usb2.c
@@ -103,7 +103,7 @@ static void s5pv210_isol(struct samsung_usb2_phy_instance *inst, bool on)
break;
default:
return;
- };
+ }
regmap_update_bits(drv->reg_pmu, S5PV210_USB_ISOL_OFFSET,
mask, on ? 0 : mask);
@@ -127,7 +127,7 @@ static void s5pv210_phy_pwr(struct samsung_usb2_phy_instance *inst, bool on)
rstbits = S5PV210_URSTCON_PHY1_ALL |
S5PV210_URSTCON_HOST_LINK_ALL;
break;
- };
+ }
if (on) {
writel(drv->ref_reg_val, drv->reg_phy + S5PV210_UPHYCLK);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] phy: Fix ptr_ret.cocci warnings
2016-10-20 6:53 [PATCH 1/3] phy: fix semicolon.cocci warnings Vivek Gautam
@ 2016-10-20 6:53 ` Vivek Gautam
2016-10-20 6:53 ` [PATCH 3/3] phy: fix returnvar.cocci warnings Vivek Gautam
2016-11-08 10:53 ` [PATCH 1/3] phy: fix semicolon.cocci warnings Vivek Gautam
2 siblings, 0 replies; 6+ messages in thread
From: Vivek Gautam @ 2016-10-20 6:53 UTC (permalink / raw)
To: kishon
Cc: linux-kernel, linux-samsung-soc, linux-rockchip, linux-tegra,
Vivek Gautam
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/phy/phy-ti-pipe3.c | 10 ++--------
drivers/phy/tegra/xusb.c | 10 ++--------
2 files changed, 4 insertions(+), 16 deletions(-)
diff --git a/drivers/phy/phy-ti-pipe3.c b/drivers/phy/phy-ti-pipe3.c
index bf46844..9c84d32 100644
--- a/drivers/phy/phy-ti-pipe3.c
+++ b/drivers/phy/phy-ti-pipe3.c
@@ -537,10 +537,7 @@ static int ti_pipe3_get_pll_base(struct ti_pipe3 *phy)
res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
"pll_ctrl");
phy->pll_ctrl_base = devm_ioremap_resource(dev, res);
- if (IS_ERR(phy->pll_ctrl_base))
- return PTR_ERR(phy->pll_ctrl_base);
-
- return 0;
+ return PTR_ERR_OR_ZERO(phy->pll_ctrl_base);
}
static int ti_pipe3_probe(struct platform_device *pdev)
@@ -592,10 +589,7 @@ static int ti_pipe3_probe(struct platform_device *pdev)
ti_pipe3_power_off(generic_phy);
phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
- if (IS_ERR(phy_provider))
- return PTR_ERR(phy_provider);
-
- return 0;
+ return PTR_ERR_OR_ZERO(phy_provider);
}
static int ti_pipe3_remove(struct platform_device *pdev)
diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index 873424a..3cbcb25 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -561,10 +561,7 @@ static int tegra_xusb_usb2_port_parse_dt(struct tegra_xusb_usb2_port *usb2)
usb2->internal = of_property_read_bool(np, "nvidia,internal");
usb2->supply = devm_regulator_get(&port->dev, "vbus");
- if (IS_ERR(usb2->supply))
- return PTR_ERR(usb2->supply);
-
- return 0;
+ return PTR_ERR_OR_ZERO(usb2->supply);
}
static int tegra_xusb_add_usb2_port(struct tegra_xusb_padctl *padctl,
@@ -731,10 +728,7 @@ static int tegra_xusb_usb3_port_parse_dt(struct tegra_xusb_usb3_port *usb3)
usb3->internal = of_property_read_bool(np, "nvidia,internal");
usb3->supply = devm_regulator_get(&port->dev, "vbus");
- if (IS_ERR(usb3->supply))
- return PTR_ERR(usb3->supply);
-
- return 0;
+ return PTR_ERR_OR_ZERO(usb3->supply);
}
static int tegra_xusb_add_usb3_port(struct tegra_xusb_padctl *padctl,
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] phy: fix returnvar.cocci warnings
2016-10-20 6:53 [PATCH 1/3] phy: fix semicolon.cocci warnings Vivek Gautam
2016-10-20 6:53 ` [PATCH 2/3] phy: Fix ptr_ret.cocci warnings Vivek Gautam
@ 2016-10-20 6:53 ` Vivek Gautam
2016-11-08 10:53 ` [PATCH 1/3] phy: fix semicolon.cocci warnings Vivek Gautam
2 siblings, 0 replies; 6+ messages in thread
From: Vivek Gautam @ 2016-10-20 6:53 UTC (permalink / raw)
To: kishon
Cc: linux-kernel, linux-samsung-soc, linux-rockchip, linux-tegra,
Vivek Gautam
Remove unneeded variables when "0" can be returned.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/phy/phy-berlin-sata.c | 3 +--
drivers/phy/tegra/xusb-tegra124.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/phy/phy-berlin-sata.c b/drivers/phy/phy-berlin-sata.c
index f84a33a..2c7a57f 100644
--- a/drivers/phy/phy-berlin-sata.c
+++ b/drivers/phy/phy-berlin-sata.c
@@ -85,7 +85,6 @@ static int phy_berlin_sata_power_on(struct phy *phy)
struct phy_berlin_desc *desc = phy_get_drvdata(phy);
struct phy_berlin_priv *priv = dev_get_drvdata(phy->dev.parent);
void __iomem *ctrl_reg = priv->base + 0x60 + (desc->index * 0x80);
- int ret = 0;
u32 regval;
clk_prepare_enable(priv->clk);
@@ -130,7 +129,7 @@ static int phy_berlin_sata_power_on(struct phy *phy)
clk_disable_unprepare(priv->clk);
- return ret;
+ return 0;
}
static int phy_berlin_sata_power_off(struct phy *phy)
diff --git a/drivers/phy/tegra/xusb-tegra124.c b/drivers/phy/tegra/xusb-tegra124.c
index 1199572..c45cbed 100644
--- a/drivers/phy/tegra/xusb-tegra124.c
+++ b/drivers/phy/tegra/xusb-tegra124.c
@@ -1483,7 +1483,6 @@ static int tegra124_usb3_port_enable(struct tegra_xusb_port *port)
struct tegra_xusb_padctl *padctl = port->padctl;
struct tegra_xusb_lane *lane = usb3->base.lane;
unsigned int index = port->index, offset;
- int ret = 0;
u32 value;
value = padctl_readl(padctl, XUSB_PADCTL_SS_PORT_MAP);
@@ -1612,7 +1611,7 @@ static int tegra124_usb3_port_enable(struct tegra_xusb_port *port)
value &= ~XUSB_PADCTL_ELPG_PROGRAM_SSPX_ELPG_CLAMP_EN(index);
padctl_writel(padctl, value, XUSB_PADCTL_ELPG_PROGRAM);
- return ret;
+ return 0;
}
static void tegra124_usb3_port_disable(struct tegra_xusb_port *port)
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] phy: fix semicolon.cocci warnings
2016-10-20 6:53 [PATCH 1/3] phy: fix semicolon.cocci warnings Vivek Gautam
2016-10-20 6:53 ` [PATCH 2/3] phy: Fix ptr_ret.cocci warnings Vivek Gautam
2016-10-20 6:53 ` [PATCH 3/3] phy: fix returnvar.cocci warnings Vivek Gautam
@ 2016-11-08 10:53 ` Vivek Gautam
2016-11-15 13:36 ` Kishon Vijay Abraham I
2 siblings, 1 reply; 6+ messages in thread
From: Vivek Gautam @ 2016-11-08 10:53 UTC (permalink / raw)
To: kishon
Cc: linux-kernel, linux-samsung-soc, linux-rockchip, linux-tegra,
Vivek Gautam
Hi Kishon,
On Thu, Oct 20, 2016 at 12:23 PM, Vivek Gautam
<vivek.gautam@codeaurora.org> wrote:
> Remove unneeded semicolon.
>
> Generated by: coccinellery/semicolon/semicolon.cocci
>
> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> ---
Gentle ping.
Do you plan to pull in 3 patches in this series ?
> drivers/phy/phy-brcm-sata.c | 6 +++---
> drivers/phy/phy-exynos4210-usb2.c | 4 ++--
> drivers/phy/phy-exynos4x12-usb2.c | 4 ++--
> drivers/phy/phy-exynos5250-usb2.c | 2 +-
> drivers/phy/phy-rockchip-emmc.c | 2 +-
> drivers/phy/phy-s5pv210-usb2.c | 4 ++--
> 6 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/phy/phy-brcm-sata.c b/drivers/phy/phy-brcm-sata.c
> index 8ffc44a..ccbc3d9 100644
> --- a/drivers/phy/phy-brcm-sata.c
> +++ b/drivers/phy/phy-brcm-sata.c
> @@ -140,7 +140,7 @@ static inline void __iomem *brcm_sata_pcb_base(struct brcm_sata_port *port)
> default:
> dev_err(priv->dev, "invalid phy version\n");
> break;
> - };
> + }
>
> return priv->phy_base + (port->portnum * size);
> }
> @@ -157,7 +157,7 @@ static inline void __iomem *brcm_sata_ctrl_base(struct brcm_sata_port *port)
> default:
> dev_err(priv->dev, "invalid phy version\n");
> break;
> - };
> + }
>
> return priv->ctrl_base + (port->portnum * size);
> }
> @@ -365,7 +365,7 @@ static int brcm_sata_phy_init(struct phy *phy)
> break;
> default:
> rc = -ENODEV;
> - };
> + }
>
> return rc;
> }
> diff --git a/drivers/phy/phy-exynos4210-usb2.c b/drivers/phy/phy-exynos4210-usb2.c
> index f30bbb0..1f50e10 100644
> --- a/drivers/phy/phy-exynos4210-usb2.c
> +++ b/drivers/phy/phy-exynos4210-usb2.c
> @@ -141,7 +141,7 @@ static void exynos4210_isol(struct samsung_usb2_phy_instance *inst, bool on)
> break;
> default:
> return;
> - };
> + }
>
> regmap_update_bits(drv->reg_pmu, offset, mask, on ? 0 : mask);
> }
> @@ -179,7 +179,7 @@ static void exynos4210_phy_pwr(struct samsung_usb2_phy_instance *inst, bool on)
> rstbits = EXYNOS_4210_URSTCON_PHY1_P1P2 |
> EXYNOS_4210_URSTCON_HOST_LINK_P2;
> break;
> - };
> + }
>
> if (on) {
> clk = readl(drv->reg_phy + EXYNOS_4210_UPHYCLK);
> diff --git a/drivers/phy/phy-exynos4x12-usb2.c b/drivers/phy/phy-exynos4x12-usb2.c
> index 765da90..7f27a91 100644
> --- a/drivers/phy/phy-exynos4x12-usb2.c
> +++ b/drivers/phy/phy-exynos4x12-usb2.c
> @@ -187,7 +187,7 @@ static void exynos4x12_isol(struct samsung_usb2_phy_instance *inst, bool on)
> break;
> default:
> return;
> - };
> + }
>
> regmap_update_bits(drv->reg_pmu, offset, mask, on ? 0 : mask);
> }
> @@ -237,7 +237,7 @@ static void exynos4x12_phy_pwr(struct samsung_usb2_phy_instance *inst, bool on)
> rstbits = EXYNOS_4x12_URSTCON_HSIC1 |
> EXYNOS_4x12_URSTCON_HOST_LINK_P1;
> break;
> - };
> + }
>
> if (on) {
> pwr = readl(drv->reg_phy + EXYNOS_4x12_UPHYPWR);
> diff --git a/drivers/phy/phy-exynos5250-usb2.c b/drivers/phy/phy-exynos5250-usb2.c
> index 2ed1735..aad8062 100644
> --- a/drivers/phy/phy-exynos5250-usb2.c
> +++ b/drivers/phy/phy-exynos5250-usb2.c
> @@ -192,7 +192,7 @@ static void exynos5250_isol(struct samsung_usb2_phy_instance *inst, bool on)
> break;
> default:
> return;
> - };
> + }
>
> regmap_update_bits(drv->reg_pmu, offset, mask, on ? 0 : mask);
> }
> diff --git a/drivers/phy/phy-rockchip-emmc.c b/drivers/phy/phy-rockchip-emmc.c
> index fd57345..f1b24f1 100644
> --- a/drivers/phy/phy-rockchip-emmc.c
> +++ b/drivers/phy/phy-rockchip-emmc.c
> @@ -132,7 +132,7 @@ static int rockchip_emmc_phy_power(struct phy *phy, bool on_off)
> default:
> ideal_rate = 200000000;
> break;
> - };
> + }
>
> diff = (rate > ideal_rate) ?
> rate - ideal_rate : ideal_rate - rate;
> diff --git a/drivers/phy/phy-s5pv210-usb2.c b/drivers/phy/phy-s5pv210-usb2.c
> index 004d320..f6f7233 100644
> --- a/drivers/phy/phy-s5pv210-usb2.c
> +++ b/drivers/phy/phy-s5pv210-usb2.c
> @@ -103,7 +103,7 @@ static void s5pv210_isol(struct samsung_usb2_phy_instance *inst, bool on)
> break;
> default:
> return;
> - };
> + }
>
> regmap_update_bits(drv->reg_pmu, S5PV210_USB_ISOL_OFFSET,
> mask, on ? 0 : mask);
> @@ -127,7 +127,7 @@ static void s5pv210_phy_pwr(struct samsung_usb2_phy_instance *inst, bool on)
> rstbits = S5PV210_URSTCON_PHY1_ALL |
> S5PV210_URSTCON_HOST_LINK_ALL;
> break;
> - };
> + }
>
> if (on) {
> writel(drv->ref_reg_val, drv->reg_phy + S5PV210_UPHYCLK);
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] phy: fix semicolon.cocci warnings
2016-11-08 10:53 ` [PATCH 1/3] phy: fix semicolon.cocci warnings Vivek Gautam
@ 2016-11-15 13:36 ` Kishon Vijay Abraham I
2016-11-15 14:07 ` Vivek Gautam
0 siblings, 1 reply; 6+ messages in thread
From: Kishon Vijay Abraham I @ 2016-11-15 13:36 UTC (permalink / raw)
To: Vivek Gautam; +Cc: linux-kernel, linux-samsung-soc, linux-rockchip, linux-tegra
On Tuesday 08 November 2016 04:23 PM, Vivek Gautam wrote:
> Hi Kishon,
>
> On Thu, Oct 20, 2016 at 12:23 PM, Vivek Gautam
> <vivek.gautam@codeaurora.org> wrote:
>> Remove unneeded semicolon.
>>
>> Generated by: coccinellery/semicolon/semicolon.cocci
>>
>> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
>> Cc: Kishon Vijay Abraham I <kishon@ti.com>
>> ---
>
> Gentle ping.
> Do you plan to pull in 3 patches in this series ?
merged now.
Thanks
Kishon
>
>> drivers/phy/phy-brcm-sata.c | 6 +++---
>> drivers/phy/phy-exynos4210-usb2.c | 4 ++--
>> drivers/phy/phy-exynos4x12-usb2.c | 4 ++--
>> drivers/phy/phy-exynos5250-usb2.c | 2 +-
>> drivers/phy/phy-rockchip-emmc.c | 2 +-
>> drivers/phy/phy-s5pv210-usb2.c | 4 ++--
>> 6 files changed, 11 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/phy/phy-brcm-sata.c b/drivers/phy/phy-brcm-sata.c
>> index 8ffc44a..ccbc3d9 100644
>> --- a/drivers/phy/phy-brcm-sata.c
>> +++ b/drivers/phy/phy-brcm-sata.c
>> @@ -140,7 +140,7 @@ static inline void __iomem *brcm_sata_pcb_base(struct brcm_sata_port *port)
>> default:
>> dev_err(priv->dev, "invalid phy version\n");
>> break;
>> - };
>> + }
>>
>> return priv->phy_base + (port->portnum * size);
>> }
>> @@ -157,7 +157,7 @@ static inline void __iomem *brcm_sata_ctrl_base(struct brcm_sata_port *port)
>> default:
>> dev_err(priv->dev, "invalid phy version\n");
>> break;
>> - };
>> + }
>>
>> return priv->ctrl_base + (port->portnum * size);
>> }
>> @@ -365,7 +365,7 @@ static int brcm_sata_phy_init(struct phy *phy)
>> break;
>> default:
>> rc = -ENODEV;
>> - };
>> + }
>>
>> return rc;
>> }
>> diff --git a/drivers/phy/phy-exynos4210-usb2.c b/drivers/phy/phy-exynos4210-usb2.c
>> index f30bbb0..1f50e10 100644
>> --- a/drivers/phy/phy-exynos4210-usb2.c
>> +++ b/drivers/phy/phy-exynos4210-usb2.c
>> @@ -141,7 +141,7 @@ static void exynos4210_isol(struct samsung_usb2_phy_instance *inst, bool on)
>> break;
>> default:
>> return;
>> - };
>> + }
>>
>> regmap_update_bits(drv->reg_pmu, offset, mask, on ? 0 : mask);
>> }
>> @@ -179,7 +179,7 @@ static void exynos4210_phy_pwr(struct samsung_usb2_phy_instance *inst, bool on)
>> rstbits = EXYNOS_4210_URSTCON_PHY1_P1P2 |
>> EXYNOS_4210_URSTCON_HOST_LINK_P2;
>> break;
>> - };
>> + }
>>
>> if (on) {
>> clk = readl(drv->reg_phy + EXYNOS_4210_UPHYCLK);
>> diff --git a/drivers/phy/phy-exynos4x12-usb2.c b/drivers/phy/phy-exynos4x12-usb2.c
>> index 765da90..7f27a91 100644
>> --- a/drivers/phy/phy-exynos4x12-usb2.c
>> +++ b/drivers/phy/phy-exynos4x12-usb2.c
>> @@ -187,7 +187,7 @@ static void exynos4x12_isol(struct samsung_usb2_phy_instance *inst, bool on)
>> break;
>> default:
>> return;
>> - };
>> + }
>>
>> regmap_update_bits(drv->reg_pmu, offset, mask, on ? 0 : mask);
>> }
>> @@ -237,7 +237,7 @@ static void exynos4x12_phy_pwr(struct samsung_usb2_phy_instance *inst, bool on)
>> rstbits = EXYNOS_4x12_URSTCON_HSIC1 |
>> EXYNOS_4x12_URSTCON_HOST_LINK_P1;
>> break;
>> - };
>> + }
>>
>> if (on) {
>> pwr = readl(drv->reg_phy + EXYNOS_4x12_UPHYPWR);
>> diff --git a/drivers/phy/phy-exynos5250-usb2.c b/drivers/phy/phy-exynos5250-usb2.c
>> index 2ed1735..aad8062 100644
>> --- a/drivers/phy/phy-exynos5250-usb2.c
>> +++ b/drivers/phy/phy-exynos5250-usb2.c
>> @@ -192,7 +192,7 @@ static void exynos5250_isol(struct samsung_usb2_phy_instance *inst, bool on)
>> break;
>> default:
>> return;
>> - };
>> + }
>>
>> regmap_update_bits(drv->reg_pmu, offset, mask, on ? 0 : mask);
>> }
>> diff --git a/drivers/phy/phy-rockchip-emmc.c b/drivers/phy/phy-rockchip-emmc.c
>> index fd57345..f1b24f1 100644
>> --- a/drivers/phy/phy-rockchip-emmc.c
>> +++ b/drivers/phy/phy-rockchip-emmc.c
>> @@ -132,7 +132,7 @@ static int rockchip_emmc_phy_power(struct phy *phy, bool on_off)
>> default:
>> ideal_rate = 200000000;
>> break;
>> - };
>> + }
>>
>> diff = (rate > ideal_rate) ?
>> rate - ideal_rate : ideal_rate - rate;
>> diff --git a/drivers/phy/phy-s5pv210-usb2.c b/drivers/phy/phy-s5pv210-usb2.c
>> index 004d320..f6f7233 100644
>> --- a/drivers/phy/phy-s5pv210-usb2.c
>> +++ b/drivers/phy/phy-s5pv210-usb2.c
>> @@ -103,7 +103,7 @@ static void s5pv210_isol(struct samsung_usb2_phy_instance *inst, bool on)
>> break;
>> default:
>> return;
>> - };
>> + }
>>
>> regmap_update_bits(drv->reg_pmu, S5PV210_USB_ISOL_OFFSET,
>> mask, on ? 0 : mask);
>> @@ -127,7 +127,7 @@ static void s5pv210_phy_pwr(struct samsung_usb2_phy_instance *inst, bool on)
>> rstbits = S5PV210_URSTCON_PHY1_ALL |
>> S5PV210_URSTCON_HOST_LINK_ALL;
>> break;
>> - };
>> + }
>>
>> if (on) {
>> writel(drv->ref_reg_val, drv->reg_phy + S5PV210_UPHYCLK);
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>> a Linux Foundation Collaborative Project
>>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] phy: fix semicolon.cocci warnings
2016-11-15 13:36 ` Kishon Vijay Abraham I
@ 2016-11-15 14:07 ` Vivek Gautam
0 siblings, 0 replies; 6+ messages in thread
From: Vivek Gautam @ 2016-11-15 14:07 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: linux-kernel, linux-samsung-soc, linux-rockchip, linux-tegra
On Tue, Nov 15, 2016 at 7:06 PM, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>
> On Tuesday 08 November 2016 04:23 PM, Vivek Gautam wrote:
>> Hi Kishon,
>>
>> On Thu, Oct 20, 2016 at 12:23 PM, Vivek Gautam
>> <vivek.gautam@codeaurora.org> wrote:
>>> Remove unneeded semicolon.
>>>
>>> Generated by: coccinellery/semicolon/semicolon.cocci
>>>
>>> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
>>> Cc: Kishon Vijay Abraham I <kishon@ti.com>
>>> ---
>>
>> Gentle ping.
>> Do you plan to pull in 3 patches in this series ?
>
> merged now.
Thanks Kishon.
Regards
Vivek
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-11-15 14:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-20 6:53 [PATCH 1/3] phy: fix semicolon.cocci warnings Vivek Gautam
2016-10-20 6:53 ` [PATCH 2/3] phy: Fix ptr_ret.cocci warnings Vivek Gautam
2016-10-20 6:53 ` [PATCH 3/3] phy: fix returnvar.cocci warnings Vivek Gautam
2016-11-08 10:53 ` [PATCH 1/3] phy: fix semicolon.cocci warnings Vivek Gautam
2016-11-15 13:36 ` Kishon Vijay Abraham I
2016-11-15 14:07 ` Vivek Gautam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).