linux-next: Fixes tag needs some work in the chrome-platform tree

linux-next: Fixes tag needs some work in the chrome-platform tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 397 bytes --]

Hi all,

In commit

  5ca22c7cae55 ("iio: cros_ec: Use Hertz as unit for sampling frequency")

Fixes tag

  Fixes: ae7b02ad2f32 ("iio: common: cros_ec_sensors: Expose

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the chrome-platform tree

[Enric Balletbo Serra]

Hi Stephen,

Missatge de Stephen Rothwell <sfr@canb.auug.org.au> del dia dl., 30 de
març 2020 a les 0:18:
>
> Hi all,
>
> In commit
>
>   5ca22c7cae55 ("iio: cros_ec: Use Hertz as unit for sampling frequency")
>
> Fixes tag
>
>   Fixes: ae7b02ad2f32 ("iio: common: cros_ec_sensors: Expose
>
> has these problem(s):
>
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than one line.
>

Thanks for the report, fixed.

Cheers,
Enric

> --
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the chrome-platform tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

Hi all,

In commit

  4c288c88d016 ("platform: chrome: Split trace include file")

Fixes tag

  Fixes: d453ceb65 ("platform/chrome: sensorhub: Add trace events for sample")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the chrome-platform tree

[Benson Leung]

[-- Attachment #1: Type: text/plain, Size: 847 bytes --]

Hi Stephen,

On Tue, Aug 31, 2021 at 10:39:06AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   cf7f3ebb41d8 ("platform/chrome: cros_ec_trace: Fix format warnings")
> 
> Fixes tag
> 
>   Fixes: 814318242 ("platform/chrome: cros_ec_trace: Add fields to command traces")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
> 
> -- 
> Cheers,
> Stephen Rothwell

Sorry about all the churn. One last time, my for-next has been updated:
  4665584888ad ("platform/chrome: cros_ec_trace: Fix format warnings")

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

linux-next: Fixes tag needs some work in the chrome-platform tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

Hi all,

In commit

  cf7f3ebb41d8 ("platform/chrome: cros_ec_trace: Fix format warnings")

Fixes tag

  Fixes: 814318242 ("platform/chrome: cros_ec_trace: Add fields to command traces")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]