[PATCH] ntp: Allow TAI-UTC offset to be set to zero

* [PATCH] ntp: Allow TAI-UTC offset to be set to zero
@ 2019-04-17  8:48 Miroslav Lichvar
  2019-04-17  9:00 ` Ondrej Mosnacek
  2019-05-09  8:52 ` [tip:timers/urgent] " tip-bot for Miroslav Lichvar
  0 siblings, 2 replies; 6+ messages in thread
From: Miroslav Lichvar @ 2019-04-17  8:48 UTC (permalink / raw)
  To: linux-kernel
  Cc: Ondrej Mosnacek, Miroslav Lichvar, Thomas Gleixner, John Stultz,
	Richard Cochran, Prarit Bhargava

The ADJ_TAI adjtimex mode sets the TAI-UTC offset of the system clock.
It is typically set by NTP/PTP implementations and it is automatically
updated by the kernel on leap seconds. The initial value is zero (which
applications may interpret as unknown), but this value cannot be set by
adjtimex. This limitation seems to go back to the original "nanokernel"
implementation by David Mills.

Change the ADJ_TAI check to accept zero as a valid TAI-UTC offset in
order to allow setting it back to the initial value.

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Richard Cochran <richardcochran@gmail.com>
Cc: Prarit Bhargava <prarit@redhat.com>
Suggested-by: Ondrej Mosnacek <omosnace@redhat.com>
Signed-off-by: Miroslav Lichvar <mlichvar@redhat.com>
---
 kernel/time/ntp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/ntp.c b/kernel/time/ntp.c
index 92a90014a925..f43d47c8c3b6 100644
--- a/kernel/time/ntp.c
+++ b/kernel/time/ntp.c
@@ -690,7 +690,7 @@ static inline void process_adjtimex_modes(const struct __kernel_timex *txc,
 		time_constant = max(time_constant, 0l);
 	}
 
-	if (txc->modes & ADJ_TAI && txc->constant > 0)
+	if (txc->modes & ADJ_TAI && txc->constant >= 0)
 		*time_tai = txc->constant;
 
 	if (txc->modes & ADJ_OFFSET)
-- 
2.17.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread