* [PATCH] scsi/pmcraid.c: Use dma_pool_zalloc
@ 2018-10-02 5:26 Souptick Joarder
2018-10-08 16:28 ` Souptick Joarder
0 siblings, 1 reply; 4+ messages in thread
From: Souptick Joarder @ 2018-10-02 5:26 UTC (permalink / raw)
To: jejb, martin.petersen, sabyasachi.linux; +Cc: linux-scsi, linux-kernel
Replaced dma_pool_alloc + memset with dma_pool_zalloc.
Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
drivers/scsi/pmcraid.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 4e86994..84a2734 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -4681,7 +4681,7 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
for (i = 0; i < PMCRAID_MAX_CMD; i++) {
pinstance->cmd_list[i]->ioa_cb =
- dma_pool_alloc(
+ dma_pool_zalloc(
pinstance->control_pool,
GFP_KERNEL,
&(pinstance->cmd_list[i]->ioa_cb_bus_addr));
@@ -4690,8 +4690,6 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
pmcraid_release_control_blocks(pinstance, i);
return -ENOMEM;
}
- memset(pinstance->cmd_list[i]->ioa_cb, 0,
- sizeof(struct pmcraid_control_block));
}
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi/pmcraid.c: Use dma_pool_zalloc
2018-10-02 5:26 [PATCH] scsi/pmcraid.c: Use dma_pool_zalloc Souptick Joarder
@ 2018-10-08 16:28 ` Souptick Joarder
2018-10-24 3:36 ` Souptick Joarder
0 siblings, 1 reply; 4+ messages in thread
From: Souptick Joarder @ 2018-10-08 16:28 UTC (permalink / raw)
To: James Bottomley, Martin K. Petersen, Sabyasachi Gupta
Cc: linux-scsi, linux-kernel
On Tue, Oct 2, 2018 at 10:53 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> Replaced dma_pool_alloc + memset with dma_pool_zalloc.
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Any comment on this patch ?
> ---
> drivers/scsi/pmcraid.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
> index 4e86994..84a2734 100644
> --- a/drivers/scsi/pmcraid.c
> +++ b/drivers/scsi/pmcraid.c
> @@ -4681,7 +4681,7 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
>
> for (i = 0; i < PMCRAID_MAX_CMD; i++) {
> pinstance->cmd_list[i]->ioa_cb =
> - dma_pool_alloc(
> + dma_pool_zalloc(
> pinstance->control_pool,
> GFP_KERNEL,
> &(pinstance->cmd_list[i]->ioa_cb_bus_addr));
> @@ -4690,8 +4690,6 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
> pmcraid_release_control_blocks(pinstance, i);
> return -ENOMEM;
> }
> - memset(pinstance->cmd_list[i]->ioa_cb, 0,
> - sizeof(struct pmcraid_control_block));
> }
> return 0;
> }
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi/pmcraid.c: Use dma_pool_zalloc
2018-10-08 16:28 ` Souptick Joarder
@ 2018-10-24 3:36 ` Souptick Joarder
0 siblings, 0 replies; 4+ messages in thread
From: Souptick Joarder @ 2018-10-24 3:36 UTC (permalink / raw)
To: James Bottomley, Martin K. Petersen, Sabyasachi Gupta
Cc: linux-scsi, linux-kernel
On Mon, Oct 8, 2018 at 9:58 PM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> On Tue, Oct 2, 2018 at 10:53 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
> >
> > Replaced dma_pool_alloc + memset with dma_pool_zalloc.
> >
> > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>
> Any comment on this patch ?
Any comment on this patch ?
>
> > ---
> > drivers/scsi/pmcraid.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
> > index 4e86994..84a2734 100644
> > --- a/drivers/scsi/pmcraid.c
> > +++ b/drivers/scsi/pmcraid.c
> > @@ -4681,7 +4681,7 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
> >
> > for (i = 0; i < PMCRAID_MAX_CMD; i++) {
> > pinstance->cmd_list[i]->ioa_cb =
> > - dma_pool_alloc(
> > + dma_pool_zalloc(
> > pinstance->control_pool,
> > GFP_KERNEL,
> > &(pinstance->cmd_list[i]->ioa_cb_bus_addr));
> > @@ -4690,8 +4690,6 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
> > pmcraid_release_control_blocks(pinstance, i);
> > return -ENOMEM;
> > }
> > - memset(pinstance->cmd_list[i]->ioa_cb, 0,
> > - sizeof(struct pmcraid_control_block));
> > }
> > return 0;
> > }
> > --
> > 1.9.1
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] scsi/pmcraid.c: Use dma_pool_zalloc
@ 2018-12-02 7:31 Souptick Joarder
0 siblings, 0 replies; 4+ messages in thread
From: Souptick Joarder @ 2018-12-02 7:31 UTC (permalink / raw)
To: akpm; +Cc: jejb, martin.petersen, sabyasachi.linux, linux-scsi, linux-kernel
Replaced dma_pool_alloc + memset with dma_pool_zalloc.
Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
drivers/scsi/pmcraid.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 4e86994..84a2734 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -4681,7 +4681,7 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
for (i = 0; i < PMCRAID_MAX_CMD; i++) {
pinstance->cmd_list[i]->ioa_cb =
- dma_pool_alloc(
+ dma_pool_zalloc(
pinstance->control_pool,
GFP_KERNEL,
&(pinstance->cmd_list[i]->ioa_cb_bus_addr));
@@ -4690,8 +4690,6 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
pmcraid_release_control_blocks(pinstance, i);
return -ENOMEM;
}
- memset(pinstance->cmd_list[i]->ioa_cb, 0,
- sizeof(struct pmcraid_control_block));
}
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-02 7:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-02 5:26 [PATCH] scsi/pmcraid.c: Use dma_pool_zalloc Souptick Joarder
2018-10-08 16:28 ` Souptick Joarder
2018-10-24 3:36 ` Souptick Joarder
2018-12-02 7:31 Souptick Joarder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).