linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/3] ARM: mstar: Initial Miyoo Mini support
@ 2021-12-16 10:52 Daniel Palmer
  2021-12-16 10:52 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add prefix for Miyoo Daniel Palmer
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Daniel Palmer @ 2021-12-16 10:52 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, robh+dt
  Cc: linux-kernel, romain.perier, Daniel Palmer

Add a few device tree bits to support the Miyoo Mini
which is retro emulation device based on the SigmaStar
SSD202D.

http://linux-chenxing.org/infinity2/miyoomini/

Changes since v1/Notes:
  - Fix the commit to add miyoo vendor prefix.
  - I've left the link tags as-is as using them for linking
    to background info seems acceptable.

Daniel Palmer (3):
  dt-bindings: vendor-prefixes: Add prefix for Miyoo
  dt-bindings: arm: mstar: Add compatible for Miyoo Mini
  ARM: dts: mstar: Add a dts for Miyoo Mini

 .../devicetree/bindings/arm/mstar/mstar.yaml  |  1 +
 .../devicetree/bindings/vendor-prefixes.yaml  |  2 ++
 arch/arm/boot/dts/Makefile                    |  1 +
 .../mstar-infinity2m-ssd202d-miyoo-mini.dts   | 25 +++++++++++++++++++
 4 files changed, 29 insertions(+)
 create mode 100644 arch/arm/boot/dts/mstar-infinity2m-ssd202d-miyoo-mini.dts

-- 
2.34.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add prefix for Miyoo
  2021-12-16 10:52 [PATCH v2 0/3] ARM: mstar: Initial Miyoo Mini support Daniel Palmer
@ 2021-12-16 10:52 ` Daniel Palmer
  2021-12-16 20:54   ` Rob Herring
  2021-12-16 10:52 ` [PATCH v2 2/3] dt-bindings: arm: mstar: Add compatible for Miyoo Mini Daniel Palmer
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 8+ messages in thread
From: Daniel Palmer @ 2021-12-16 10:52 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, robh+dt
  Cc: linux-kernel, romain.perier, Daniel Palmer

Add a prefix for "miyoo". The only details I can find about
the company is their aliexpress store "miyoo global store":
https://www.aliexpress.com/store/912663639

Signed-off-by: Daniel Palmer <daniel@0x0f.com>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 66d6432fd781..3fe6117eac42 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -757,6 +757,8 @@ patternProperties:
     description: MiraMEMS Sensing Technology Co., Ltd.
   "^mitsubishi,.*":
     description: Mitsubishi Electric Corporation
+  "^miyoo,.*":
+    description: Miyoo
   "^mntre,.*":
     description: MNT Research GmbH
   "^modtronix,.*":
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v2 2/3] dt-bindings: arm: mstar: Add compatible for Miyoo Mini
  2021-12-16 10:52 [PATCH v2 0/3] ARM: mstar: Initial Miyoo Mini support Daniel Palmer
  2021-12-16 10:52 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add prefix for Miyoo Daniel Palmer
@ 2021-12-16 10:52 ` Daniel Palmer
  2021-12-16 10:52 ` [PATCH v2 3/3] ARM: dts: mstar: Add a dts " Daniel Palmer
       [not found] ` <CABgxDoKJRc_qORcpFx=eNPS=bGV68hPrbeH0VtcQ2Jjx2ruqmg@mail.gmail.com>
  3 siblings, 0 replies; 8+ messages in thread
From: Daniel Palmer @ 2021-12-16 10:52 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, robh+dt
  Cc: linux-kernel, romain.perier, Daniel Palmer, Rob Herring

The Miyoo Mini is a SigmaStar SSD202D based retro emulation
device.

Add a compatible for it to the list of infinity2m devices.

Signed-off-by: Daniel Palmer <daniel@0x0f.com>
Link: http://linux-chenxing.org/infinity2/miyoomini/
Acked-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/arm/mstar/mstar.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/mstar/mstar.yaml b/Documentation/devicetree/bindings/arm/mstar/mstar.yaml
index a316eef1b728..8e1a0e99a60b 100644
--- a/Documentation/devicetree/bindings/arm/mstar/mstar.yaml
+++ b/Documentation/devicetree/bindings/arm/mstar/mstar.yaml
@@ -25,6 +25,7 @@ properties:
           - enum:
               - honestar,ssd201htv2 # Honestar SSD201_HT_V2 devkit
               - m5stack,unitv2 # M5Stack UnitV2
+              - miyoo,miyoo-mini # Miyoo Mini
           - const: mstar,infinity2m
 
       - description: infinity3 boards
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v2 3/3] ARM: dts: mstar: Add a dts for Miyoo Mini
  2021-12-16 10:52 [PATCH v2 0/3] ARM: mstar: Initial Miyoo Mini support Daniel Palmer
  2021-12-16 10:52 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add prefix for Miyoo Daniel Palmer
  2021-12-16 10:52 ` [PATCH v2 2/3] dt-bindings: arm: mstar: Add compatible for Miyoo Mini Daniel Palmer
@ 2021-12-16 10:52 ` Daniel Palmer
       [not found] ` <CABgxDoKJRc_qORcpFx=eNPS=bGV68hPrbeH0VtcQ2Jjx2ruqmg@mail.gmail.com>
  3 siblings, 0 replies; 8+ messages in thread
From: Daniel Palmer @ 2021-12-16 10:52 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, robh+dt
  Cc: linux-kernel, romain.perier, Daniel Palmer

Miyoo has released a portable retro games machine based
on the SigmaStar SSD202D. Add the initial device tree
for this machine. Just enough to get to an initramfs
shell.

Signed-off-by: Daniel Palmer <daniel@0x0f.com>
Link: http://linux-chenxing.org/infinity2/miyoomini/
---
 arch/arm/boot/dts/Makefile                    |  1 +
 .../mstar-infinity2m-ssd202d-miyoo-mini.dts   | 25 +++++++++++++++++++
 2 files changed, 26 insertions(+)
 create mode 100644 arch/arm/boot/dts/mstar-infinity2m-ssd202d-miyoo-mini.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 0de64f237cd8..b270a4d8e0d6 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -1468,6 +1468,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += \
 dtb-$(CONFIG_ARCH_MILBEAUT) += milbeaut-m10v-evb.dtb
 dtb-$(CONFIG_ARCH_MSTARV7) += \
 	mstar-infinity-msc313-breadbee_crust.dtb \
+	mstar-infinity2m-ssd202d-miyoo-mini.dtb \
 	mstar-infinity2m-ssd202d-ssd201htv2.dtb \
 	mstar-infinity2m-ssd202d-unitv2.dtb \
 	mstar-infinity3-msc313e-breadbee.dtb \
diff --git a/arch/arm/boot/dts/mstar-infinity2m-ssd202d-miyoo-mini.dts b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-miyoo-mini.dts
new file mode 100644
index 000000000000..1bbbf47132dc
--- /dev/null
+++ b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-miyoo-mini.dts
@@ -0,0 +1,25 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2021 thingy.jp.
+ * Author: Daniel Palmer <daniel@thingy.jp>
+ */
+
+/dts-v1/;
+#include "mstar-infinity2m-ssd202d.dtsi"
+
+/ {
+	model = "Miyoo Mini";
+	compatible = "miyoo,miyoo-mini", "mstar,infinity2m";
+
+	aliases {
+		serial0 = &pm_uart;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+};
+
+&pm_uart {
+	status = "okay";
+};
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 0/3] ARM: mstar: Initial Miyoo Mini support
       [not found] ` <CABgxDoKJRc_qORcpFx=eNPS=bGV68hPrbeH0VtcQ2Jjx2ruqmg@mail.gmail.com>
@ 2021-12-16 16:18   ` Daniel Palmer
  2021-12-16 17:34     ` Romain Perier
  0 siblings, 1 reply; 8+ messages in thread
From: Daniel Palmer @ 2021-12-16 16:18 UTC (permalink / raw)
  To: Romain Perier
  Cc: devicetree, linux-arm-kernel, Rob Herring, Linux Kernel Mailing List

Hi Romain,

On Fri, 17 Dec 2021 at 00:53, Romain Perier <romain.perier@gmail.com> wrote:
>
> Hi Daniel,
>
> Le jeu. 16 déc. 2021 à 11:52, Daniel Palmer <daniel@0x0f.com> a écrit :
>>
>>   - I've left the link tags as-is as using them for linking
>>     to background info seems acceptable.
>
>
> https://www.kernel.org/doc/html/latest/maintainer/configure-git.html#creating-commit-links-to-lore-kernel-org

The explanation of Link seem to have been updated recently in
1f57bd42b77cdc4b8e05ba9f4417872a6691b66d
(https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
a few paragraphs down).

My reading of the paragraph since that commit is: Explain what the
commit does in the commit message. If there is a bug that prompted the
change then link it. If there is some background for the commit then
link it.

If it needs to be changed around I'll do that but I personally think
it looks nicer. It seems like the right way to provide links to
datasheets etc without putting a bunch of long messy urls into the
commit message.

Cheers,

Daniel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 0/3] ARM: mstar: Initial Miyoo Mini support
  2021-12-16 16:18   ` [PATCH v2 0/3] ARM: mstar: Initial Miyoo Mini support Daniel Palmer
@ 2021-12-16 17:34     ` Romain Perier
  2021-12-16 17:48       ` Daniel Palmer
  0 siblings, 1 reply; 8+ messages in thread
From: Romain Perier @ 2021-12-16 17:34 UTC (permalink / raw)
  To: Daniel Palmer
  Cc: devicetree, linux-arm-kernel, Rob Herring, Linux Kernel Mailing List

Hi Daniel,


Le jeu. 16 déc. 2021 à 17:15, Daniel Palmer <daniel@0x0f.com> a écrit :
>
> Hi Romain,
>
> On Fri, 17 Dec 2021 at 00:53, Romain Perier <romain.perier@gmail.com> wrote:
> >
> > Hi Daniel,
> >
> > Le jeu. 16 déc. 2021 à 11:52, Daniel Palmer <daniel@0x0f.com> a écrit :
> >>
> >>   - I've left the link tags as-is as using them for linking
> >>     to background info seems acceptable.
> >
> >
> > https://www.kernel.org/doc/html/latest/maintainer/configure-git.html#creating-commit-links-to-lore-kernel-org
>
> The explanation of Link seem to have been updated recently in
> 1f57bd42b77cdc4b8e05ba9f4417872a6691b66d
> (https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
> a few paragraphs down).
>
> My reading of the paragraph since that commit is: Explain what the
> commit does in the commit message. If there is a bug that prompted the
> change then link it. If there is some background for the commit then
> link it.
>
> If it needs to be changed around I'll do that but I personally think
> it looks nicer. It seems like the right way to provide links to
> datasheets etc without putting a bunch of long messy urls into the
> commit message.

Well, I agree it is confusing. So I have discussed privately about
this with Arnd (on IRC):

<rperier> What is the real usage of the "Link:" tag ? it is mainly
used as background informations for referencing archives or patches on
lore.k.o  , but it can also be used for referencing something else or
not ?
(like information for a board)
[...]
<arnd> right, it's pretty much never wrong to add a Link: tag for the
patch submission that was picked up, but you can also add it for any
other reference, e.g.issue trackers or datasheets that may be relevant

----

Which replies to the question, so it is okay for me ;)

Romain

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 0/3] ARM: mstar: Initial Miyoo Mini support
  2021-12-16 17:34     ` Romain Perier
@ 2021-12-16 17:48       ` Daniel Palmer
  0 siblings, 0 replies; 8+ messages in thread
From: Daniel Palmer @ 2021-12-16 17:48 UTC (permalink / raw)
  To: Romain Perier
  Cc: devicetree, linux-arm-kernel, Rob Herring, Linux Kernel Mailing List

Hi Romain,

On Fri, 17 Dec 2021 at 02:34, Romain Perier <romain.perier@gmail.com> wrote:
> Well, I agree it is confusing. So I have discussed privately about
> this with Arnd (on IRC):

Yeah. I think in the same document for submitting patches it also says
no html (obvious), no links.. ;)

> <rperier> What is the real usage of the "Link:" tag ? it is mainly
> used as background informations for referencing archives or patches on
> lore.k.o  , but it can also be used for referencing something else or
> not ?
> (like information for a board)
> [...]
> <arnd> right, it's pretty much never wrong to add a Link: tag for the
> patch submission that was picked up, but you can also add it for any
> other reference, e.g.issue trackers or datasheets that may be relevant
>
> ----
>
> Which replies to the question, so it is okay for me ;)

Thank you for going the extra mile and confirming with Arnd.
I want to start adding a link to our wiki for every board we add as
the documentation is all over the place for these things, suddenly
disappears etc.

There's a 3 commit series coming for another SSD202D board in a few
days that will look just like this one.
Maybe now you have the sbc2d70 board you could add the DTS for that
too and we can pull all of these new boards in one DT pull request?

Cheers,

Daniel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add prefix for Miyoo
  2021-12-16 10:52 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add prefix for Miyoo Daniel Palmer
@ 2021-12-16 20:54   ` Rob Herring
  0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2021-12-16 20:54 UTC (permalink / raw)
  To: Daniel Palmer
  Cc: robh+dt, devicetree, linux-kernel, linux-arm-kernel, romain.perier

On Thu, 16 Dec 2021 19:52:44 +0900, Daniel Palmer wrote:
> Add a prefix for "miyoo". The only details I can find about
> the company is their aliexpress store "miyoo global store":
> https://www.aliexpress.com/store/912663639
> 
> Signed-off-by: Daniel Palmer <daniel@0x0f.com>
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-12-16 20:54 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-16 10:52 [PATCH v2 0/3] ARM: mstar: Initial Miyoo Mini support Daniel Palmer
2021-12-16 10:52 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add prefix for Miyoo Daniel Palmer
2021-12-16 20:54   ` Rob Herring
2021-12-16 10:52 ` [PATCH v2 2/3] dt-bindings: arm: mstar: Add compatible for Miyoo Mini Daniel Palmer
2021-12-16 10:52 ` [PATCH v2 3/3] ARM: dts: mstar: Add a dts " Daniel Palmer
     [not found] ` <CABgxDoKJRc_qORcpFx=eNPS=bGV68hPrbeH0VtcQ2Jjx2ruqmg@mail.gmail.com>
2021-12-16 16:18   ` [PATCH v2 0/3] ARM: mstar: Initial Miyoo Mini support Daniel Palmer
2021-12-16 17:34     ` Romain Perier
2021-12-16 17:48       ` Daniel Palmer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).