* Re: [PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO
2019-10-07 18:42 [PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO Tuowen Zhao
@ 2019-10-08 3:10 ` AceLan Kao
2019-10-08 9:18 ` Mika Westerberg
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: AceLan Kao @ 2019-10-08 3:10 UTC (permalink / raw)
To: Tuowen Zhao
Cc: Lee Jones, Linux-Kernel@Vger. Kernel. Org, Andy Shevchenko,
Mika Westerberg, Bjorn Helgaas, Kai Heng Feng, Luis R. Rodriguez
Confirmed the patch works well on Dell XPS 7390 2-in-1 machine.
Tested-by: AceLan Kao <acelan.kao@canonical.com>
Tuowen Zhao <ztuowen@gmail.com> 於 2019年10月8日 週二 上午2:43寫道:
>
> Some BIOS erroneously specifies write-combining BAR for intel-lpss-pci
> in MTRR. This will cause the system to hang during boot. If possible,
> this bug could be corrected with a firmware update.
>
> This patch adds devm_ioremap_uc as a new managed wrapper to ioremap_uc
> and with it overwrite the MTRR settings to force the use of strongly
> uncachable pages for intel-lpss.
>
> The BIOS bug is present on Dell XPS 13 7390 2-in-1:
>
> [ 0.001734] 5 base 4000000000 mask 6000000000 write-combining
>
> 4000000000-7fffffffff : PCI Bus 0000:00
> 4000000000-400fffffff : 0000:00:02.0 (i915)
> 4010000000-4010000fff : 0000:00:15.0 (intel-lpss-pci)
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=203485
> Signed-off-by: Tuowen Zhao <ztuowen@gmail.com>
> ---
> Changes from previous version:
>
> * changed commit message
>
> drivers/mfd/intel-lpss.c | 2 +-
> include/linux/io.h | 2 ++
> lib/devres.c | 19 +++++++++++++++++++
> 3 files changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
> index bfe4ff337581..b0f0781a6b9c 100644
> --- a/drivers/mfd/intel-lpss.c
> +++ b/drivers/mfd/intel-lpss.c
> @@ -384,7 +384,7 @@ int intel_lpss_probe(struct device *dev,
> if (!lpss)
> return -ENOMEM;
>
> - lpss->priv = devm_ioremap(dev, info->mem->start + LPSS_PRIV_OFFSET,
> + lpss->priv = devm_ioremap_uc(dev, info->mem->start + LPSS_PRIV_OFFSET,
> LPSS_PRIV_SIZE);
> if (!lpss->priv)
> return -ENOMEM;
> diff --git a/include/linux/io.h b/include/linux/io.h
> index accac822336a..a59834bc0a11 100644
> --- a/include/linux/io.h
> +++ b/include/linux/io.h
> @@ -64,6 +64,8 @@ static inline void devm_ioport_unmap(struct device *dev, void __iomem *addr)
>
> void __iomem *devm_ioremap(struct device *dev, resource_size_t offset,
> resource_size_t size);
> +void __iomem *devm_ioremap_uc(struct device *dev, resource_size_t offset,
> + resource_size_t size);
> void __iomem *devm_ioremap_nocache(struct device *dev, resource_size_t offset,
> resource_size_t size);
> void __iomem *devm_ioremap_wc(struct device *dev, resource_size_t offset,
> diff --git a/lib/devres.c b/lib/devres.c
> index 6a0e9bd6524a..beb0a064b891 100644
> --- a/lib/devres.c
> +++ b/lib/devres.c
> @@ -9,6 +9,7 @@
> enum devm_ioremap_type {
> DEVM_IOREMAP = 0,
> DEVM_IOREMAP_NC,
> + DEVM_IOREMAP_UC,
> DEVM_IOREMAP_WC,
> };
>
> @@ -39,6 +40,9 @@ static void __iomem *__devm_ioremap(struct device *dev, resource_size_t offset,
> case DEVM_IOREMAP_NC:
> addr = ioremap_nocache(offset, size);
> break;
> + case DEVM_IOREMAP_UC:
> + addr = ioremap_uc(offset, size);
> + break;
> case DEVM_IOREMAP_WC:
> addr = ioremap_wc(offset, size);
> break;
> @@ -68,6 +72,21 @@ void __iomem *devm_ioremap(struct device *dev, resource_size_t offset,
> }
> EXPORT_SYMBOL(devm_ioremap);
>
> +/**
> + * devm_ioremap_uc - Managed ioremap_uc()
> + * @dev: Generic device to remap IO address for
> + * @offset: Resource address to map
> + * @size: Size of map
> + *
> + * Managed ioremap_uc(). Map is automatically unmapped on driver detach.
> + */
> +void __iomem *devm_ioremap_uc(struct device *dev, resource_size_t offset,
> + resource_size_t size)
> +{
> + return __devm_ioremap(dev, offset, size, DEVM_IOREMAP_UC);
> +}
> +EXPORT_SYMBOL(devm_ioremap_uc);
> +
> /**
> * devm_ioremap_nocache - Managed ioremap_nocache()
> * @dev: Generic device to remap IO address for
> --
> 2.23.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO
2019-10-07 18:42 [PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO Tuowen Zhao
2019-10-08 3:10 ` AceLan Kao
@ 2019-10-08 9:18 ` Mika Westerberg
2019-10-08 13:58 ` Andy Shevchenko
2019-10-08 15:16 ` Luis Chamberlain
3 siblings, 0 replies; 8+ messages in thread
From: Mika Westerberg @ 2019-10-08 9:18 UTC (permalink / raw)
To: Tuowen Zhao
Cc: lee.jones, linux-kernel, andriy.shevchenko, acelan.kao, bhelgaas,
kai.heng.feng, mcgrof
On Mon, Oct 07, 2019 at 12:42:31PM -0600, Tuowen Zhao wrote:
> Some BIOS erroneously specifies write-combining BAR for intel-lpss-pci
> in MTRR. This will cause the system to hang during boot. If possible,
> this bug could be corrected with a firmware update.
>
> This patch adds devm_ioremap_uc as a new managed wrapper to ioremap_uc
> and with it overwrite the MTRR settings to force the use of strongly
> uncachable pages for intel-lpss.
>
> The BIOS bug is present on Dell XPS 13 7390 2-in-1:
>
> [ 0.001734] 5 base 4000000000 mask 6000000000 write-combining
>
> 4000000000-7fffffffff : PCI Bus 0000:00
> 4000000000-400fffffff : 0000:00:02.0 (i915)
> 4010000000-4010000fff : 0000:00:15.0 (intel-lpss-pci)
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=203485
> Signed-off-by: Tuowen Zhao <ztuowen@gmail.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO
2019-10-07 18:42 [PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO Tuowen Zhao
2019-10-08 3:10 ` AceLan Kao
2019-10-08 9:18 ` Mika Westerberg
@ 2019-10-08 13:58 ` Andy Shevchenko
2019-10-08 15:16 ` Luis Chamberlain
3 siblings, 0 replies; 8+ messages in thread
From: Andy Shevchenko @ 2019-10-08 13:58 UTC (permalink / raw)
To: Tuowen Zhao
Cc: lee.jones, linux-kernel, mika.westerberg, acelan.kao, bhelgaas,
kai.heng.feng, mcgrof
On Mon, Oct 07, 2019 at 12:42:31PM -0600, Tuowen Zhao wrote:
> Some BIOS erroneously specifies write-combining BAR for intel-lpss-pci
> in MTRR. This will cause the system to hang during boot. If possible,
> this bug could be corrected with a firmware update.
>
> This patch adds devm_ioremap_uc as a new managed wrapper to ioremap_uc
> and with it overwrite the MTRR settings to force the use of strongly
> uncachable pages for intel-lpss.
>
> The BIOS bug is present on Dell XPS 13 7390 2-in-1:
>
> [ 0.001734] 5 base 4000000000 mask 6000000000 write-combining
>
> 4000000000-7fffffffff : PCI Bus 0000:00
> 4000000000-400fffffff : 0000:00:02.0 (i915)
> 4010000000-4010000fff : 0000:00:15.0 (intel-lpss-pci)
>
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=203485
> Signed-off-by: Tuowen Zhao <ztuowen@gmail.com>
> ---
> Changes from previous version:
>
> * changed commit message
>
> drivers/mfd/intel-lpss.c | 2 +-
> include/linux/io.h | 2 ++
> lib/devres.c | 19 +++++++++++++++++++
> 3 files changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
> index bfe4ff337581..b0f0781a6b9c 100644
> --- a/drivers/mfd/intel-lpss.c
> +++ b/drivers/mfd/intel-lpss.c
> @@ -384,7 +384,7 @@ int intel_lpss_probe(struct device *dev,
> if (!lpss)
> return -ENOMEM;
>
> - lpss->priv = devm_ioremap(dev, info->mem->start + LPSS_PRIV_OFFSET,
> + lpss->priv = devm_ioremap_uc(dev, info->mem->start + LPSS_PRIV_OFFSET,
> LPSS_PRIV_SIZE);
> if (!lpss->priv)
> return -ENOMEM;
> diff --git a/include/linux/io.h b/include/linux/io.h
> index accac822336a..a59834bc0a11 100644
> --- a/include/linux/io.h
> +++ b/include/linux/io.h
> @@ -64,6 +64,8 @@ static inline void devm_ioport_unmap(struct device *dev, void __iomem *addr)
>
> void __iomem *devm_ioremap(struct device *dev, resource_size_t offset,
> resource_size_t size);
> +void __iomem *devm_ioremap_uc(struct device *dev, resource_size_t offset,
> + resource_size_t size);
> void __iomem *devm_ioremap_nocache(struct device *dev, resource_size_t offset,
> resource_size_t size);
> void __iomem *devm_ioremap_wc(struct device *dev, resource_size_t offset,
> diff --git a/lib/devres.c b/lib/devres.c
> index 6a0e9bd6524a..beb0a064b891 100644
> --- a/lib/devres.c
> +++ b/lib/devres.c
> @@ -9,6 +9,7 @@
> enum devm_ioremap_type {
> DEVM_IOREMAP = 0,
> DEVM_IOREMAP_NC,
> + DEVM_IOREMAP_UC,
> DEVM_IOREMAP_WC,
> };
>
> @@ -39,6 +40,9 @@ static void __iomem *__devm_ioremap(struct device *dev, resource_size_t offset,
> case DEVM_IOREMAP_NC:
> addr = ioremap_nocache(offset, size);
> break;
> + case DEVM_IOREMAP_UC:
> + addr = ioremap_uc(offset, size);
> + break;
> case DEVM_IOREMAP_WC:
> addr = ioremap_wc(offset, size);
> break;
> @@ -68,6 +72,21 @@ void __iomem *devm_ioremap(struct device *dev, resource_size_t offset,
> }
> EXPORT_SYMBOL(devm_ioremap);
>
> +/**
> + * devm_ioremap_uc - Managed ioremap_uc()
> + * @dev: Generic device to remap IO address for
> + * @offset: Resource address to map
> + * @size: Size of map
> + *
> + * Managed ioremap_uc(). Map is automatically unmapped on driver detach.
> + */
> +void __iomem *devm_ioremap_uc(struct device *dev, resource_size_t offset,
> + resource_size_t size)
> +{
> + return __devm_ioremap(dev, offset, size, DEVM_IOREMAP_UC);
> +}
> +EXPORT_SYMBOL(devm_ioremap_uc);
> +
> /**
> * devm_ioremap_nocache - Managed ioremap_nocache()
> * @dev: Generic device to remap IO address for
> --
> 2.23.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO
2019-10-07 18:42 [PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO Tuowen Zhao
` (2 preceding siblings ...)
2019-10-08 13:58 ` Andy Shevchenko
@ 2019-10-08 15:16 ` Luis Chamberlain
2019-10-08 16:12 ` Andy Shevchenko
3 siblings, 1 reply; 8+ messages in thread
From: Luis Chamberlain @ 2019-10-08 15:16 UTC (permalink / raw)
To: Tuowen Zhao
Cc: lee.jones, linux-kernel, andriy.shevchenko, mika.westerberg,
acelan.kao, bhelgaas, kai.heng.feng
On Mon, Oct 07, 2019 at 12:42:31PM -0600, Tuowen Zhao wrote:
> +EXPORT_SYMBOL(devm_ioremap_uc);
EXPORT_SYMBOL_GPL() would be my preference.
Luis
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO
2019-10-08 15:16 ` Luis Chamberlain
@ 2019-10-08 16:12 ` Andy Shevchenko
[not found] ` <CAB=NE6V64g5WLMYFxkpC_wsnSbGG-5Nn9uFo1zpcqjP9NsRB+w@mail.gmail.com>
0 siblings, 1 reply; 8+ messages in thread
From: Andy Shevchenko @ 2019-10-08 16:12 UTC (permalink / raw)
To: Luis Chamberlain
Cc: Tuowen Zhao, lee.jones, linux-kernel, mika.westerberg,
acelan.kao, bhelgaas, kai.heng.feng
On Tue, Oct 08, 2019 at 03:16:28PM +0000, Luis Chamberlain wrote:
> On Mon, Oct 07, 2019 at 12:42:31PM -0600, Tuowen Zhao wrote:
> > +EXPORT_SYMBOL(devm_ioremap_uc);
>
> EXPORT_SYMBOL_GPL() would be my preference.
Maybe we can even split this to two patches?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread