From: Bamvor Zhang Jian <bamvor.zhangjian@linaro.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Shuah Khan <shuahkh@osg.samsung.com>,
"Zhang Jian(Bamvor)" <bamvor.zhangjian@huawei.com>,
lkml <linux-kernel@vger.kernel.org>,
linuxppc-dev@ozlabs.org, linux-kselftest@vger.kernel.org,
linux-api <linux-api@vger.kernel.org>
Subject: Re: [PATCH 3/5] selftests: Fix the .S and .S -> .o rules
Date: Tue, 14 Feb 2017 11:07:28 +0800 [thread overview]
Message-ID: <CAFy1USS8b=eYyrp7k8f0_nUc8Rf4bCuCRTeYLG7CUcNOyQzeiw@mail.gmail.com> (raw)
In-Reply-To: <1486630590-9410-3-git-send-email-mpe@ellerman.id.au>
Tested-by: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>
On 9 February 2017 at 16:56, Michael Ellerman <mpe@ellerman.id.au> wrote:
> Both these rules incorrectly use $< (first prerequisite) rather than
> $^ (all prerequisites), meaning they don't work if we're using more than
> one .S file as input. Switch them to using $^.
>
> They also don't include $(CPPFLAGS) and other variables used in the
> default rules, which breaks targets that require those. Fix that by
> using the builtin $(COMPILE.S) and $(LINK.S) rules.
>
> Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
> tools/testing/selftests/lib.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index 98841c54763a..ce96d80ad64f 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -54,9 +54,9 @@ $(OUTPUT)/%:%.c
> $(LINK.c) $^ $(LDLIBS) -o $@
>
> $(OUTPUT)/%.o:%.S
> - $(CC) $(ASFLAGS) -c $< -o $@
> + $(COMPILE.S) $^ -o $@
>
> $(OUTPUT)/%:%.S
> - $(CC) $(ASFLAGS) $< -o $@
> + $(LINK.S) $^ $(LDLIBS) -o $@
>
> .PHONY: run_tests all clean install emit_tests
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-api" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-02-14 3:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 8:56 [PATCH 1/5] selftests: Fix selftests build to just build, not run tests Michael Ellerman
2017-02-09 8:56 ` [PATCH 2/5] selftests: Fix the .c linking rule Michael Ellerman
2017-02-14 3:07 ` Bamvor Zhang Jian
2017-02-09 8:56 ` [PATCH 3/5] selftests: Fix the .S and .S -> .o rules Michael Ellerman
2017-02-14 3:07 ` Bamvor Zhang Jian [this message]
2017-02-09 8:56 ` [PATCH 4/5] selftests/powerpc: Fix the clean rule since recent changes Michael Ellerman
2017-02-09 8:56 ` [PATCH 5/5] selftests/powerpc: Fix remaining fallout from " Michael Ellerman
2017-02-14 2:09 ` [PATCH 1/5] selftests: Fix selftests build to just build, not run tests Michael Ellerman
2017-02-14 16:14 ` Shuah Khan
2017-02-14 20:33 ` Michael Ellerman
2017-03-01 19:00 ` Shuah Khan
2017-03-02 6:43 ` Michael Ellerman
2017-03-02 14:41 ` Shuah Khan
2017-02-14 3:06 ` Bamvor Zhang Jian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFy1USS8b=eYyrp7k8f0_nUc8Rf4bCuCRTeYLG7CUcNOyQzeiw@mail.gmail.com' \
--to=bamvor.zhangjian@linaro.org \
--cc=bamvor.zhangjian@huawei.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).