From: Bamvor Zhang Jian <bamvor.zhangjian@linaro.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Shuah Khan <shuahkh@osg.samsung.com>,
"Zhang Jian(Bamvor)" <bamvor.zhangjian@huawei.com>,
lkml <linux-kernel@vger.kernel.org>,
linuxppc-dev@ozlabs.org, linux-kselftest@vger.kernel.org,
linux-api <linux-api@vger.kernel.org>
Subject: Re: [PATCH 1/5] selftests: Fix selftests build to just build, not run tests
Date: Tue, 14 Feb 2017 11:06:36 +0800 [thread overview]
Message-ID: <CAFy1USTVyg5Mq65r-yskvEuaNrxxYHpckrFa1o0OUtn=_ZT38Q@mail.gmail.com> (raw)
In-Reply-To: <1486630590-9410-1-git-send-email-mpe@ellerman.id.au>
Tested by: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>
On 9 February 2017 at 16:56, Michael Ellerman <mpe@ellerman.id.au> wrote:
> In commit 88baa78d1f31 ("selftests: remove duplicated all and clean
> target"), the "all" target was removed from individual Makefiles and
> added to lib.mk.
>
> However the "all" target was added to lib.mk *after* the existing
> "runtests" target. This means "runtests" becomes the first (default)
> target for most of our Makefiles.
>
> This has the effect of causing a plain "make" to build *and run* the
> tests. Which is at best rude, but depending on which tests are run could
> oops someone's build machine.
>
> $ make -C tools/testing/selftests/
> ...
> make[1]: Entering directory 'tools/testing/selftests/bpf'
> gcc -Wall -O2 -I../../../../usr/include test_verifier.c -o tools/testing/selftests/bpf/test_verifier
> gcc -Wall -O2 -I../../../../usr/include test_maps.c -o tools/testing/selftests/bpf/test_maps
> gcc -Wall -O2 -I../../../../usr/include test_lru_map.c -o tools/testing/selftests/bpf/test_lru_map
> #0 add+sub+mul FAIL
> Failed to load prog 'Function not implemented'!
> #1 unreachable FAIL
> Unexpected error message!
> #2 unreachable2 FAIL
> ...
>
> Fix it by moving the "all" target to the start of lib.mk, making it the
> default target.
>
> Fixes: 88baa78d1f31 ("selftests: remove duplicated all and clean target")
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
> tools/testing/selftests/lib.mk | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index 01bb7782a35e..17ed4bbe3963 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -2,6 +2,11 @@
> # Makefile can operate with or without the kbuild infrastructure.
> CC := $(CROSS_COMPILE)gcc
>
> +TEST_GEN_PROGS := $(patsubst %,$(OUTPUT)/%,$(TEST_GEN_PROGS))
> +TEST_GEN_FILES := $(patsubst %,$(OUTPUT)/%,$(TEST_GEN_FILES))
> +
> +all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES)
> +
> define RUN_TESTS
> @for TEST in $(TEST_GEN_PROGS) $(TEST_PROGS); do \
> BASENAME_TEST=`basename $$TEST`; \
> @@ -42,11 +47,6 @@ endef
> emit_tests:
> $(EMIT_TESTS)
>
> -TEST_GEN_PROGS := $(patsubst %,$(OUTPUT)/%,$(TEST_GEN_PROGS))
> -TEST_GEN_FILES := $(patsubst %,$(OUTPUT)/%,$(TEST_GEN_FILES))
> -
> -all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES)
> -
> clean:
> $(RM) -r $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) $(EXTRA_CLEAN)
>
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-api" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-02-14 3:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 8:56 [PATCH 1/5] selftests: Fix selftests build to just build, not run tests Michael Ellerman
2017-02-09 8:56 ` [PATCH 2/5] selftests: Fix the .c linking rule Michael Ellerman
2017-02-14 3:07 ` Bamvor Zhang Jian
2017-02-09 8:56 ` [PATCH 3/5] selftests: Fix the .S and .S -> .o rules Michael Ellerman
2017-02-14 3:07 ` Bamvor Zhang Jian
2017-02-09 8:56 ` [PATCH 4/5] selftests/powerpc: Fix the clean rule since recent changes Michael Ellerman
2017-02-09 8:56 ` [PATCH 5/5] selftests/powerpc: Fix remaining fallout from " Michael Ellerman
2017-02-14 2:09 ` [PATCH 1/5] selftests: Fix selftests build to just build, not run tests Michael Ellerman
2017-02-14 16:14 ` Shuah Khan
2017-02-14 20:33 ` Michael Ellerman
2017-03-01 19:00 ` Shuah Khan
2017-03-02 6:43 ` Michael Ellerman
2017-03-02 14:41 ` Shuah Khan
2017-02-14 3:06 ` Bamvor Zhang Jian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFy1USTVyg5Mq65r-yskvEuaNrxxYHpckrFa1o0OUtn=_ZT38Q@mail.gmail.com' \
--to=bamvor.zhangjian@linaro.org \
--cc=bamvor.zhangjian@huawei.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).