From: Gabriel Fernandez <gabriel.fernandez@linaro.org>
To: Liviu Dudau <Liviu.Dudau@arm.com>
Cc: Gabriel FERNANDEZ <gabriel.fernandez@st.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <Pawel.Moll@arm.com>,
Mark Rutland <Mark.Rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Srinivas Kandagatla <srinivas.kandagatla@gmail.com>,
Maxime Coquelin <maxime.coquelin@st.com>,
Patrice Chotard <patrice.chotard@st.com>,
Russell King <linux@arm.linux.org.uk>,
Bjorn Helgaas <bhelgaas@google.com>,
Mohit Kumar <mohit.kumar@st.com>,
Jingoo Han <jg1.han@samsung.com>,
Lucas Stach <l.stach@pengutronix.de>,
Fabrice Gasnier <fabrice.gasnier@st.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
Greg KH <gregkh@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Joe Perches <joe@perches.com>, Tejun Heo <tj@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Viresh Kumar <viresh.kumar@linaro.org>,
Thierry Reding <treding@nvidia.com>,
Phil Edworthy <phil.edworthy@renesas.com>,
Minghuan Lian <Minghuan.Lian@freescale.com>,
Tanmay Inamdar <tinamdar@apm.com>,
"m-karicheri2@ti.com" <m-karicheri2@ti.com>,
Sachin Kamat <sachin.kamat@samsung.com>,
Andrew Lunn <andrew@lunn.ch>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"kernel@stlinux.com" <kernel@stlinux.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lee Jones <lee.jones@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/5] PCI: st: Add Device Tree bindings for sti pcie
Date: Mon, 30 Mar 2015 14:28:12 +0200 [thread overview]
Message-ID: <CAG374jCm6CREcqKsXYnXHTNCOuaokNA11Sv6_JSW13Vdeo-tHw@mail.gmail.com> (raw)
In-Reply-To: <20150317114213.GH27081@e106497-lin.cambridge.arm.com>
Hi Liviu,
You're right, i removed configuration space from the ranges.
Thanks for reviewing.
Gabriel
On 17 March 2015 at 12:42, Liviu Dudau <Liviu.Dudau@arm.com> wrote:
> Hi Gabriel,
>
> On Mon, Mar 16, 2015 at 02:20:32PM +0000, Gabriel FERNANDEZ wrote:
>> sti pcie is built around a Synopsis Designware PCIe IP.
>>
>> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
>> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@linaro.org>
>> ---
>> Documentation/devicetree/bindings/pci/st-pcie.txt | 54 +++++++++++++++++++++++
>> 1 file changed, 54 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/pci/st-pcie.txt
>>
>> diff --git a/Documentation/devicetree/bindings/pci/st-pcie.txt b/Documentation/devicetree/bindings/pci/st-pcie.txt
>> new file mode 100644
>> index 0000000..94aae2d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pci/st-pcie.txt
>> @@ -0,0 +1,54 @@
>> +STMicroelectronics STi PCIe controller
>> +
>> +This PCIe host controller is based on the Synopsis Designware PCIe IP
>> +and thus inherits all the common properties defined in designware-pcie.txt.
>> +
>> +Required properties:
>> + - compatible: "st,stih407-pcie"
>> + - reg: base address and length of the pcie controller, mem-window address
>> + and length available to the controller.
>> + - interrupts: A list of interrupt outputs of the controller. Must contain an
>> + entry for each entry in the interrupt-names property.
>> + - interrupt-names: Should be "msi". STi interrupt that is asserted when an
>> + MSI is received.
>> + - st,syscfg : should be a phandle of the syscfg node. Also contains syscfg
>> + offset for IP configuration.
>> + - resets, reset-names: the power-down and soft-reset lines of PCIe IP.
>> + Associated names must be "powerdown" and "softreset".
>> + - phys, phy-names: the phandle for the PHY device.
>> + Associated name must be "pcie"
>> +
>> +Optional properties:
>> + - reset-gpio: a GPIO spec to define which pin is connected to the bus reset.
>> +
>> +Example:
>> +
>> +pcie0: pcie@9b00000 {
>> + compatible = "st,stih407-pcie", "snps,dw-pcie";
>> + device_type = "pci";
>> + reg = <0x09b00000 0x4000>, /* dbi cntrl registers */
>> + <0x2fff0000 0x00010000>, /* configuration space */
>> + <0x40000000 0x80000000>; /* lmi mem window */
>> + reg-names = "dbi", "config", "mem-window";
>> + st,syscfg = <&syscfg_core 0xd8 0xe0>;
>> + #address-cells = <3>;
>> + #size-cells = <2>;
>> + ranges = <0x00000800 0 0x2fff0000 0x2fff0000 0 0x00010000 /* configuration space */
>
> Unless you are trying to support some legacy code please remove the configuration space from the ranges.
> There is no resource type associated with config space and the generic parser will give you back an
> invalid resource type. The other reason for that is that if you really claim to be ECAM compliant by
> adding the config space here you need way more than 64K of space.
>
> Best regards,
> Liviu
>
>> + 0x82000000 0 0x20000000 0x20000000 0 0x0FFF0000>; /* non-prefetchable memory */
>> + num-lanes = <1>;
>> + interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "msi";
>> + #interrupt-cells = <1>;
>> + interrupt-map-mask = <0 0 0 7>;
>> + interrupt-map = <0 0 0 1 &intc GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>, /* INT A */
>> + <0 0 0 2 &intc GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>, /* INT B */
>> + <0 0 0 3 &intc GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>, /* INT C */
>> + <0 0 0 4 &intc GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>; /* INT D */
>> +
>> + resets = <&powerdown STIH407_PCIE0_POWERDOWN>,
>> + <&softreset STIH407_PCIE0_SOFTRESET>;
>> + reset-names = "powerdown",
>> + "softreset";
>> + phys = <&phy_port0 PHY_TYPE_PCIE>;
>> + phy-names = "pcie";
>> +};
>> --
>> 1.9.1
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
>
> --
> ====================
> | I would like to |
> | fix the world, |
> | but they're not |
> | giving me the |
> \ source code! /
> ---------------
> ¯\_(ツ)_/¯
>
next prev parent reply other threads:[~2015-03-30 12:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 14:20 [PATCH v2 0/5] PCI: st: provide support for dw pcie Gabriel FERNANDEZ
2015-03-16 14:20 ` [PATCH v2 1/5] ARM: STi: Kconfig update for PCIe support Gabriel FERNANDEZ
2015-03-16 14:20 ` [PATCH v2 2/5] PCI: st: Add Device Tree bindings for sti pcie Gabriel FERNANDEZ
2015-03-17 11:42 ` Liviu Dudau
2015-03-30 12:28 ` Gabriel Fernandez [this message]
2015-03-16 14:20 ` [PATCH v2 3/5] PCI: st: Provide support for the sti PCIe controller Gabriel FERNANDEZ
2015-03-16 15:11 ` Paul Bolle
2015-03-17 7:53 ` Gabriel Fernandez
2015-03-18 8:49 ` Fabrice Gasnier
2015-03-18 10:35 ` Paul Bolle
2015-03-31 9:11 ` Gabriel Fernandez
2015-04-09 12:43 ` Bjorn Helgaas
2015-03-17 10:35 ` Kishon Vijay Abraham I
2015-03-30 12:41 ` Gabriel Fernandez
2015-03-16 14:20 ` [PATCH v2 4/5] PCI: designware: Add disable IO support Gabriel FERNANDEZ
2015-03-16 17:53 ` Srinivas Kandagatla
2015-03-17 7:49 ` Gabriel Fernandez
2015-03-16 18:00 ` Kumar Gala
2015-03-16 20:00 ` Arnd Bergmann
2015-03-17 7:41 ` Gabriel Fernandez
2015-03-16 14:20 ` [PATCH v2 5/5] MAINTAINERS: Add pci-st.c to ARCH/STI architecture Gabriel FERNANDEZ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG374jCm6CREcqKsXYnXHTNCOuaokNA11Sv6_JSW13Vdeo-tHw@mail.gmail.com \
--to=gabriel.fernandez@linaro.org \
--cc=Liviu.Dudau@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=Minghuan.Lian@freescale.com \
--cc=Pawel.Moll@arm.com \
--cc=akpm@linux-foundation.org \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=gabriel.fernandez@st.com \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jg1.han@samsung.com \
--cc=joe@perches.com \
--cc=kernel@stlinux.com \
--cc=kishon@ti.com \
--cc=l.stach@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m-karicheri2@ti.com \
--cc=maxime.coquelin@st.com \
--cc=mchehab@osg.samsung.com \
--cc=mohit.kumar@st.com \
--cc=patrice.chotard@st.com \
--cc=phil.edworthy@renesas.com \
--cc=robh+dt@kernel.org \
--cc=sachin.kamat@samsung.com \
--cc=srinivas.kandagatla@gmail.com \
--cc=tinamdar@apm.com \
--cc=tj@kernel.org \
--cc=treding@nvidia.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).