* [PATCH] drm/bridge: lt9611: Fix an error handling path in lt9611_probe()
@ 2022-01-29 15:06 Christophe JAILLET
2022-01-31 16:25 ` Robert Foss
0 siblings, 1 reply; 3+ messages in thread
From: Christophe JAILLET @ 2022-01-29 15:06 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Sam Ravnborg, Bjorn Andersson, Srinivas Kandagatla, Vinod Koul
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, dri-devel
If lt9611_audio_init() fails, some resources still need to be released
before returning an error code.
Add the missing goto the error handling path.
Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/gpu/drm/bridge/lontium-lt9611.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
index dafb1b47c15f..00597eb54661 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
@@ -1164,7 +1164,11 @@ static int lt9611_probe(struct i2c_client *client,
lt9611_enable_hpd_interrupts(lt9611);
- return lt9611_audio_init(dev, lt9611);
+ ret = lt9611_audio_init(dev, lt9611);
+ if (ret)
+ goto err_remove_bridge;
+
+ return 0;
err_remove_bridge:
drm_bridge_remove(<9611->bridge);
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: lt9611: Fix an error handling path in lt9611_probe()
2022-01-29 15:06 [PATCH] drm/bridge: lt9611: Fix an error handling path in lt9611_probe() Christophe JAILLET
@ 2022-01-31 16:25 ` Robert Foss
2022-01-31 16:26 ` Robert Foss
0 siblings, 1 reply; 3+ messages in thread
From: Robert Foss @ 2022-01-31 16:25 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, David Airlie, Daniel Vetter, Sam Ravnborg,
Bjorn Andersson, Srinivas Kandagatla, Vinod Koul, linux-kernel,
kernel-janitors, dri-devel
Hey Christophe,
Thanks for submitting this fix.
On Sat, 29 Jan 2022 at 16:06, Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> If lt9611_audio_init() fails, some resources still need to be released
> before returning an error code.
>
> Add the missing goto the error handling path.
>
> Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/gpu/drm/bridge/lontium-lt9611.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index dafb1b47c15f..00597eb54661 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> @@ -1164,7 +1164,11 @@ static int lt9611_probe(struct i2c_client *client,
>
> lt9611_enable_hpd_interrupts(lt9611);
>
> - return lt9611_audio_init(dev, lt9611);
> + ret = lt9611_audio_init(dev, lt9611);
> + if (ret)
> + goto err_remove_bridge;
> +
> + return 0;
>
> err_remove_bridge:
> drm_bridge_remove(<9611->bridge);
> --
> 2.32.0
>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: lt9611: Fix an error handling path in lt9611_probe()
2022-01-31 16:25 ` Robert Foss
@ 2022-01-31 16:26 ` Robert Foss
0 siblings, 0 replies; 3+ messages in thread
From: Robert Foss @ 2022-01-31 16:26 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, David Airlie, Daniel Vetter, Sam Ravnborg,
Bjorn Andersson, Srinivas Kandagatla, Vinod Koul, linux-kernel,
kernel-janitors, dri-devel
On Mon, 31 Jan 2022 at 17:25, Robert Foss <robert.foss@linaro.org> wrote:
>
> Hey Christophe,
>
> Thanks for submitting this fix.
>
> On Sat, 29 Jan 2022 at 16:06, Christophe JAILLET
> <christophe.jaillet@wanadoo.fr> wrote:
> >
> > If lt9611_audio_init() fails, some resources still need to be released
> > before returning an error code.
> >
> > Add the missing goto the error handling path.
> >
> > Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > ---
> > drivers/gpu/drm/bridge/lontium-lt9611.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> > index dafb1b47c15f..00597eb54661 100644
> > --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> > +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> > @@ -1164,7 +1164,11 @@ static int lt9611_probe(struct i2c_client *client,
> >
> > lt9611_enable_hpd_interrupts(lt9611);
> >
> > - return lt9611_audio_init(dev, lt9611);
> > + ret = lt9611_audio_init(dev, lt9611);
> > + if (ret)
> > + goto err_remove_bridge;
> > +
> > + return 0;
> >
> > err_remove_bridge:
> > drm_bridge_remove(<9611->bridge);
> > --
> > 2.32.0
> >
>
> Reviewed-by: Robert Foss <robert.foss@linaro.org>
Applied to drm-misc-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-31 16:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-29 15:06 [PATCH] drm/bridge: lt9611: Fix an error handling path in lt9611_probe() Christophe JAILLET
2022-01-31 16:25 ` Robert Foss
2022-01-31 16:26 ` Robert Foss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).