Re: [PATCH v5 01/22] media: camss: Fix vfe_isr_comp_done() documentation

From: Robert Foss <robert.foss@linaro.org>
To: Nicolas Dufresne <nicolas@ndufresne.ca>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Todor Tomov <todor.too@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	angelogioacchino.delregno@somainline.org,
	MSM <linux-arm-msm@vger.kernel.org>,
	linux-media <linux-media@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	AngeloGioacchino Del Regno <kholk11@gmail.com>,
	Sakari Ailus <sakari.ailus@iki.fi>,
	Andrey Konovalov <andrey.konovalov@linaro.org>,
	Tomasz Figa <tfiga@chromium.org>,
	Azam Sadiq Pasha Kapatrala Syed <akapatra@quicinc.com>,
	Sarvesh Sridutt <Sarvesh.Sridutt@smartwirelesscompute.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Jonathan Marek <jonathan@marek.ca>
Subject: Re: [PATCH v5 01/22] media: camss: Fix vfe_isr_comp_done() documentation
Date: Mon, 22 Feb 2021 11:51:29 +0100	[thread overview]
Message-ID: <CAG3jFyvNigAZrwAEQOvKac2Sdu5rjtBDWrMjwhXkMmDpZXBUDg@mail.gmail.com> (raw)
In-Reply-To: <39f17656195110cc5298f53840ca02f790d7e4af.camel@ndufresne.ca>

On Fri, 19 Feb 2021 at 22:05, Nicolas Dufresne <nicolas@ndufresne.ca> wrote:
>
> Hi Robert,
>
> not really a review, but I noticed ....
>
> Le mercredi 17 février 2021 à 12:21 +0100, Robert Foss a écrit :
> > Function name is comment is wrong, and was changed to be
>
>                 in

Thanks bud!

>
> > the same as the actual function name.
> >
> > The comment was changed to kerneldoc format.
> >
> > Signed-off-by: Robert Foss <robert.foss@linaro.org>
> > ---
> >
> > Changes since v1
> >  - Bjorn: Fix function doc name & use kerneldoc format
> >
> >
> >  drivers/media/platform/qcom/camss/camss-vfe.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c
> > b/drivers/media/platform/qcom/camss/camss-vfe.c
> > index fae2b513b2f9..94c9ca7d5cbb 100644
> > --- a/drivers/media/platform/qcom/camss/camss-vfe.c
> > +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
> > @@ -1076,8 +1076,8 @@ static void vfe_isr_wm_done(struct vfe_device *vfe, u8
> > wm)
> >         spin_unlock_irqrestore(&vfe->output_lock, flags);
> >  }
> >
> > -/*
> > - * vfe_isr_wm_done - Process composite image done interrupt
> > +/**
> > + * vfe_isr_comp_done() - Process composite image done interrupt
> >   * @vfe: VFE Device
> >   * @comp: Composite image id
> >   */
>
>