From: Jann Horn <jannh@google.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
tursulin@ursulin.net, kernel list <linux-kernel@vger.kernel.org>,
tvrtko.ursulin@linux.intel.com,
Peter Zijlstra <peterz@infradead.org>,
"the arch/x86 maintainers" <x86@kernel.org>,
"H . Peter Anvin" <hpa@zytor.com>,
acme@kernel.org, alexander.shishkin@linux.intel.com,
jolsa@redhat.com, namhyung@kernel.org, maddy@linux.vnet.ibm.com,
alexey.budankov@linux.intel.com,
Kees Cook <keescook@chromium.org>
Subject: Re: [RFC 0/5] perf: Per PMU access controls (paranoid setting)
Date: Fri, 28 Sep 2018 23:22:37 +0200 [thread overview]
Message-ID: <CAG48ez1xJ+Y=snnHJ5k6J6O3qqD=bHdjRioLFuzPZpxU9v7xxA@mail.gmail.com> (raw)
In-Reply-To: <20180928205907.GD32651@tassilo.jf.intel.com>
On Fri, Sep 28, 2018 at 10:59 PM Andi Kleen <ak@linux.intel.com> wrote:
> > > This new file descriptor argument doesn't exist today so it would
> > > need to create a new system call with more arguments
> >
> > Is that true? The first argument is a pointer to a struct that
> > contains its own size, so it can be expanded without an ABI break. I
> > don't see any reason why you couldn't cram more stuff in there.
>
> You're right we could put the fd into the perf_event, but the following is
> still true:
>
> > > Obviously we would need to keep the old system call around
> > > for compability, so you would need to worry about this
> > > interaction in any case!
<blasphemy>
Is that true? IIRC if you want to use the perf tools after a kernel
update, you have to install a new version of perf anyway, no? I think
after I run a kernel update, when I run "perf top", it just refuses to
start and tells me to go install a newer version. Would the users of
perf_event_open() that want to monitor this graphics stuff normally
keep working after a kernel version bump?
I realize that the kernel is very much against breaking userspace
interfaces, but if userspace has already decided to break itself after
every update, we might as well take advantage of that...
</blasphemy>
> > > So tying it together doesn't make any sense, because
> > > the problem has to be solved separately anyways.
next prev parent reply other threads:[~2018-09-28 21:23 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 12:27 [RFC 0/5] perf: Per PMU access controls (paranoid setting) Tvrtko Ursulin
2018-09-19 12:27 ` [RFC 1/5] perf: Move some access checks later in perf_event_open Tvrtko Ursulin
2018-09-19 12:27 ` [RFC 2/5] perf: Pass pmu pointer to perf_paranoid_* helpers Tvrtko Ursulin
2018-09-19 12:27 ` [RFC 3/5] perf: Allow per PMU access control Tvrtko Ursulin
2018-09-27 20:15 ` Andi Kleen
2018-09-28 8:57 ` Tvrtko Ursulin
2018-09-19 12:27 ` [RFC 4/5] perf Documentation: Document the per PMU perf_event_paranoid interface Tvrtko Ursulin
2018-09-19 12:27 ` [RFC 5/5] tools/perf: Add support for per-PMU access control Tvrtko Ursulin
2018-09-28 10:26 ` [RFC 0/5] perf: Per PMU access controls (paranoid setting) Thomas Gleixner
2018-09-28 13:22 ` Tvrtko Ursulin
2018-09-28 14:02 ` Thomas Gleixner
2018-09-28 14:56 ` Tvrtko Ursulin
2018-09-28 15:23 ` Thomas Gleixner
2018-09-28 15:45 ` Alexey Budankov
2018-09-28 18:20 ` Thomas Gleixner
2018-09-28 20:45 ` Andi Kleen
2018-09-29 6:19 ` Thomas Gleixner
2018-10-01 6:25 ` Alexey Budankov
2018-09-28 15:12 ` Jann Horn
2018-09-28 22:02 ` Jann Horn
2018-10-01 6:27 ` Alexey Budankov
2018-09-28 16:41 ` Mark Rutland
2018-09-28 17:23 ` Andi Kleen
2018-09-28 17:40 ` Mark Rutland
2018-09-28 20:49 ` Andi Kleen
2018-09-28 20:54 ` Jann Horn
2018-09-28 20:59 ` Andi Kleen
2018-09-28 21:22 ` Jann Horn [this message]
2018-09-28 21:27 ` Andi Kleen
2018-10-01 6:25 ` Alexey Budankov
2018-10-01 16:11 ` Thomas Gleixner
2018-10-01 16:15 ` Jann Horn
2018-10-01 20:51 ` Alexey Budankov
2018-10-02 6:40 ` Thomas Gleixner
2018-10-02 11:44 ` Alexey Budankov
2018-10-03 17:01 ` Jann Horn
2018-10-04 17:11 ` Alexey Budankov
2018-09-29 6:30 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG48ez1xJ+Y=snnHJ5k6J6O3qqD=bHdjRioLFuzPZpxU9v7xxA@mail.gmail.com' \
--to=jannh@google.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mark.rutland@arm.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tursulin@ursulin.net \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).