From: Saravana Kannan <saravanak@google.com>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-tegra <linux-tegra@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Jon Hunter <jonathanh@nvidia.com>, Marc Zyngier <maz@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH v2 0/2] of: property: Add fw_devlink support for more props
Date: Mon, 1 Feb 2021 12:04:11 -0800 [thread overview]
Message-ID: <CAGETcx91CdvqYpSr6Eg45jrToEFLPBSgzMxTjHh=1rBqi8V3pg@mail.gmail.com> (raw)
In-Reply-To: <20210201105204.GA1467@martin-debian-1.paytec.ch>
On Mon, Feb 1, 2021 at 2:52 AM Martin Kaiser <martin@kaiser.cx> wrote:
>
> Hi Saravana,
>
> Thus wrote Saravana Kannan (saravanak@google.com):
>
> > This series [1] has a high chance of fixing it for you if
> > CONFIG_MODULES is disabled in your set up. Can you give it a shot?
>
> sure. This fixes things for me if CONFIG_MODULES is disabled. Booting is
> still stuck if modules are enabled.
>
> > The real problem is that arch/arm/mach-imx/avic.c doesn't set the
> > OF_POPULATED flag for the "fsl,avic" node. fw_devlink uses this
> > information to know that this device node will never have a struct
> > device created for it. The proper way to do this for root IRQCHIP
> > nodes is to use IRQCHIP_DECLARE(). I Cc'ed you on a clean up patch for
> > IMX [2], can you please give [2] a shot *without* [1] and with
> > CONFIG_MODULES enabled? Things should boot properly with this
> > combination too.
>
> This works as well.
Thanks for testing both. Mind giving Tested-by for [1] too?
-Saravana
prev parent reply other threads:[~2021-02-01 20:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 22:57 [PATCH v2 0/2] of: property: Add fw_devlink support for more props Saravana Kannan
2021-01-21 22:57 ` [PATCH v2 1/2] of: property: Add fw_devlink support for "gpio" and "gpios" binding Saravana Kannan
2021-01-22 12:58 ` Linus Walleij
2021-01-21 22:57 ` [PATCH v2 2/2] of: property: Add fw_devlink support for interrupts Saravana Kannan
[not found] ` <CGME20210204115252eucas1p2d145686f7a5dc7e7a04dddd0b0f2286c@eucas1p2.samsung.com>
2021-02-04 11:52 ` Marek Szyprowski
2021-02-04 21:31 ` Saravana Kannan
2021-02-05 7:38 ` Marek Szyprowski
2021-02-05 8:06 ` Geert Uytterhoeven
2021-02-05 10:05 ` Saravana Kannan
2021-02-05 10:20 ` Geert Uytterhoeven
2021-02-05 17:19 ` Saravana Kannan
2021-02-05 17:51 ` Geert Uytterhoeven
2021-02-05 17:55 ` Saravana Kannan
2021-02-06 4:32 ` Saravana Kannan
2021-02-08 8:14 ` Marek Szyprowski
2021-02-08 23:57 ` Saravana Kannan
2021-02-13 18:54 ` Guenter Roeck
2021-02-14 21:12 ` Saravana Kannan
2021-02-15 3:06 ` Guenter Roeck
2021-02-15 3:58 ` Guenter Roeck
2021-02-15 8:29 ` Saravana Kannan
2021-02-15 9:08 ` Marc Zyngier
2021-02-15 22:23 ` Saravana Kannan
2021-01-26 8:22 ` [PATCH v2 0/2] of: property: Add fw_devlink support for more props Greg Kroah-Hartman
[not found] ` <20210131163823.c4zb47pl4tukcl7c@viti.kaiser.cx>
2021-01-31 21:05 ` Saravana Kannan
2021-02-01 10:52 ` Martin Kaiser
2021-02-01 20:04 ` Saravana Kannan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGETcx91CdvqYpSr6Eg45jrToEFLPBSgzMxTjHh=1rBqi8V3pg@mail.gmail.com' \
--to=saravanak@google.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=kernel-team@android.com \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=martin@kaiser.cx \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).