From: Saravana Kannan <saravanak@google.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-tegra <linux-tegra@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Jon Hunter <jonathanh@nvidia.com>, Marc Zyngier <maz@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Android Kernel Team <kernel-team@android.com>,
Rob Herring <robh@kernel.org>,
Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH v2 2/2] of: property: Add fw_devlink support for interrupts
Date: Sun, 14 Feb 2021 13:12:47 -0800 [thread overview]
Message-ID: <CAGETcx_RpG45Fwhty1Uj34Mv01qkH5vFv0J6jVtJgTBFQinOBA@mail.gmail.com> (raw)
In-Reply-To: <20210213185422.GA195733@roeck-us.net>
On Sat, Feb 13, 2021 at 10:54 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> Hi,
>
> On Thu, Jan 21, 2021 at 02:57:12PM -0800, Saravana Kannan wrote:
> > This allows fw_devlink to create device links between consumers of an
> > interrupt and the supplier of the interrupt.
> >
> > Cc: Marc Zyngier <maz@kernel.org>
> > Cc: Kevin Hilman <khilman@baylibre.com>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Reviewed-by: Thierry Reding <treding@nvidia.com>
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > Signed-off-by: Saravana Kannan <saravanak@google.com>
>
> This patch causes all ppc64:powernv qemu emulations to fail.
> The problem is always the same: The root file system can not be mounted.
>
> Example:
>
> [ 14.245672][ T1] VFS: Cannot open root device "sda" or unknown-block(0,0): error -6
> [ 14.246063][ T1] Please append a correct "root=" boot option; here are the available partitions:
> [ 14.246609][ T1] 1f00 131072 mtdblock0
> [ 14.246648][ T1] (driver?)
> [ 14.247137][ T1] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0)
> [ 14.247631][ T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.11.0-rc7-next-20210212 #1
> [ 14.248166][ T1] Call Trace:
> [ 14.248344][ T1] [c000000002c07a70] [c0000000008f052c] dump_stack+0x100/0x174 (unreliable)
> [ 14.248780][ T1] [c000000002c07ab0] [c00000000010d0e0] panic+0x190/0x450
> [ 14.249097][ T1] [c000000002c07b50] [c0000000014d1af8] mount_block_root+0x320/0x430
> [ 14.249442][ T1] [c000000002c07c50] [c0000000014d1e64] prepare_namespace+0x1b0/0x204
> [ 14.249798][ T1] [c000000002c07cc0] [c0000000014d1544] kernel_init_freeable+0x3dc/0x438
> [ 14.250145][ T1] [c000000002c07da0] [c000000000012b7c] kernel_init+0x2c/0x170
> [ 14.250466][ T1] [c000000002c07e10] [c00000000000d56c] ret_from_kernel_thread+0x5c/0x70
> [ 28.068945385,5] OPAL: Reboot request...
>
> Another:
>
> [ 14.273398][ T1] md: Autodetecting RAID arrays.
> [ 14.273665][ T1] md: autorun ...
> [ 14.273860][ T1] md: ... autorun DONE.
> [ 14.275078][ T1] Waiting for root device /dev/mmcblk0...
>
> [ waits until terminated ]
>
> Key difference seems to be that PCI devices are no longer instantiated
> with this patch applied. Specifically, I see
>
> [ 1.153780][ T1] pci 0005:01 : [PE# fd] Setting up window#0 0..7fffffff pg=10000^M
> [ 1.154475][ T1] pci 0005:01 : [PE# fd] Enabling 64-bit DMA bypass^M
> [ 1.155749][ T1] pci 0005:01:00.0: Adding to iommu group 0^M
> [ 1.160543][ T1] pci 0005:00:00.0: enabling device (0105 -> 0107)^M
>
> in both cases, but (exmple nvme) I don't see
>
> [ 13.520561][ T11] nvme nvme0: pci function 0005:01:00.0^M
> [ 13.521747][ T45] nvme 0005:01:00.0: enabling device (0100 -> 0102)^M
>
> after this patch has been applied.
>
> Reverting th patch plus its fix resolves the problem.
>
> Bisect log attached.
Hi Guenter,
Thanks for the report.
Can you please give me the following details:
* The DTS file for the board (not the SoC).
* A boot log with the logs enabled in device_links_check_suppliers()
and device_link_add()
That should help me debug this.
Rob,
Looks like Guenter has this patch[1] too. What PPC specific IRQ hack
am I missing? Any ideas?
[1] - https://lore.kernel.org/lkml/20210209010439.3529036-1-saravanak@google.com/
Thanks,
Saravana
next prev parent reply other threads:[~2021-02-14 21:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 22:57 [PATCH v2 0/2] of: property: Add fw_devlink support for more props Saravana Kannan
2021-01-21 22:57 ` [PATCH v2 1/2] of: property: Add fw_devlink support for "gpio" and "gpios" binding Saravana Kannan
2021-01-22 12:58 ` Linus Walleij
2021-01-21 22:57 ` [PATCH v2 2/2] of: property: Add fw_devlink support for interrupts Saravana Kannan
[not found] ` <CGME20210204115252eucas1p2d145686f7a5dc7e7a04dddd0b0f2286c@eucas1p2.samsung.com>
2021-02-04 11:52 ` Marek Szyprowski
2021-02-04 21:31 ` Saravana Kannan
2021-02-05 7:38 ` Marek Szyprowski
2021-02-05 8:06 ` Geert Uytterhoeven
2021-02-05 10:05 ` Saravana Kannan
2021-02-05 10:20 ` Geert Uytterhoeven
2021-02-05 17:19 ` Saravana Kannan
2021-02-05 17:51 ` Geert Uytterhoeven
2021-02-05 17:55 ` Saravana Kannan
2021-02-06 4:32 ` Saravana Kannan
2021-02-08 8:14 ` Marek Szyprowski
2021-02-08 23:57 ` Saravana Kannan
2021-02-13 18:54 ` Guenter Roeck
2021-02-14 21:12 ` Saravana Kannan [this message]
2021-02-15 3:06 ` Guenter Roeck
2021-02-15 3:58 ` Guenter Roeck
2021-02-15 8:29 ` Saravana Kannan
2021-02-15 9:08 ` Marc Zyngier
2021-02-15 22:23 ` Saravana Kannan
2021-01-26 8:22 ` [PATCH v2 0/2] of: property: Add fw_devlink support for more props Greg Kroah-Hartman
[not found] ` <20210131163823.c4zb47pl4tukcl7c@viti.kaiser.cx>
2021-01-31 21:05 ` Saravana Kannan
2021-02-01 10:52 ` Martin Kaiser
2021-02-01 20:04 ` Saravana Kannan
[not found] <20210121191637.1067630-1-saravanak@google.com>
2021-01-21 19:16 ` [PATCH v2 2/2] of: property: Add fw_devlink support for interrupts Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGETcx_RpG45Fwhty1Uj34Mv01qkH5vFv0J6jVtJgTBFQinOBA@mail.gmail.com \
--to=saravanak@google.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=kernel-team@android.com \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).