* Re: [PATCH] hwmon: SENSORS_SBTSI should depend on X86
@ 2020-12-16 16:31 Guenter Roeck
2020-12-16 17:27 ` Kun Yi
0 siblings, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2020-12-16 16:31 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Jean Delvare, Kun Yi, linux-hwmon, linux-kernel
On Wed, Dec 16, 2020 at 02:46:41PM +0100, Geert Uytterhoeven wrote:
> The AMD SB Temperature Sensor Interface (SB-TSI) is only present on AMD
> X86 SoCs. Hence add a dependency on X86, to prevent asking the user
> about this driver when configuring a kernel without AMD X86 platform
> support.
>
> Fixes: e7bb1a2ab8c4b156 ("hwmon: (sbtsi) Add basic support for SB-TSI sensors")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Makes sense. Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 1ecf697d8d99b70c..63d28f98108d4bb5 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -1536,6 +1536,7 @@ config SENSORS_SL28CPLD
> config SENSORS_SBTSI
> tristate "Emulated SB-TSI temperature sensor"
> depends on I2C
> + depends on X86 || COMPILE_TEST
> help
> If you say yes here you get support for emulated temperature
> sensors on AMD SoCs with SB-TSI interface connected to a BMC device.
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hwmon: SENSORS_SBTSI should depend on X86
2020-12-16 16:31 [PATCH] hwmon: SENSORS_SBTSI should depend on X86 Guenter Roeck
@ 2020-12-16 17:27 ` Kun Yi
2020-12-16 20:17 ` Guenter Roeck
0 siblings, 1 reply; 5+ messages in thread
From: Kun Yi @ 2020-12-16 17:27 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Geert Uytterhoeven, Jean Delvare, linux-hwmon, linux-kernel
On Wed, Dec 16, 2020 at 8:31 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On Wed, Dec 16, 2020 at 02:46:41PM +0100, Geert Uytterhoeven wrote:
> > The AMD SB Temperature Sensor Interface (SB-TSI) is only present on AMD
> > X86 SoCs. Hence add a dependency on X86, to prevent asking the user
> > about this driver when configuring a kernel without AMD X86 platform
> > support.
Sorry, I think there is some confusion. AMD SoC is a 'remote sensor',
or the client, whereas the device using the SB-TSI hwmon driver is the
master.
In industry, a typical scenario is ARM-based Board Management
Controllers (BMCs) using SB-TSI to monitor the host CPU temperature.
> >
> > Fixes: e7bb1a2ab8c4b156 ("hwmon: (sbtsi) Add basic support for SB-TSI sensors")
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Makes sense. Applied.
>
> Thanks,
> Guenter
>
> > ---
> > drivers/hwmon/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> > index 1ecf697d8d99b70c..63d28f98108d4bb5 100644
> > --- a/drivers/hwmon/Kconfig
> > +++ b/drivers/hwmon/Kconfig
> > @@ -1536,6 +1536,7 @@ config SENSORS_SL28CPLD
> > config SENSORS_SBTSI
> > tristate "Emulated SB-TSI temperature sensor"
> > depends on I2C
> > + depends on X86 || COMPILE_TEST
> > help
> > If you say yes here you get support for emulated temperature
> > sensors on AMD SoCs with SB-TSI interface connected to a BMC device.
> > --
> > 2.25.1
> >
--
Regards,
Kun
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hwmon: SENSORS_SBTSI should depend on X86
2020-12-16 17:27 ` Kun Yi
@ 2020-12-16 20:17 ` Guenter Roeck
2020-12-17 8:07 ` Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2020-12-16 20:17 UTC (permalink / raw)
To: Kun Yi; +Cc: Geert Uytterhoeven, Jean Delvare, linux-hwmon, linux-kernel
On Wed, Dec 16, 2020 at 09:27:28AM -0800, Kun Yi wrote:
> On Wed, Dec 16, 2020 at 8:31 AM Guenter Roeck <linux@roeck-us.net> wrote:
> >
> > On Wed, Dec 16, 2020 at 02:46:41PM +0100, Geert Uytterhoeven wrote:
> > > The AMD SB Temperature Sensor Interface (SB-TSI) is only present on AMD
> > > X86 SoCs. Hence add a dependency on X86, to prevent asking the user
> > > about this driver when configuring a kernel without AMD X86 platform
> > > support.
>
> Sorry, I think there is some confusion. AMD SoC is a 'remote sensor',
> or the client, whereas the device using the SB-TSI hwmon driver is the
> master.
> In industry, a typical scenario is ARM-based Board Management
> Controllers (BMCs) using SB-TSI to monitor the host CPU temperature.
>
Ah, good point. I'll drop this patch.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwmon: SENSORS_SBTSI should depend on X86
2020-12-16 20:17 ` Guenter Roeck
@ 2020-12-17 8:07 ` Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2020-12-17 8:07 UTC (permalink / raw)
To: Kun Yi, Guenter Roeck
Cc: Jean Delvare, linux-hwmon, Linux Kernel Mailing List
Hi Kun, Günter,
On Wed, Dec 16, 2020 at 9:17 PM Guenter Roeck <linux@roeck-us.net> wrote:
> On Wed, Dec 16, 2020 at 09:27:28AM -0800, Kun Yi wrote:
> > On Wed, Dec 16, 2020 at 8:31 AM Guenter Roeck <linux@roeck-us.net> wrote:
> > >
> > > On Wed, Dec 16, 2020 at 02:46:41PM +0100, Geert Uytterhoeven wrote:
> > > > The AMD SB Temperature Sensor Interface (SB-TSI) is only present on AMD
> > > > X86 SoCs. Hence add a dependency on X86, to prevent asking the user
> > > > about this driver when configuring a kernel without AMD X86 platform
> > > > support.
> >
> > Sorry, I think there is some confusion. AMD SoC is a 'remote sensor',
> > or the client, whereas the device using the SB-TSI hwmon driver is the
> > master.
> > In industry, a typical scenario is ARM-based Board Management
> > Controllers (BMCs) using SB-TSI to monitor the host CPU temperature.
Thanks for the explanation!
> Ah, good point. I'll drop this patch.
Agreed.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] hwmon: SENSORS_SBTSI should depend on X86
@ 2020-12-16 13:46 Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2020-12-16 13:46 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck, Kun Yi
Cc: linux-hwmon, linux-kernel, Geert Uytterhoeven
The AMD SB Temperature Sensor Interface (SB-TSI) is only present on AMD
X86 SoCs. Hence add a dependency on X86, to prevent asking the user
about this driver when configuring a kernel without AMD X86 platform
support.
Fixes: e7bb1a2ab8c4b156 ("hwmon: (sbtsi) Add basic support for SB-TSI sensors")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/hwmon/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 1ecf697d8d99b70c..63d28f98108d4bb5 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -1536,6 +1536,7 @@ config SENSORS_SL28CPLD
config SENSORS_SBTSI
tristate "Emulated SB-TSI temperature sensor"
depends on I2C
+ depends on X86 || COMPILE_TEST
help
If you say yes here you get support for emulated temperature
sensors on AMD SoCs with SB-TSI interface connected to a BMC device.
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-12-17 8:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-16 16:31 [PATCH] hwmon: SENSORS_SBTSI should depend on X86 Guenter Roeck
2020-12-16 17:27 ` Kun Yi
2020-12-16 20:17 ` Guenter Roeck
2020-12-17 8:07 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2020-12-16 13:46 Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).