linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] PM / devfreq: Replace devfreq->dev.parent as dev in devfreq_add_device
@ 2020-12-16  2:25 pierre Kuo
  2020-12-28 15:21 ` pierre kuo
  0 siblings, 1 reply; 3+ messages in thread
From: pierre Kuo @ 2020-12-16  2:25 UTC (permalink / raw)
  To: myungjoo.ham, kyungmin.park, cw00.choi; +Cc: linux-pm, linux-kernel, pierre Kuo

In devfreq_add_device, replace devfreq->dev.parent
as dev to keep code simple.

Signed-off-by: pierre Kuo <vichy.kuo@gmail.com>
---
 drivers/devfreq/devfreq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 6aa10de792b3..94cc25fd68da 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -893,13 +893,13 @@ struct devfreq *devfreq_add_device(struct device *dev,
 		goto err_devfreq;
 
 	devfreq->nb_min.notifier_call = qos_min_notifier_call;
-	err = dev_pm_qos_add_notifier(devfreq->dev.parent, &devfreq->nb_min,
+	err = dev_pm_qos_add_notifier(dev, &devfreq->nb_min,
 				      DEV_PM_QOS_MIN_FREQUENCY);
 	if (err)
 		goto err_devfreq;
 
 	devfreq->nb_max.notifier_call = qos_max_notifier_call;
-	err = dev_pm_qos_add_notifier(devfreq->dev.parent, &devfreq->nb_max,
+	err = dev_pm_qos_add_notifier(dev, &devfreq->nb_max,
 				      DEV_PM_QOS_MAX_FREQUENCY);
 	if (err)
 		goto err_devfreq;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] PM / devfreq: Replace devfreq->dev.parent as dev in devfreq_add_device
  2020-12-16  2:25 [PATCH 1/1] PM / devfreq: Replace devfreq->dev.parent as dev in devfreq_add_device pierre Kuo
@ 2020-12-28 15:21 ` pierre kuo
  2021-01-05  1:03   ` Chanwoo Choi
  0 siblings, 1 reply; 3+ messages in thread
From: pierre kuo @ 2020-12-28 15:21 UTC (permalink / raw)
  To: myungjoo.ham, kyungmin.park, cw00.choi
  Cc: Linux PM list, Linux Kernel Mailing List

Hi myungjoo, kyungmin and cw:
Would you please help to review this patch?

Thanks a lot.

pierre Kuo <vichy.kuo@gmail.com> 於 2020年12月16日 週三 上午10:26寫道:
>
> In devfreq_add_device, replace devfreq->dev.parent
> as dev to keep code simple.
>
> Signed-off-by: pierre Kuo <vichy.kuo@gmail.com>
> ---
>  drivers/devfreq/devfreq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 6aa10de792b3..94cc25fd68da 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -893,13 +893,13 @@ struct devfreq *devfreq_add_device(struct device *dev,
>                 goto err_devfreq;
>
>         devfreq->nb_min.notifier_call = qos_min_notifier_call;
> -       err = dev_pm_qos_add_notifier(devfreq->dev.parent, &devfreq->nb_min,
> +       err = dev_pm_qos_add_notifier(dev, &devfreq->nb_min,
>                                       DEV_PM_QOS_MIN_FREQUENCY);
>         if (err)
>                 goto err_devfreq;
>
>         devfreq->nb_max.notifier_call = qos_max_notifier_call;
> -       err = dev_pm_qos_add_notifier(devfreq->dev.parent, &devfreq->nb_max,
> +       err = dev_pm_qos_add_notifier(dev, &devfreq->nb_max,
>                                       DEV_PM_QOS_MAX_FREQUENCY);
>         if (err)
>                 goto err_devfreq;
> --
> 2.17.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] PM / devfreq: Replace devfreq->dev.parent as dev in devfreq_add_device
  2020-12-28 15:21 ` pierre kuo
@ 2021-01-05  1:03   ` Chanwoo Choi
  0 siblings, 0 replies; 3+ messages in thread
From: Chanwoo Choi @ 2021-01-05  1:03 UTC (permalink / raw)
  To: pierre kuo
  Cc: MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Linux PM list,
	Linux Kernel Mailing List

On Tue, Dec 29, 2020 at 12:25 AM pierre kuo <vichy.kuo@gmail.com> wrote:
>
> Hi myungjoo, kyungmin and cw:
> Would you please help to review this patch?
>
> Thanks a lot.
>
> pierre Kuo <vichy.kuo@gmail.com> 於 2020年12月16日 週三 上午10:26寫道:
> >
> > In devfreq_add_device, replace devfreq->dev.parent
> > as dev to keep code simple.
> >
> > Signed-off-by: pierre Kuo <vichy.kuo@gmail.com>
> > ---
> >  drivers/devfreq/devfreq.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> > index 6aa10de792b3..94cc25fd68da 100644
> > --- a/drivers/devfreq/devfreq.c
> > +++ b/drivers/devfreq/devfreq.c
> > @@ -893,13 +893,13 @@ struct devfreq *devfreq_add_device(struct device *dev,
> >                 goto err_devfreq;
> >
> >         devfreq->nb_min.notifier_call = qos_min_notifier_call;
> > -       err = dev_pm_qos_add_notifier(devfreq->dev.parent, &devfreq->nb_min,
> > +       err = dev_pm_qos_add_notifier(dev, &devfreq->nb_min,
> >                                       DEV_PM_QOS_MIN_FREQUENCY);
> >         if (err)
> >                 goto err_devfreq;
> >
> >         devfreq->nb_max.notifier_call = qos_max_notifier_call;
> > -       err = dev_pm_qos_add_notifier(devfreq->dev.parent, &devfreq->nb_max,
> > +       err = dev_pm_qos_add_notifier(dev, &devfreq->nb_max,
> >                                       DEV_PM_QOS_MAX_FREQUENCY);
> >         if (err)
> >                 goto err_devfreq;
> > --
> > 2.17.1
> >

Applied it. Thanks.


-- 
Best Regards,
Chanwoo Choi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-05  1:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-16  2:25 [PATCH 1/1] PM / devfreq: Replace devfreq->dev.parent as dev in devfreq_add_device pierre Kuo
2020-12-28 15:21 ` pierre kuo
2021-01-05  1:03   ` Chanwoo Choi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).