linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] driver: zram: fix wrong counting on pages_store
@ 2021-07-20  6:47 Huangzhaoyang
  2021-07-25  1:19 ` [Resend PATCH] " Zhaoyang Huang
  2021-07-26  1:27 ` [PATCH] " Sergey Senozhatsky
  0 siblings, 2 replies; 6+ messages in thread
From: Huangzhaoyang @ 2021-07-20  6:47 UTC (permalink / raw)
  To: Minchan Kim, Zhaoyang Huang, linux-mm, linux-kernel, Nitin Gupta,
	Sergey Senozhatsky

From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>

It makes the statistic confused when counting pages_store in during writeback.
pages_store should just reflect the swapped pages on ZRAM, while bd_writes be
responsible for writeback things.

Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
---
 drivers/block/zram/zram_drv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index cf8deec..6bdaa9d 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -765,7 +765,6 @@ static ssize_t writeback_store(struct device *dev,
 		zram_set_flag(zram, index, ZRAM_WB);
 		zram_set_element(zram, index, blk_idx);
 		blk_idx = 0;
-		atomic64_inc(&zram->stats.pages_stored);
 		spin_lock(&zram->wb_limit_lock);
 		if (zram->wb_limit_enable && zram->bd_wb_limit > 0)
 			zram->bd_wb_limit -=  1UL << (PAGE_SHIFT - 12);
-- 
1.9.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-07-27  5:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-20  6:47 [PATCH] driver: zram: fix wrong counting on pages_store Huangzhaoyang
2021-07-25  1:19 ` [Resend PATCH] " Zhaoyang Huang
2021-07-26  1:27 ` [PATCH] " Sergey Senozhatsky
2021-07-26 17:53   ` Minchan Kim
2021-07-27  1:32     ` Zhaoyang Huang
2021-07-27  5:45       ` Zhaoyang Huang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).