linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: remove judgement based on gfp_flags
@ 2021-12-23  1:56 Huangzhaoyang
  2021-12-23 17:11 ` Jakub Kicinski
  2022-01-04  2:57 ` [net] 6f87debdea: BUG:scheduling_while_atomic kernel test robot
  0 siblings, 2 replies; 6+ messages in thread
From: Huangzhaoyang @ 2021-12-23  1:56 UTC (permalink / raw)
  To: David S. Miller, Jakub Kicinski, Zhaoyang Huang, netdev, linux-kernel

From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>

The parameter allocation here is used for indicating if the memory
allocation can stall or not. Since we have got the skb buffer, it
doesn't make sense to check if we can yield on the net's congested
via gfp_flags. Remove it now.

Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
---
 net/netlink/af_netlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 4c57532..af5b6af 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -1526,7 +1526,7 @@ int netlink_broadcast(struct sock *ssk, struct sk_buff *skb, u32 portid,
 	consume_skb(info.skb2);
 
 	if (info.delivered) {
-		if (info.congested && gfpflags_allow_blocking(allocation))
+		if (info.congested)
 			yield();
 		return 0;
 	}
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-01-04  2:58 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-23  1:56 [PATCH] net: remove judgement based on gfp_flags Huangzhaoyang
2021-12-23 17:11 ` Jakub Kicinski
2021-12-27  6:14   ` Zhaoyang Huang
2021-12-27  7:38     ` Zhaoyang Huang
2021-12-28  2:02       ` Jakub Kicinski
2022-01-04  2:57 ` [net] 6f87debdea: BUG:scheduling_while_atomic kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).