linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Ivan Delalande <colona@arista.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] lkdtm: fix handle_irq_event symbol for INT_HW_IRQ_EN
Date: Thu, 25 Jan 2018 13:35:03 +1100	[thread overview]
Message-ID: <CAGXu5j+MR-Juf15V19CmRNVu34a-B8O8XVeERjJBVxFZsAOWmA@mail.gmail.com> (raw)
In-Reply-To: <20180125011622.GA7642@visor>

On Thu, Jan 25, 2018 at 12:16 PM, Ivan Delalande <colona@arista.com> wrote:
> Function handle_IRQ_event was retired in v2.6.39 and replaced with
> handle_irq_event but nobody changed it in lkdtm so INT_HW_IRQ_EN has
> been broken for a while.

Excellent, thanks for the fix!

Acked-by: Kees Cook <keescook@chromium.org>

Greg, I don't have any other exclusive lkdtm updates, so please feel
free to apply this to misc-next.

Thanks!

-Kees

>
> Fixes: 33b054b867b8 ("genirq: Remove handle_IRQ_event")
> Signed-off-by: Travis Brown <travisb@arista.com>
> Signed-off-by: Ivan Delalande <colona@arista.com>
> ---
>  drivers/misc/lkdtm_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/lkdtm_core.c b/drivers/misc/lkdtm_core.c
> index ba92291508dc..4942da93d066 100644
> --- a/drivers/misc/lkdtm_core.c
> +++ b/drivers/misc/lkdtm_core.c
> @@ -96,7 +96,7 @@ static struct crashpoint crashpoints[] = {
>         CRASHPOINT("DIRECT",             NULL),
>  #ifdef CONFIG_KPROBES
>         CRASHPOINT("INT_HARDWARE_ENTRY", "do_IRQ"),
> -       CRASHPOINT("INT_HW_IRQ_EN",      "handle_IRQ_event"),
> +       CRASHPOINT("INT_HW_IRQ_EN",      "handle_irq_event"),
>         CRASHPOINT("INT_TASKLET_ENTRY",  "tasklet_action"),
>         CRASHPOINT("FS_DEVRW",           "ll_rw_block"),
>         CRASHPOINT("MEM_SWAPOUT",        "shrink_inactive_list"),
> --
> 2.16.1



-- 
Kees Cook
Pixel Security

      reply	other threads:[~2018-01-25  2:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-25  1:16 [PATCH] lkdtm: fix handle_irq_event symbol for INT_HW_IRQ_EN Ivan Delalande
2018-01-25  2:35 ` Kees Cook [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGXu5j+MR-Juf15V19CmRNVu34a-B8O8XVeERjJBVxFZsAOWmA@mail.gmail.com \
    --to=keescook@chromium.org \
    --cc=arnd@arndb.de \
    --cc=colona@arista.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).