* [PATCH] lkdtm: fix handle_irq_event symbol for INT_HW_IRQ_EN
@ 2018-01-25 1:16 Ivan Delalande
2018-01-25 2:35 ` Kees Cook
0 siblings, 1 reply; 2+ messages in thread
From: Ivan Delalande @ 2018-01-25 1:16 UTC (permalink / raw)
To: Greg Kroah-Hartman, Kees Cook
Cc: Arnd Bergmann, Thomas Gleixner, linux-kernel
Function handle_IRQ_event was retired in v2.6.39 and replaced with
handle_irq_event but nobody changed it in lkdtm so INT_HW_IRQ_EN has
been broken for a while.
Fixes: 33b054b867b8 ("genirq: Remove handle_IRQ_event")
Signed-off-by: Travis Brown <travisb@arista.com>
Signed-off-by: Ivan Delalande <colona@arista.com>
Acked-by: Kees Cook <keescook@chromium.org>
---
drivers/misc/lkdtm_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/lkdtm_core.c b/drivers/misc/lkdtm_core.c
index ba92291508dc..4942da93d066 100644
--- a/drivers/misc/lkdtm_core.c
+++ b/drivers/misc/lkdtm_core.c
@@ -96,7 +96,7 @@ static struct crashpoint crashpoints[] = {
CRASHPOINT("DIRECT", NULL),
#ifdef CONFIG_KPROBES
CRASHPOINT("INT_HARDWARE_ENTRY", "do_IRQ"),
- CRASHPOINT("INT_HW_IRQ_EN", "handle_IRQ_event"),
+ CRASHPOINT("INT_HW_IRQ_EN", "handle_irq_event"),
CRASHPOINT("INT_TASKLET_ENTRY", "tasklet_action"),
CRASHPOINT("FS_DEVRW", "ll_rw_block"),
CRASHPOINT("MEM_SWAPOUT", "shrink_inactive_list"),
--
2.16.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] lkdtm: fix handle_irq_event symbol for INT_HW_IRQ_EN
2018-01-25 1:16 [PATCH] lkdtm: fix handle_irq_event symbol for INT_HW_IRQ_EN Ivan Delalande
@ 2018-01-25 2:35 ` Kees Cook
0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2018-01-25 2:35 UTC (permalink / raw)
To: Ivan Delalande, Greg Kroah-Hartman; +Cc: Arnd Bergmann, Thomas Gleixner, LKML
On Thu, Jan 25, 2018 at 12:16 PM, Ivan Delalande <colona@arista.com> wrote:
> Function handle_IRQ_event was retired in v2.6.39 and replaced with
> handle_irq_event but nobody changed it in lkdtm so INT_HW_IRQ_EN has
> been broken for a while.
Excellent, thanks for the fix!
Acked-by: Kees Cook <keescook@chromium.org>
Greg, I don't have any other exclusive lkdtm updates, so please feel
free to apply this to misc-next.
Thanks!
-Kees
>
> Fixes: 33b054b867b8 ("genirq: Remove handle_IRQ_event")
> Signed-off-by: Travis Brown <travisb@arista.com>
> Signed-off-by: Ivan Delalande <colona@arista.com>
> ---
> drivers/misc/lkdtm_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/lkdtm_core.c b/drivers/misc/lkdtm_core.c
> index ba92291508dc..4942da93d066 100644
> --- a/drivers/misc/lkdtm_core.c
> +++ b/drivers/misc/lkdtm_core.c
> @@ -96,7 +96,7 @@ static struct crashpoint crashpoints[] = {
> CRASHPOINT("DIRECT", NULL),
> #ifdef CONFIG_KPROBES
> CRASHPOINT("INT_HARDWARE_ENTRY", "do_IRQ"),
> - CRASHPOINT("INT_HW_IRQ_EN", "handle_IRQ_event"),
> + CRASHPOINT("INT_HW_IRQ_EN", "handle_irq_event"),
> CRASHPOINT("INT_TASKLET_ENTRY", "tasklet_action"),
> CRASHPOINT("FS_DEVRW", "ll_rw_block"),
> CRASHPOINT("MEM_SWAPOUT", "shrink_inactive_list"),
> --
> 2.16.1
--
Kees Cook
Pixel Security
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-25 2:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-25 1:16 [PATCH] lkdtm: fix handle_irq_event symbol for INT_HW_IRQ_EN Ivan Delalande
2018-01-25 2:35 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).