* [PATCH] selftests: pstore: return Kselftest Skip code for skipped tests
@ 2018-06-12 23:22 Shuah Khan (Samsung OSG)
2018-06-13 0:02 ` Kees Cook
0 siblings, 1 reply; 2+ messages in thread
From: Shuah Khan (Samsung OSG) @ 2018-06-12 23:22 UTC (permalink / raw)
To: shuah, keescook, anton, ccross, tony.luck; +Cc: linux-kselftest, linux-kernel
When pstore_post_reboot test gets skipped because of unmet dependencies
and/or unsupported configuration, it returns 0 which is treated as a pass
by the Kselftest framework. This leads to false positive result even when
the test could not be run.
Change it to return kselftest skip code when a test gets skipped to clearly
report that the test could not be run.
Kselftest framework SKIP code is 4 and the framework prints appropriate
messages to indicate that the test is skipped.
Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
---
tools/testing/selftests/pstore/pstore_post_reboot_tests | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/pstore/pstore_post_reboot_tests b/tools/testing/selftests/pstore/pstore_post_reboot_tests
index 6ccb154cb4aa..22f8df1ad7d4 100755
--- a/tools/testing/selftests/pstore/pstore_post_reboot_tests
+++ b/tools/testing/selftests/pstore/pstore_post_reboot_tests
@@ -7,13 +7,16 @@
#
# Released under the terms of the GPL v2.
+# Kselftest framework requirement - SKIP code is 4.
+ksft_skip=4
+
. ./common_tests
if [ -e $REBOOT_FLAG ]; then
rm $REBOOT_FLAG
else
prlog "pstore_crash_test has not been executed yet. we skip further tests."
- exit 0
+ exit $ksft_skip
fi
prlog -n "Mounting pstore filesystem ... "
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests: pstore: return Kselftest Skip code for skipped tests
2018-06-12 23:22 [PATCH] selftests: pstore: return Kselftest Skip code for skipped tests Shuah Khan (Samsung OSG)
@ 2018-06-13 0:02 ` Kees Cook
0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2018-06-13 0:02 UTC (permalink / raw)
To: Shuah Khan (Samsung OSG)
Cc: Anton Vorontsov, Colin Cross, Tony Luck,
open list:KERNEL SELFTEST FRAMEWORK, LKML
On Tue, Jun 12, 2018 at 4:22 PM, Shuah Khan (Samsung OSG)
<shuah@kernel.org> wrote:
> When pstore_post_reboot test gets skipped because of unmet dependencies
> and/or unsupported configuration, it returns 0 which is treated as a pass
> by the Kselftest framework. This leads to false positive result even when
> the test could not be run.
>
> Change it to return kselftest skip code when a test gets skipped to clearly
> report that the test could not be run.
>
> Kselftest framework SKIP code is 4 and the framework prints appropriate
> messages to indicate that the test is skipped.
>
> Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Thanks!
-Kees
> ---
> tools/testing/selftests/pstore/pstore_post_reboot_tests | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/pstore/pstore_post_reboot_tests b/tools/testing/selftests/pstore/pstore_post_reboot_tests
> index 6ccb154cb4aa..22f8df1ad7d4 100755
> --- a/tools/testing/selftests/pstore/pstore_post_reboot_tests
> +++ b/tools/testing/selftests/pstore/pstore_post_reboot_tests
> @@ -7,13 +7,16 @@
> #
> # Released under the terms of the GPL v2.
>
> +# Kselftest framework requirement - SKIP code is 4.
> +ksft_skip=4
> +
> . ./common_tests
>
> if [ -e $REBOOT_FLAG ]; then
> rm $REBOOT_FLAG
> else
> prlog "pstore_crash_test has not been executed yet. we skip further tests."
> - exit 0
> + exit $ksft_skip
> fi
>
> prlog -n "Mounting pstore filesystem ... "
> --
> 2.17.0
>
--
Kees Cook
Pixel Security
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-13 0:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-12 23:22 [PATCH] selftests: pstore: return Kselftest Skip code for skipped tests Shuah Khan (Samsung OSG)
2018-06-13 0:02 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).