From: Kees Cook <keescook@chromium.org>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Elena Reshetova <elena.reshetova@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Greg KH <gregkh@linuxfoundation.org>,
Ingo Molnar <mingo@redhat.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
arozansk@redhat.com, Hans Liljestrand <ishkamiel@gmail.com>,
David Windsor <dwindsor@gmail.com>
Subject: Re: [PATCH 1/3] ipc: convert ipc_namespace.count from atomic_t to refcount_t
Date: Wed, 19 Jul 2017 17:32:10 -0700 [thread overview]
Message-ID: <CAGXu5jJOwMk2--EzLM5X+BQPAXzNGzOyAzbe9AdUWEtTEeLdnw@mail.gmail.com> (raw)
In-Reply-To: <CAGXu5jKFfoYA-rnP8cTDUMxODLOsqXzhB1za6zrZ2q6LPafogw@mail.gmail.com>
On Wed, Jul 19, 2017 at 4:20 PM, Kees Cook <keescook@chromium.org> wrote:
> On Wed, Jul 19, 2017 at 4:11 PM, Davidlohr Bueso <dave@stgolabs.net> wrote:
>> May I suggest using mmtests with the following config file:
>>
>> https://github.com/gormanm/mmtests/blob/7e070a810bc0af92e592e5121d0ea75fada51aeb/configs/config-global-dhp__workload-ipc-scale-short
>>
>> It will run two of Manfred's ipcscale sem benchmarks.
>
> I'll see if I can figure out how to use this for testing the fast
> refcount protection:
> https://lkml.org/lkml/2017/7/18/1223
>
> Then we could see:
>
> before conversion
> after conversion
> with CONFIG_REFCOUNT_FULL
> with fast refcount protection
I have no idea how to read this report. It seems to be mostly noise
(multiple baseline runs seem to show greater variability than compared
against the other possible results).
Test runs were atomic_t, atomic_t-2, refcount_t, refcount-full, and
refcount-fast. (Two baselines, refcount_t conversion, with FULL, and
with the fast implementation.) Output here:
http://pastebin.ubuntu.com/25129382/
-Kees
--
Kees Cook
Pixel Security
next prev parent reply other threads:[~2017-07-20 0:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 8:59 [PATCH 0/3] v2 ipc subsystem refcount coversions Elena Reshetova
2017-07-07 8:59 ` [PATCH 1/3] ipc: convert ipc_namespace.count from atomic_t to refcount_t Elena Reshetova
2017-07-09 21:59 ` Eric W. Biederman
2017-07-10 6:48 ` Reshetova, Elena
2017-07-10 8:37 ` Eric W. Biederman
2017-07-10 9:34 ` Alexey Dobriyan
2017-07-10 11:19 ` Eric W. Biederman
2017-07-10 9:56 ` Reshetova, Elena
2017-07-10 11:26 ` Eric W. Biederman
2017-07-10 12:11 ` Reshetova, Elena
2017-07-10 20:32 ` Eric W. Biederman
2017-07-12 9:21 ` Reshetova, Elena
2017-07-19 22:35 ` Andrew Morton
2017-07-19 22:54 ` Davidlohr Bueso
2017-07-19 22:58 ` Andrew Morton
2017-07-19 23:11 ` Davidlohr Bueso
2017-07-19 23:20 ` Kees Cook
2017-07-20 0:32 ` Kees Cook [this message]
2017-07-20 9:34 ` Ingo Molnar
2017-07-20 12:34 ` Eric W. Biederman
2017-07-20 15:12 ` Kees Cook
2017-07-07 8:59 ` [PATCH 2/3] ipc: convert sem_undo_list.refcnt " Elena Reshetova
2017-07-07 8:59 ` [PATCH 3/3] ipc: convert kern_ipc_perm.refcount " Elena Reshetova
-- strict thread matches above, loose matches on Subject: below --
2017-02-20 11:29 [PATCH 0/3] ipc subsystem refcounter conversions Elena Reshetova
2017-02-20 11:29 ` [PATCH 1/3] ipc: convert ipc_namespace.count from atomic_t to refcount_t Elena Reshetova
2017-05-27 19:41 ` Kees Cook
2017-05-28 12:10 ` Manfred Spraul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5jJOwMk2--EzLM5X+BQPAXzNGzOyAzbe9AdUWEtTEeLdnw@mail.gmail.com \
--to=keescook@chromium.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arozansk@redhat.com \
--cc=dave@stgolabs.net \
--cc=dwindsor@gmail.com \
--cc=ebiederm@xmission.com \
--cc=elena.reshetova@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ishkamiel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).