From: Manfred Spraul <manfred@colorfullife.com>
To: Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Elena Reshetova <elena.reshetova@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Greg KH <gregkh@linuxfoundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Ingo Molnar <mingo@redhat.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
arozansk@redhat.com, Davidlohr Bueso <dave@stgolabs.net>,
Hans Liljestrand <ishkamiel@gmail.com>,
David Windsor <dwindsor@gmail.com>
Subject: Re: [PATCH 1/3] ipc: convert ipc_namespace.count from atomic_t to refcount_t
Date: Sun, 28 May 2017 14:10:40 +0200 [thread overview]
Message-ID: <ea372e4f-0c0e-9ce3-dcb8-d36806003ec9@colorfullife.com> (raw)
In-Reply-To: <CAGXu5jKx+CXvEWVxbSM7awa5+yE8aS3dNXyi89tbitzX2EPhPg@mail.gmail.com>
On 05/27/2017 09:41 PM, Kees Cook wrote:
> On Mon, Feb 20, 2017 at 3:29 AM, Elena Reshetova
> <elena.reshetova@intel.com> wrote:
>> refcount_t type and corresponding API should be
>> used instead of atomic_t when the variable is used as
>> a reference counter. This allows to avoid accidental
>> refcounter overflows that might lead to use-after-free
>> situations.
>>
>> Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
>> Signed-off-by: Hans Liljestrand <ishkamiel@gmail.com>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>> Signed-off-by: David Windsor <dwindsor@gmail.com>
> Manfred, is this okay by you? I think this should go via -mm...
The patch is ok, the refcounters are not in the critical path.
I'll try to test the patches and then I would send an 'Acked-by', but
this will take some days.
--
Manfred
next prev parent reply other threads:[~2017-05-28 12:10 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 11:29 [PATCH 0/3] ipc subsystem refcounter conversions Elena Reshetova
2017-02-20 11:29 ` [PATCH 1/3] ipc: convert ipc_namespace.count from atomic_t to refcount_t Elena Reshetova
2017-05-27 19:41 ` Kees Cook
2017-05-28 12:10 ` Manfred Spraul [this message]
2017-02-20 11:29 ` [PATCH 2/3] ipc: convert sem_undo_list.refcnt " Elena Reshetova
2017-05-27 19:44 ` Kees Cook
2017-02-20 11:29 ` [PATCH 3/3] ipc: convert ipc_rcu.refcount " Elena Reshetova
2017-05-27 19:47 ` Kees Cook
2017-02-20 11:42 ` [PATCH 0/3] ipc subsystem refcounter conversions Andy Shevchenko
2017-02-20 12:30 ` Reshetova, Elena
2017-02-22 15:41 ` Davidlohr Bueso
2017-03-04 0:23 ` Andrew Morton
2017-03-06 9:51 ` Reshetova, Elena
2017-05-27 19:58 ` Kees Cook
2017-05-29 8:39 ` Christoph Hellwig
2017-05-29 9:11 ` Eric W. Biederman
2017-05-29 10:24 ` Peter Zijlstra
2017-05-29 10:49 ` Eric W. Biederman
2017-05-29 11:30 ` Eric W. Biederman
2017-05-29 11:39 ` Eric W. Biederman
2017-05-29 12:23 ` Peter Zijlstra
2017-05-29 15:43 ` Peter Zijlstra
2017-05-29 12:13 ` Peter Zijlstra
2017-07-07 8:59 [PATCH 0/3] v2 ipc subsystem refcount coversions Elena Reshetova
2017-07-07 8:59 ` [PATCH 1/3] ipc: convert ipc_namespace.count from atomic_t to refcount_t Elena Reshetova
2017-07-09 21:59 ` Eric W. Biederman
2017-07-10 6:48 ` Reshetova, Elena
2017-07-10 8:37 ` Eric W. Biederman
2017-07-10 9:34 ` Alexey Dobriyan
2017-07-10 11:19 ` Eric W. Biederman
2017-07-10 9:56 ` Reshetova, Elena
2017-07-10 11:26 ` Eric W. Biederman
2017-07-10 12:11 ` Reshetova, Elena
2017-07-10 20:32 ` Eric W. Biederman
2017-07-12 9:21 ` Reshetova, Elena
2017-07-19 22:35 ` Andrew Morton
2017-07-19 22:54 ` Davidlohr Bueso
2017-07-19 22:58 ` Andrew Morton
2017-07-19 23:11 ` Davidlohr Bueso
2017-07-19 23:20 ` Kees Cook
2017-07-20 0:32 ` Kees Cook
2017-07-20 9:34 ` Ingo Molnar
2017-07-20 12:34 ` Eric W. Biederman
2017-07-20 15:12 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea372e4f-0c0e-9ce3-dcb8-d36806003ec9@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arozansk@redhat.com \
--cc=dave@stgolabs.net \
--cc=dwindsor@gmail.com \
--cc=ebiederm@xmission.com \
--cc=elena.reshetova@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ishkamiel@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).