From: Kees Cook <keescook@chromium.org>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: James Hughes <jnahughes@gmail.com>, Eric Anholt <eric@anholt.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] firmware: raspberrypi: Fix firmware calls with large buffers
Date: Thu, 15 Nov 2018 12:19:21 -0600 [thread overview]
Message-ID: <CAGXu5jJfypZu=gp5vrB1Xf_Hr-Fpa7YqmXZT2z0MJhZtqR1ubg@mail.gmail.com> (raw)
In-Reply-To: <3ac94357-5860-f9fd-740d-a2cd277fd0a8@i2se.com>
On Thu, Nov 15, 2018 at 10:05 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Hi James,
>
> please look at
> https://www.kernel.org/doc/html/v4.19/process/submitting-patches.html,
> because there are several issues with this patch. Most critical one is
> that i received it not as plain text. Please make sure that send your
> patch with git send-email.
The irony is I had to fight Gmail over your multipart HTML+plain
email. Yay email clients! ;)
> Am 15.11.18 um 14:18 schrieb James Hughes:
> > A previous change (5bfdc1097654) moved away from VLA's
>
> Please use the commit format mentioned in the link above.
And actually, this SHA isn't the upstream SHA. This should be:
a1547e0bca51 ("firmware: raspberrypi: Remove VLA usage")
> > to a fixed maximum size for mailbox data.
> > However, some mailbox calls use larger data buffers
> > than the maximum allowed in that change. This fix therefor
Which ones did this? In the initial change I couldn't find anything
that exceeded 32 bytes. (I'm just curious if I missed something or if
something new appeared.)
> > [...]
> > + /* Some mailboxes can use over 1k bytes. Rather than checking
Up to Eric, but I think the preferred comment style is:
/*
* lines go here
*/
Otherwise, this seems fine to me. Thanks for getting it fixed!
--
Kees Cook
next parent reply other threads:[~2018-11-15 18:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAOtG3WrGCwVd2DWq6Gq_ajZau0xJ-kPMvFRU6HyELYtUr30_VA@mail.gmail.com>
[not found] ` <3ac94357-5860-f9fd-740d-a2cd277fd0a8@i2se.com>
2018-11-15 18:19 ` Kees Cook [this message]
2018-11-15 18:41 ` [PATCH] firmware: raspberrypi: Fix firmware calls with large buffers Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5jJfypZu=gp5vrB1Xf_Hr-Fpa7YqmXZT2z0MJhZtqR1ubg@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=eric@anholt.net \
--cc=jnahughes@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).