* Re: [PATCH] firmware: raspberrypi: Fix firmware calls with large buffers
[not found] ` <3ac94357-5860-f9fd-740d-a2cd277fd0a8@i2se.com>
@ 2018-11-15 18:19 ` Kees Cook
2018-11-15 18:41 ` Eric Anholt
0 siblings, 1 reply; 2+ messages in thread
From: Kees Cook @ 2018-11-15 18:19 UTC (permalink / raw)
To: Stefan Wahren; +Cc: James Hughes, Eric Anholt, LKML
On Thu, Nov 15, 2018 at 10:05 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Hi James,
>
> please look at
> https://www.kernel.org/doc/html/v4.19/process/submitting-patches.html,
> because there are several issues with this patch. Most critical one is
> that i received it not as plain text. Please make sure that send your
> patch with git send-email.
The irony is I had to fight Gmail over your multipart HTML+plain
email. Yay email clients! ;)
> Am 15.11.18 um 14:18 schrieb James Hughes:
> > A previous change (5bfdc1097654) moved away from VLA's
>
> Please use the commit format mentioned in the link above.
And actually, this SHA isn't the upstream SHA. This should be:
a1547e0bca51 ("firmware: raspberrypi: Remove VLA usage")
> > to a fixed maximum size for mailbox data.
> > However, some mailbox calls use larger data buffers
> > than the maximum allowed in that change. This fix therefor
Which ones did this? In the initial change I couldn't find anything
that exceeded 32 bytes. (I'm just curious if I missed something or if
something new appeared.)
> > [...]
> > + /* Some mailboxes can use over 1k bytes. Rather than checking
Up to Eric, but I think the preferred comment style is:
/*
* lines go here
*/
Otherwise, this seems fine to me. Thanks for getting it fixed!
--
Kees Cook
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] firmware: raspberrypi: Fix firmware calls with large buffers
2018-11-15 18:19 ` [PATCH] firmware: raspberrypi: Fix firmware calls with large buffers Kees Cook
@ 2018-11-15 18:41 ` Eric Anholt
0 siblings, 0 replies; 2+ messages in thread
From: Eric Anholt @ 2018-11-15 18:41 UTC (permalink / raw)
To: Kees Cook, Stefan Wahren; +Cc: James Hughes, LKML
[-- Attachment #1: Type: text/plain, Size: 1553 bytes --]
Kees Cook <keescook@chromium.org> writes:
> On Thu, Nov 15, 2018 at 10:05 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
>> Hi James,
>>
>> please look at
>> https://www.kernel.org/doc/html/v4.19/process/submitting-patches.html,
>> because there are several issues with this patch. Most critical one is
>> that i received it not as plain text. Please make sure that send your
>> patch with git send-email.
>
> The irony is I had to fight Gmail over your multipart HTML+plain
> email. Yay email clients! ;)
>
>> Am 15.11.18 um 14:18 schrieb James Hughes:
>> > A previous change (5bfdc1097654) moved away from VLA's
>>
>> Please use the commit format mentioned in the link above.
>
> And actually, this SHA isn't the upstream SHA. This should be:
>
> a1547e0bca51 ("firmware: raspberrypi: Remove VLA usage")
>
>> > to a fixed maximum size for mailbox data.
>> > However, some mailbox calls use larger data buffers
>> > than the maximum allowed in that change. This fix therefor
>
> Which ones did this? In the initial change I couldn't find anything
> that exceeded 32 bytes. (I'm just curious if I missed something or if
> something new appeared.)
Nothing in tree used larger, it's that there are firmware transactions
that are bigger.
>> > [...]
>> > + /* Some mailboxes can use over 1k bytes. Rather than checking
>
> Up to Eric, but I think the preferred comment style is:
>
> /*
> * lines go here
> */
>
> Otherwise, this seems fine to me. Thanks for getting it fixed!
I have no preference about comment style, I just want fixes to land. :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-15 18:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CAOtG3WrGCwVd2DWq6Gq_ajZau0xJ-kPMvFRU6HyELYtUr30_VA@mail.gmail.com>
[not found] ` <3ac94357-5860-f9fd-740d-a2cd277fd0a8@i2se.com>
2018-11-15 18:19 ` [PATCH] firmware: raspberrypi: Fix firmware calls with large buffers Kees Cook
2018-11-15 18:41 ` Eric Anholt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).