From: Kees Cook <keescook@chromium.org>
To: Wang Long <long.wanglong@huawei.com>
Cc: Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
peifeiyue <peifeiyue@huawei.com>,
morgan.wang@huawei.com
Subject: Re: [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update
Date: Fri, 13 Mar 2015 16:47:06 -0700 [thread overview]
Message-ID: <CAGXu5jL8WkcYRP4PLwitWObFO6hMpEiRJAe-h4WN6Z1w4v5X+w@mail.gmail.com> (raw)
In-Reply-To: <1425886747-189445-1-git-send-email-long.wanglong@huawei.com>
On Mon, Mar 9, 2015 at 12:39 AM, Wang Long <long.wanglong@huawei.com> wrote:
> In the function ramoops_probe, the console_size, pmsg_size,
> ftrace_size may be update because the value is not the power
> of two. We should update the module parameter variables
> as well so they are visible through /sys/module/ramoops/parameters
> correctly.
>
> Signed-off-by: Wang Long <long.wanglong@huawei.com>
> ---
> fs/pstore/ram.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index 5df325e..1aaa8dc 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -559,6 +559,9 @@ pr_info("[%s] pstore_register", __func__);
> mem_address = pdata->mem_address;
> record_size = pdata->record_size;
> dump_oops = pdata->dump_oops;
> + ramoops_console_size = pdata->console_size;
> + ramoops_pmsg_size = pdata->pmsg_size;
> + ramoops_ftrace_size = pdata->ftrace_size;
>
> pr_info("attached 0x%lx@0x%llx, ecc: %d/%d\n",
> cxt->size, (unsigned long long)cxt->phys_addr,
I swear this had been fixed before. Thanks for catching it!
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
> --
> 1.8.3.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Kees Cook
Chrome OS Security
next prev parent reply other threads:[~2015-03-13 23:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 7:39 [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update Wang Long
2015-03-09 11:17 ` long.wanglong
2015-03-09 18:15 ` Mark Salyzyn
2015-03-13 23:47 ` Kees Cook [this message]
2015-03-16 18:18 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5jL8WkcYRP4PLwitWObFO6hMpEiRJAe-h4WN6Z1w4v5X+w@mail.gmail.com \
--to=keescook@chromium.org \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=long.wanglong@huawei.com \
--cc=morgan.wang@huawei.com \
--cc=peifeiyue@huawei.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).