* [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update
@ 2015-03-09 7:39 Wang Long
2015-03-09 11:17 ` long.wanglong
2015-03-13 23:47 ` Kees Cook
0 siblings, 2 replies; 5+ messages in thread
From: Wang Long @ 2015-03-09 7:39 UTC (permalink / raw)
To: anton, ccross, keescook, tony.luck
Cc: linux-kernel, long.wanglong, peifeiyue, morgan.wang
In the function ramoops_probe, the console_size, pmsg_size,
ftrace_size may be update because the value is not the power
of two. We should update the module parameter variables
as well so they are visible through /sys/module/ramoops/parameters
correctly.
Signed-off-by: Wang Long <long.wanglong@huawei.com>
---
fs/pstore/ram.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 5df325e..1aaa8dc 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -559,6 +559,9 @@ pr_info("[%s] pstore_register", __func__);
mem_address = pdata->mem_address;
record_size = pdata->record_size;
dump_oops = pdata->dump_oops;
+ ramoops_console_size = pdata->console_size;
+ ramoops_pmsg_size = pdata->pmsg_size;
+ ramoops_ftrace_size = pdata->ftrace_size;
pr_info("attached 0x%lx@0x%llx, ecc: %d/%d\n",
cxt->size, (unsigned long long)cxt->phys_addr,
--
1.8.3.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update
2015-03-09 7:39 [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update Wang Long
@ 2015-03-09 11:17 ` long.wanglong
2015-03-09 18:15 ` Mark Salyzyn
2015-03-13 23:47 ` Kees Cook
1 sibling, 1 reply; 5+ messages in thread
From: long.wanglong @ 2015-03-09 11:17 UTC (permalink / raw)
To: Wang Long
Cc: anton, ccross, keescook, tony.luck, linux-kernel, peifeiyue,
morgan.wang, anton.vorontsov, marco.stornelli, salyzyn, sergiu
On 2015/3/9 15:39, Wang Long wrote:
cc: marco.stornelli@gmail.com
cc: anton.vorontsov@linaro.org
cc: salyzyn@android.com
cc: sergiu@chromium.org
> In the function ramoops_probe, the console_size, pmsg_size,
> ftrace_size may be update because the value is not the power
> of two. We should update the module parameter variables
> as well so they are visible through /sys/module/ramoops/parameters
> correctly.
>
> Signed-off-by: Wang Long <long.wanglong@huawei.com>
> ---
> fs/pstore/ram.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index 5df325e..1aaa8dc 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -559,6 +559,9 @@ pr_info("[%s] pstore_register", __func__);
> mem_address = pdata->mem_address;
> record_size = pdata->record_size;
> dump_oops = pdata->dump_oops;
> + ramoops_console_size = pdata->console_size;
> + ramoops_pmsg_size = pdata->pmsg_size;
> + ramoops_ftrace_size = pdata->ftrace_size;
>
> pr_info("attached 0x%lx@0x%llx, ecc: %d/%d\n",
> cxt->size, (unsigned long long)cxt->phys_addr,
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update
2015-03-09 11:17 ` long.wanglong
@ 2015-03-09 18:15 ` Mark Salyzyn
0 siblings, 0 replies; 5+ messages in thread
From: Mark Salyzyn @ 2015-03-09 18:15 UTC (permalink / raw)
To: long.wanglong
Cc: anton, ccross, keescook, tony.luck, linux-kernel, peifeiyue,
morgan.wang, anton.vorontsov, marco.stornelli, sergiu
On 03/09/2015 04:17 AM, long.wanglong wrote:
> In the function ramoops_probe, the console_size, pmsg_size,
> ftrace_size may be update because the value is not the power
> of two. We should update the module parameter variables
> as well so they are visible through /sys/module/ramoops/parameters
> correctly.
>
> Signed-off-by: Wang Long <long.wanglong@huawei.com>
> ---
> fs/pstore/ram.c | 3 +++
> 1 file changed, 3 insertions(+)
Ack
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update
2015-03-09 7:39 [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update Wang Long
2015-03-09 11:17 ` long.wanglong
@ 2015-03-13 23:47 ` Kees Cook
2015-03-16 18:18 ` Luck, Tony
1 sibling, 1 reply; 5+ messages in thread
From: Kees Cook @ 2015-03-13 23:47 UTC (permalink / raw)
To: Wang Long
Cc: Anton Vorontsov, Colin Cross, Tony Luck, LKML, peifeiyue, morgan.wang
On Mon, Mar 9, 2015 at 12:39 AM, Wang Long <long.wanglong@huawei.com> wrote:
> In the function ramoops_probe, the console_size, pmsg_size,
> ftrace_size may be update because the value is not the power
> of two. We should update the module parameter variables
> as well so they are visible through /sys/module/ramoops/parameters
> correctly.
>
> Signed-off-by: Wang Long <long.wanglong@huawei.com>
> ---
> fs/pstore/ram.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index 5df325e..1aaa8dc 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -559,6 +559,9 @@ pr_info("[%s] pstore_register", __func__);
> mem_address = pdata->mem_address;
> record_size = pdata->record_size;
> dump_oops = pdata->dump_oops;
> + ramoops_console_size = pdata->console_size;
> + ramoops_pmsg_size = pdata->pmsg_size;
> + ramoops_ftrace_size = pdata->ftrace_size;
>
> pr_info("attached 0x%lx@0x%llx, ecc: %d/%d\n",
> cxt->size, (unsigned long long)cxt->phys_addr,
I swear this had been fixed before. Thanks for catching it!
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
> --
> 1.8.3.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Kees Cook
Chrome OS Security
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update
2015-03-13 23:47 ` Kees Cook
@ 2015-03-16 18:18 ` Luck, Tony
0 siblings, 0 replies; 5+ messages in thread
From: Luck, Tony @ 2015-03-16 18:18 UTC (permalink / raw)
To: Kees Cook, Wang Long
Cc: Anton Vorontsov, Colin Cross, LKML, peifeiyue, morgan.wang
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 369 bytes --]
> I swear this had been fixed before. Thanks for catching it!
Maybe I missed it?
> Acked-by: Kees Cook <keescook@chromium.org>
Got it this time - should show up in the next linux-next build.
Thanks
-Tony
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-03-16 18:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-09 7:39 [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update Wang Long
2015-03-09 11:17 ` long.wanglong
2015-03-09 18:15 ` Mark Salyzyn
2015-03-13 23:47 ` Kees Cook
2015-03-16 18:18 ` Luck, Tony
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).