From: Kees Cook <keescook@chromium.org>
To: Ingo Molnar <mingo@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Alexei Starovoitov <ast@kernel.org>,
Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
"H . Peter Anvin" <hpa@zytor.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Ian McDonald <ian.mcdonald@jandi.co.nz>,
Vlad Yasevich <vyasevich@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [RFC PATCH -tip 0/5] kprobes: Abolish jprobe APIs
Date: Fri, 20 Oct 2017 09:28:33 -0700 [thread overview]
Message-ID: <CAGXu5jLEhV+f-+1muz8nN0cWRvKP0aEEgG6X=5DOASY=MGmgzA@mail.gmail.com> (raw)
In-Reply-To: <20171020151751.drjmkxkt2orbteag@gmail.com>
On Fri, Oct 20, 2017 at 8:17 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Kees Cook <keescook@chromium.org> wrote:
>
>> On Fri, Oct 20, 2017 at 5:22 AM, Ingo Molnar <mingo@kernel.org> wrote:
>> >
>> > Ok, could we now also fix these:
>> >
>> > net/dccp/probe.c:166:2: warning: ‘register_jprobe’ is deprecated [-Wdeprecated-declarations]
>> > net/dccp/probe.c:170:4: warning: ‘register_jprobe’ is deprecated [-Wdeprecated-declarations]
>> > net/dccp/probe.c:190:2: warning: ‘unregister_jprobe’ is deprecated [-Wdeprecated-declarations]
>> > drivers/misc/lkdtm_core.c:317:3: warning: ‘unregister_jprobe’ is deprecated [-Wdeprecated-declarations]
>> > drivers/misc/lkdtm_core.c:322:2: warning: ‘register_jprobe’ is deprecated [-Wdeprecated-declarations]
>> > drivers/misc/lkdtm_core.c:560:3: warning: ‘unregister_jprobe’ is deprecated [-Wdeprecated-declarations]
>> > net/sctp/probe.c:189:2: warning: ‘register_jprobe’ is deprecated [-Wdeprecated-declarations]
>> > net/sctp/probe.c:194:3: warning: ‘register_jprobe’ is deprecated [-Wdeprecated-declarations]
>> > net/sctp/probe.c:240:2: warning: ‘unregister_jprobe’ is deprecated [-Wdeprecated-declarations]
>> > net/ipv4/tcp_probe.c:280:2: warning: ‘register_jprobe’ is deprecated [-Wdeprecated-declarations]
>> > net/ipv4/tcp_probe.c:298:2: warning: ‘unregister_jprobe’ is deprecated [-Wdeprecated-declarations]
>> >
>> > I'd suggest removing the networking ones and Cc:-ing it to the networking folks -
>> > I strongly doubt anyone is using that functionality for real.
>> >
>> > The LKDTM one Kees had some ideas (patches?) for?
>>
>> Oops, yes, I've sent this patch to Greg now. I had let it sit for a
>> few days of 0-day testing and promptly forgot about it. ;)
>
> Could we, as a special exception, carry this patch in -tip, so that the probes
> related changes stay togher - or is it too distruptive to the flow of other
> in-flight LKDTM patches, creating conflicts, etc.?
I have no problem with that, sure; these were the only outstanding
lkdtm patches (one for jprobes removal, and another for const
clean-ups noticed during the first patch's work). However, Greg pulled
them to his -testing tree already, so I guess it's up to him. Just let
me know what I can do to help. :)
-Kees
--
Kees Cook
Pixel Security
next prev parent reply other threads:[~2017-10-20 16:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 23:13 [RFC PATCH -tip 0/5] kprobes: Abolish jprobe APIs Masami Hiramatsu
2017-10-05 23:13 ` [RFC PATCH -tip 1/5] kprobes: Use ENOTSUPP instead of ENOSYS Masami Hiramatsu
2017-10-20 8:57 ` Ingo Molnar
2017-10-20 15:51 ` Masami Hiramatsu
2017-10-05 23:14 ` [RFC PATCH -tip 2/5] kprobes: Abolish jprobe APIs Masami Hiramatsu
2017-10-20 12:26 ` [tip:perf/core] kprobes: Disable the jprobes APIs tip-bot for Masami Hiramatsu
2017-10-05 23:15 ` [RFC PATCH -tip 3/5] kprobes: Disable jprobe test code Masami Hiramatsu
2017-10-20 12:26 ` [tip:perf/core] kprobes: Disable the jprobes " tip-bot for Masami Hiramatsu
2017-10-05 23:15 ` [RFC PATCH -tip 4/5] kprobes: Remove jprobe sample code Masami Hiramatsu
2017-10-20 12:27 ` [tip:perf/core] kprobes: Remove the jprobes " tip-bot for Masami Hiramatsu
2017-10-05 23:16 ` [RFC PATCH -tip 5/5] kprobes: docs: Remove jprobe related document Masami Hiramatsu
2017-10-20 12:27 ` [tip:perf/core] kprobes/docs: Remove jprobes related documents tip-bot for Masami Hiramatsu
2017-10-05 23:35 ` [RFC PATCH -tip 0/5] kprobes: Abolish jprobe APIs Kees Cook
2017-10-05 23:58 ` Steven Rostedt
2017-10-06 0:06 ` Kees Cook
2017-10-06 4:49 ` Masami Hiramatsu
2017-10-06 12:58 ` Steven Rostedt
2017-10-06 15:34 ` Steven Rostedt
2017-10-07 5:24 ` Stafford Horne
2017-10-09 16:48 ` Steven Rostedt
2017-10-07 8:55 ` Ingo Molnar
2017-10-09 16:45 ` Steven Rostedt
2017-10-07 9:35 ` Masami Hiramatsu
2017-10-09 16:59 ` Steven Rostedt
2017-10-09 15:33 ` Jonathan Corbet
2017-10-09 16:20 ` Steven Rostedt
2017-10-09 16:33 ` Jonathan Corbet
2017-10-09 16:41 ` Steven Rostedt
2017-10-09 18:10 ` Steven Rostedt
2017-10-10 14:02 ` Steven Rostedt
2017-10-06 0:32 ` Masami Hiramatsu
2017-10-06 1:11 ` Steven Rostedt
2017-10-06 4:47 ` Masami Hiramatsu
2017-10-20 12:22 ` Ingo Molnar
2017-10-20 13:32 ` Kees Cook
2017-10-20 15:17 ` Ingo Molnar
2017-10-20 16:28 ` Kees Cook [this message]
2017-10-21 8:06 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5jLEhV+f-+1muz8nN0cWRvKP0aEEgG6X=5DOASY=MGmgzA@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=ananth@linux.vnet.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=ian.mcdonald@jandi.co.nz \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=stephen@networkplumber.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).