* [PATCH 1/4] media/v4l2-core: Add enum V4L2_FWNODE_BUS_TYPE_DPI @ 2022-03-28 12:09 Xin Ji 2022-03-28 12:09 ` [PATCH 2/4] dt-bindings: media: video-interfaces: Add new bus-type Xin Ji ` (2 more replies) 0 siblings, 3 replies; 11+ messages in thread From: Xin Ji @ 2022-03-28 12:09 UTC (permalink / raw) To: Mauro Carvalho Chehab Cc: robert.foss, bliang, qwen, Xin Ji, linux-media, linux-kernel As V4L2_FWNODE_BUS_TYPE_PARALLEL is not used for DPI interface, this patch add V4L2_FWNODE_BUS_TYPE_DPI for video DPI interface. Signed-off-by: Xin Ji <xji@analogixsemi.com> --- drivers/media/v4l2-core/v4l2-fwnode.c | 4 ++++ include/media/v4l2-fwnode.h | 2 ++ include/media/v4l2-mediabus.h | 2 ++ 3 files changed, 8 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c index 00457e1e93f6..4bbb70b5e8c4 100644 --- a/drivers/media/v4l2-core/v4l2-fwnode.c +++ b/drivers/media/v4l2-core/v4l2-fwnode.c @@ -61,6 +61,10 @@ static const struct v4l2_fwnode_bus_conv { V4L2_FWNODE_BUS_TYPE_BT656, V4L2_MBUS_BT656, "Bt.656", + }, { + V4L2_FWNODE_BUS_TYPE_DPI, + V4L2_MBUS_DPI, + "DPI", } }; diff --git a/include/media/v4l2-fwnode.h b/include/media/v4l2-fwnode.h index 9c97f1dbd1c6..e17e59dbb2e3 100644 --- a/include/media/v4l2-fwnode.h +++ b/include/media/v4l2-fwnode.h @@ -222,6 +222,7 @@ struct v4l2_fwnode_connector { * @V4L2_FWNODE_BUS_TYPE_CSI2_DPHY: MIPI CSI-2 bus, D-PHY physical layer * @V4L2_FWNODE_BUS_TYPE_PARALLEL: Camera Parallel Interface bus * @V4L2_FWNODE_BUS_TYPE_BT656: BT.656 video format bus-type + * @V4L2_FWNODE_BUS_TYPE_DPI: Video Parallel Interface bus * @NR_OF_V4L2_FWNODE_BUS_TYPE: Number of bus-types */ enum v4l2_fwnode_bus_type { @@ -232,6 +233,7 @@ enum v4l2_fwnode_bus_type { V4L2_FWNODE_BUS_TYPE_CSI2_DPHY, V4L2_FWNODE_BUS_TYPE_PARALLEL, V4L2_FWNODE_BUS_TYPE_BT656, + V4L2_FWNODE_BUS_TYPE_DPI, NR_OF_V4L2_FWNODE_BUS_TYPE }; diff --git a/include/media/v4l2-mediabus.h b/include/media/v4l2-mediabus.h index 841e190aedd9..d35d8eafc7f7 100644 --- a/include/media/v4l2-mediabus.h +++ b/include/media/v4l2-mediabus.h @@ -103,6 +103,7 @@ * @V4L2_MBUS_CCP2: CCP2 (Compact Camera Port 2) * @V4L2_MBUS_CSI2_DPHY: MIPI CSI-2 serial interface, with D-PHY * @V4L2_MBUS_CSI2_CPHY: MIPI CSI-2 serial interface, with C-PHY + * @V4L2_MBUS_DPI: MIPI VIDEO DPI interface * @V4L2_MBUS_INVALID: invalid bus type (keep as last) */ enum v4l2_mbus_type { @@ -113,6 +114,7 @@ enum v4l2_mbus_type { V4L2_MBUS_CCP2, V4L2_MBUS_CSI2_DPHY, V4L2_MBUS_CSI2_CPHY, + V4L2_MBUS_DPI, V4L2_MBUS_INVALID, }; -- 2.25.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/4] dt-bindings: media: video-interfaces: Add new bus-type 2022-03-28 12:09 [PATCH 1/4] media/v4l2-core: Add enum V4L2_FWNODE_BUS_TYPE_DPI Xin Ji @ 2022-03-28 12:09 ` Xin Ji 2022-04-04 17:50 ` Rob Herring 2022-03-28 12:09 ` [PATCH 3/4] dt-bindings: drm/bridge: anx7625: Change bus-type to 7 (DPI) Xin Ji 2022-03-28 12:09 ` [PATCH 4/4] drm/bridge: anx7625: Use DPI bus type Xin Ji 2 siblings, 1 reply; 11+ messages in thread From: Xin Ji @ 2022-03-28 12:09 UTC (permalink / raw) To: Mauro Carvalho Chehab, Rob Herring, Sakari Ailus, Laurent Pinchart Cc: robert.foss, bliang, qwen, Xin Ji, linux-media, devicetree, linux-kernel No properly bus-type for DPI video bus, add bus-type 7 for it. Signed-off-by: Xin Ji <xji@analogixsemi.com> --- Documentation/devicetree/bindings/media/video-interfaces.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/media/video-interfaces.yaml b/Documentation/devicetree/bindings/media/video-interfaces.yaml index 4391dce2caee..68c3b9871cf3 100644 --- a/Documentation/devicetree/bindings/media/video-interfaces.yaml +++ b/Documentation/devicetree/bindings/media/video-interfaces.yaml @@ -93,6 +93,7 @@ properties: - 4 # MIPI CSI-2 D-PHY - 5 # Parallel - 6 # BT.656 + - 7 # DPI description: Data bus type. -- 2.25.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 2/4] dt-bindings: media: video-interfaces: Add new bus-type 2022-03-28 12:09 ` [PATCH 2/4] dt-bindings: media: video-interfaces: Add new bus-type Xin Ji @ 2022-04-04 17:50 ` Rob Herring 0 siblings, 0 replies; 11+ messages in thread From: Rob Herring @ 2022-04-04 17:50 UTC (permalink / raw) To: Xin Ji Cc: devicetree, qwen, Rob Herring, robert.foss, Laurent Pinchart, Sakari Ailus, linux-kernel, Mauro Carvalho Chehab, linux-media, bliang On Mon, 28 Mar 2022 20:09:53 +0800, Xin Ji wrote: > No properly bus-type for DPI video bus, add bus-type 7 for it. > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > --- > Documentation/devicetree/bindings/media/video-interfaces.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 3/4] dt-bindings: drm/bridge: anx7625: Change bus-type to 7 (DPI) 2022-03-28 12:09 [PATCH 1/4] media/v4l2-core: Add enum V4L2_FWNODE_BUS_TYPE_DPI Xin Ji 2022-03-28 12:09 ` [PATCH 2/4] dt-bindings: media: video-interfaces: Add new bus-type Xin Ji @ 2022-03-28 12:09 ` Xin Ji 2022-04-04 17:52 ` Rob Herring 2022-03-28 12:09 ` [PATCH 4/4] drm/bridge: anx7625: Use DPI bus type Xin Ji 2 siblings, 1 reply; 11+ messages in thread From: Xin Ji @ 2022-03-28 12:09 UTC (permalink / raw) To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter, Rob Herring, Xin Ji Cc: bliang, qwen, Rob Herring, dri-devel, devicetree, linux-kernel Change bus-type define for DPI. Fixes: a43661e7e819 ("dt-bindings:drm/bridge:anx7625:add vendor define") Signed-off-by: Xin Ji <xji@analogixsemi.com> --- .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml index 0d38d6fe3983..4590186c4a0b 100644 --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml @@ -106,7 +106,7 @@ properties: remote-endpoint: true bus-type: - enum: [1, 5] + enum: [7] default: 1 data-lanes: true @@ -158,7 +158,7 @@ examples: reg = <0>; anx7625_in: endpoint { remote-endpoint = <&mipi_dsi>; - bus-type = <5>; + bus-type = <7>; data-lanes = <0 1 2 3>; }; }; -- 2.25.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 3/4] dt-bindings: drm/bridge: anx7625: Change bus-type to 7 (DPI) 2022-03-28 12:09 ` [PATCH 3/4] dt-bindings: drm/bridge: anx7625: Change bus-type to 7 (DPI) Xin Ji @ 2022-04-04 17:52 ` Rob Herring 2022-04-09 4:47 ` Xin Ji 0 siblings, 1 reply; 11+ messages in thread From: Rob Herring @ 2022-04-04 17:52 UTC (permalink / raw) To: Xin Ji Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter, bliang, qwen, dri-devel, devicetree, linux-kernel On Mon, Mar 28, 2022 at 08:09:54PM +0800, Xin Ji wrote: > Change bus-type define for DPI. > > Fixes: a43661e7e819 ("dt-bindings:drm/bridge:anx7625:add vendor define") > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > --- > .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > index 0d38d6fe3983..4590186c4a0b 100644 > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > @@ -106,7 +106,7 @@ properties: > remote-endpoint: true > > bus-type: > - enum: [1, 5] > + enum: [7] Changing is an ABI break, but didn't we revert adding this? > default: 1 > > data-lanes: true > @@ -158,7 +158,7 @@ examples: > reg = <0>; > anx7625_in: endpoint { > remote-endpoint = <&mipi_dsi>; > - bus-type = <5>; > + bus-type = <7>; > data-lanes = <0 1 2 3>; > }; > }; > -- > 2.25.1 > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/4] dt-bindings: drm/bridge: anx7625: Change bus-type to 7 (DPI) 2022-04-04 17:52 ` Rob Herring @ 2022-04-09 4:47 ` Xin Ji 2022-04-13 14:28 ` Robert Foss 0 siblings, 1 reply; 11+ messages in thread From: Xin Ji @ 2022-04-09 4:47 UTC (permalink / raw) To: Rob Herring Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter, bliang, qwen, dri-devel, devicetree, linux-kernel On Mon, Apr 04, 2022 at 12:52:14PM -0500, Rob Herring wrote: > On Mon, Mar 28, 2022 at 08:09:54PM +0800, Xin Ji wrote: > > Change bus-type define for DPI. > > > > Fixes: a43661e7e819 ("dt-bindings:drm/bridge:anx7625:add vendor define") > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > --- > > .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > index 0d38d6fe3983..4590186c4a0b 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > @@ -106,7 +106,7 @@ properties: > > remote-endpoint: true > > > > bus-type: > > - enum: [1, 5] > > + enum: [7] > > Changing is an ABI break, but didn't we revert adding this? Hi Rob, sorry, what do you mean about ABI break? Do I need remove this patch in this serial? Or do I need revert patch https://patchwork.freedesktop.org/patch/462331/, I don't know how to do it. Thanks, Xin > > > default: 1 > > > > data-lanes: true > > @@ -158,7 +158,7 @@ examples: > > reg = <0>; > > anx7625_in: endpoint { > > remote-endpoint = <&mipi_dsi>; > > - bus-type = <5>; > > + bus-type = <7>; > > data-lanes = <0 1 2 3>; > > }; > > }; > > -- > > 2.25.1 > > > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/4] dt-bindings: drm/bridge: anx7625: Change bus-type to 7 (DPI) 2022-04-09 4:47 ` Xin Ji @ 2022-04-13 14:28 ` Robert Foss 2022-04-14 2:26 ` Xin Ji 0 siblings, 1 reply; 11+ messages in thread From: Robert Foss @ 2022-04-13 14:28 UTC (permalink / raw) To: Xin Ji Cc: Rob Herring, Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter, bliang, qwen, dri-devel, devicetree, linux-kernel On Sat, 9 Apr 2022 at 06:47, Xin Ji <xji@analogixsemi.com> wrote: > > On Mon, Apr 04, 2022 at 12:52:14PM -0500, Rob Herring wrote: > > On Mon, Mar 28, 2022 at 08:09:54PM +0800, Xin Ji wrote: > > > Change bus-type define for DPI. > > > > > > Fixes: a43661e7e819 ("dt-bindings:drm/bridge:anx7625:add vendor define") > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > > --- > > > .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > index 0d38d6fe3983..4590186c4a0b 100644 > > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > @@ -106,7 +106,7 @@ properties: > > > remote-endpoint: true > > > > > > bus-type: > > > - enum: [1, 5] > > > + enum: [7] > > > > Changing is an ABI break, but didn't we revert adding this? > Hi Rob, sorry, what do you mean about ABI break? Do I need remove this > patch in this serial? Or do I need revert patch > https://patchwork.freedesktop.org/patch/462331/, I don't know how to do > it. > I contributed to the confusion about this, let's see if we can clear it up. An issue was found related to which enum values were used to represent what late in the last release cycle. As a result a revert[1] patch for everything touching bus-type in anx7625 was merged. This patch, does not apply to drm-misc-next due to the revert, and if Xin Ji rebases his work on the drm-misc-next there should be no ABI-change as this patch when fixed up will introduce bus-type to the nax7625 ABI. Xin: Does this make sense to you? [1] https://cgit.freedesktop.org/drm/drm-misc/commit/?id=979452fbc43028675b5a5da156f91928b739dea8 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/4] dt-bindings: drm/bridge: anx7625: Change bus-type to 7 (DPI) 2022-04-13 14:28 ` Robert Foss @ 2022-04-14 2:26 ` Xin Ji 2022-04-18 6:31 ` Chen-Yu Tsai 0 siblings, 1 reply; 11+ messages in thread From: Xin Ji @ 2022-04-14 2:26 UTC (permalink / raw) To: Robert Foss Cc: Rob Herring, Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter, bliang, qwen, dri-devel, devicetree, linux-kernel On Wed, Apr 13, 2022 at 04:28:51PM +0200, Robert Foss wrote: > On Sat, 9 Apr 2022 at 06:47, Xin Ji <xji@analogixsemi.com> wrote: > > > > On Mon, Apr 04, 2022 at 12:52:14PM -0500, Rob Herring wrote: > > > On Mon, Mar 28, 2022 at 08:09:54PM +0800, Xin Ji wrote: > > > > Change bus-type define for DPI. > > > > > > > > Fixes: a43661e7e819 ("dt-bindings:drm/bridge:anx7625:add vendor define") > > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > > > --- > > > > .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > > index 0d38d6fe3983..4590186c4a0b 100644 > > > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > > @@ -106,7 +106,7 @@ properties: > > > > remote-endpoint: true > > > > > > > > bus-type: > > > > - enum: [1, 5] > > > > + enum: [7] > > > > > > Changing is an ABI break, but didn't we revert adding this? > > Hi Rob, sorry, what do you mean about ABI break? Do I need remove this > > patch in this serial? Or do I need revert patch > > https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fpatch%2F462331%2F&data=04%7C01%7Cxji%40analogixsemi.com%7C10f5b0213f434592936008da1d59f566%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637854569490105386%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=vK0Vmb9S425kHZc1WurfnNhnoXDMbUGkkdY1PVnfS9g%3D&reserved=0, I don't know how to do > > it. > > > > I contributed to the confusion about this, let's see if we can clear it up. > > An issue was found related to which enum values were used to represent > what late in the last release cycle. As a result a revert[1] patch for > everything touching bus-type in anx7625 was merged. > > This patch, does not apply to drm-misc-next due to the revert, and if > Xin Ji rebases his work on the drm-misc-next there should be no > ABI-change as this patch when fixed up will introduce bus-type to the > nax7625 ABI. > > Xin: Does this make sense to you? Hi Robert Foss, yes, my work is based on drm-misc-next, all I can do, just make a fix up patch(this patch) to change the bus-type define. Thanks, Xin > > [1] https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcgit.freedesktop.org%2Fdrm%2Fdrm-misc%2Fcommit%2F%3Fid%3D979452fbc43028675b5a5da156f91928b739dea8&data=04%7C01%7Cxji%40analogixsemi.com%7C10f5b0213f434592936008da1d59f566%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637854569490105386%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=onmKAoEEP1XDbl%2FaeAIfVYJ4cSbiTfTBYCd%2BHCA9fzw%3D&reserved=0 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/4] dt-bindings: drm/bridge: anx7625: Change bus-type to 7 (DPI) 2022-04-14 2:26 ` Xin Ji @ 2022-04-18 6:31 ` Chen-Yu Tsai 2022-04-22 8:04 ` Xin Ji 0 siblings, 1 reply; 11+ messages in thread From: Chen-Yu Tsai @ 2022-04-18 6:31 UTC (permalink / raw) To: Xin Ji Cc: Robert Foss, dri-devel, Jonas Karlman, David Airlie, qwen, Neil Armstrong, linux-kernel, Jernej Skrabec, devicetree, Laurent Pinchart, Andrzej Hajda, bliang Hi, On Thu, Apr 14, 2022 at 10:27 AM Xin Ji <xji@analogixsemi.com> wrote: > > On Wed, Apr 13, 2022 at 04:28:51PM +0200, Robert Foss wrote: > > On Sat, 9 Apr 2022 at 06:47, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > On Mon, Apr 04, 2022 at 12:52:14PM -0500, Rob Herring wrote: > > > > On Mon, Mar 28, 2022 at 08:09:54PM +0800, Xin Ji wrote: > > > > > Change bus-type define for DPI. > > > > > > > > > > Fixes: a43661e7e819 ("dt-bindings:drm/bridge:anx7625:add vendor define") > > > > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > > > > --- > > > > > .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 4 ++-- > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > > > index 0d38d6fe3983..4590186c4a0b 100644 > > > > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > > > @@ -106,7 +106,7 @@ properties: > > > > > remote-endpoint: true > > > > > > > > > > bus-type: > > > > > - enum: [1, 5] > > > > > + enum: [7] > > > > > > > > Changing is an ABI break, but didn't we revert adding this? > > > Hi Rob, sorry, what do you mean about ABI break? Do I need remove this > > > patch in this serial? Or do I need revert patch > > > https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fpatch%2F462331%2F&data=04%7C01%7Cxji%40analogixsemi.com%7C10f5b0213f434592936008da1d59f566%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637854569490105386%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=vK0Vmb9S425kHZc1WurfnNhnoXDMbUGkkdY1PVnfS9g%3D&reserved=0, I don't know how to do > > > it. > > > > > > > I contributed to the confusion about this, let's see if we can clear it up. > > > > An issue was found related to which enum values were used to represent > > what late in the last release cycle. As a result a revert[1] patch for > > everything touching bus-type in anx7625 was merged. > > > > This patch, does not apply to drm-misc-next due to the revert, and if > > Xin Ji rebases his work on the drm-misc-next there should be no > > ABI-change as this patch when fixed up will introduce bus-type to the > > nax7625 ABI. > > > > Xin: Does this make sense to you? > Hi Robert Foss, yes, my work is based on drm-misc-next, all I can do, > just make a fix up patch(this patch) to change the bus-type define. The revert was applied to the soc tree and merged into Linus's tree in v5.17-rc8. It was not present in drm-misc-next until April 5 with commit 9cbbd694a58b ("Merge drm/drm-next into drm-misc-next"). So please fetch the latest drm-misc-next, rebase your patches on top, and resend. Thanks ChenYu ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/4] dt-bindings: drm/bridge: anx7625: Change bus-type to 7 (DPI) 2022-04-18 6:31 ` Chen-Yu Tsai @ 2022-04-22 8:04 ` Xin Ji 0 siblings, 0 replies; 11+ messages in thread From: Xin Ji @ 2022-04-22 8:04 UTC (permalink / raw) To: Chen-Yu Tsai Cc: Robert Foss, dri-devel, Jonas Karlman, David Airlie, qwen, Neil Armstrong, linux-kernel, Jernej Skrabec, devicetree, Laurent Pinchart, Andrzej Hajda, bliang On Mon, Apr 18, 2022 at 02:31:38PM +0800, Chen-Yu Tsai wrote: > Hi, > > On Thu, Apr 14, 2022 at 10:27 AM Xin Ji <xji@analogixsemi.com> wrote: > > > > On Wed, Apr 13, 2022 at 04:28:51PM +0200, Robert Foss wrote: > > > On Sat, 9 Apr 2022 at 06:47, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > > > On Mon, Apr 04, 2022 at 12:52:14PM -0500, Rob Herring wrote: > > > > > On Mon, Mar 28, 2022 at 08:09:54PM +0800, Xin Ji wrote: > > > > > > Change bus-type define for DPI. > > > > > > > > > > > > Fixes: a43661e7e819 ("dt-bindings:drm/bridge:anx7625:add vendor define") > > > > > > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > > > > > --- > > > > > > .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 4 ++-- > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > > > > index 0d38d6fe3983..4590186c4a0b 100644 > > > > > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > > > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > > > > @@ -106,7 +106,7 @@ properties: > > > > > > remote-endpoint: true > > > > > > > > > > > > bus-type: > > > > > > - enum: [1, 5] > > > > > > + enum: [7] > > > > > > > > > > Changing is an ABI break, but didn't we revert adding this? > > > > Hi Rob, sorry, what do you mean about ABI break? Do I need remove this > > > > patch in this serial? Or do I need revert patch > > > > https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fpatch%2F462331%2F&data=04%7C01%7Cxji%40analogixsemi.com%7C7d3089c9ec10458a4ea208da21051e7b%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637858603556318586%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=YMjW9RnMbbIiUA7dVCitqo9P2Axr2MxPCxxUK3W6pII%3D&reserved=0, I don't know how to do > > > > it. > > > > > > > > > > I contributed to the confusion about this, let's see if we can clear it up. > > > > > > An issue was found related to which enum values were used to represent > > > what late in the last release cycle. As a result a revert[1] patch for > > > everything touching bus-type in anx7625 was merged. > > > > > > This patch, does not apply to drm-misc-next due to the revert, and if > > > Xin Ji rebases his work on the drm-misc-next there should be no > > > ABI-change as this patch when fixed up will introduce bus-type to the > > > nax7625 ABI. > > > > > > Xin: Does this make sense to you? > > Hi Robert Foss, yes, my work is based on drm-misc-next, all I can do, > > just make a fix up patch(this patch) to change the bus-type define. > > The revert was applied to the soc tree and merged into Linus's tree > in v5.17-rc8. It was not present in drm-misc-next until April 5 with > commit 9cbbd694a58b ("Merge drm/drm-next into drm-misc-next"). > > So please fetch the latest drm-misc-next, rebase your patches on top, and > resend. Hi ChenYu, OK, I'll resend this patch serial. Thanks, Xin > > > Thanks > ChenYu ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 4/4] drm/bridge: anx7625: Use DPI bus type 2022-03-28 12:09 [PATCH 1/4] media/v4l2-core: Add enum V4L2_FWNODE_BUS_TYPE_DPI Xin Ji 2022-03-28 12:09 ` [PATCH 2/4] dt-bindings: media: video-interfaces: Add new bus-type Xin Ji 2022-03-28 12:09 ` [PATCH 3/4] dt-bindings: drm/bridge: anx7625: Change bus-type to 7 (DPI) Xin Ji @ 2022-03-28 12:09 ` Xin Ji 2 siblings, 0 replies; 11+ messages in thread From: Xin Ji @ 2022-03-28 12:09 UTC (permalink / raw) To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter, Xin Ji Cc: bliang, qwen, dri-devel, linux-kernel As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it. Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") Signed-off-by: Xin Ji <xji@analogixsemi.com> --- drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index 9a2a19ad4202..c528fa2c9533 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -1615,14 +1615,14 @@ static int anx7625_parse_dt(struct device *dev, anx7625_get_swing_setting(dev, pdata); - pdata->is_dpi = 1; /* default dpi mode */ + pdata->is_dpi = 0; /* default dsi mode */ pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0); if (!pdata->mipi_host_node) { DRM_DEV_ERROR(dev, "fail to get internal panel.\n"); return -ENODEV; } - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL; + bus_type = 0; mipi_lanes = MAX_LANES_SUPPORT; ep0 = of_graph_get_endpoint_by_regs(np, 0, 0); if (ep0) { @@ -1632,8 +1632,8 @@ static int anx7625_parse_dt(struct device *dev, mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes"); } - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */ - pdata->is_dpi = 0; + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */ + pdata->is_dpi = 1; pdata->mipi_lanes = mipi_lanes; if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0) -- 2.25.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-04-22 8:06 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-03-28 12:09 [PATCH 1/4] media/v4l2-core: Add enum V4L2_FWNODE_BUS_TYPE_DPI Xin Ji 2022-03-28 12:09 ` [PATCH 2/4] dt-bindings: media: video-interfaces: Add new bus-type Xin Ji 2022-04-04 17:50 ` Rob Herring 2022-03-28 12:09 ` [PATCH 3/4] dt-bindings: drm/bridge: anx7625: Change bus-type to 7 (DPI) Xin Ji 2022-04-04 17:52 ` Rob Herring 2022-04-09 4:47 ` Xin Ji 2022-04-13 14:28 ` Robert Foss 2022-04-14 2:26 ` Xin Ji 2022-04-18 6:31 ` Chen-Yu Tsai 2022-04-22 8:04 ` Xin Ji 2022-03-28 12:09 ` [PATCH 4/4] drm/bridge: anx7625: Use DPI bus type Xin Ji
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).